bus-test dispatch test on linux failed

Submitted by rongqing

Assigned to D-Bus Maintainers

Description

On X86-64, linux, The test of bus-test dispatch failed, The test shows dbus-1.6.10 and dbus-1.6.18 have the same issue.

./bus/bus-test: Running message dispatch test Activating service name='org.freedesktop.DBus.TestSuiteEchoService' Successfully activated service 'org.freedesktop.DBus.TestSuiteEchoService' 6363: assertion failed "_dbus_string_get_length (& DBUS_AUTH_CLIENT (auth)->guid_from_server) == 0" file "dbus-auth.c" line 1545 function process_ok ./bus/bus-test(_dbus_print_backtrace+0x29) [0x80cb969] ./bus/bus-test(_dbus_abort+0x14) [0x80cfb44] ./bus/bus-test(_dbus_real_assert+0x53) [0x80b52c3] ./bus/bus-test() [0x80e24da] ./bus/bus-test(_dbus_auth_do_work+0x388) [0x80e3848] ./bus/bus-test() [0x80aea49] ./bus/bus-test() [0x80affde] ./bus/bus-test(_dbus_transport_handle_watch+0xb1) [0x80ad841] ./bus/bus-test(_dbus_connection_handle_watch+0x104) [0x8089174] ./bus/bus-test(dbus_watch_handle+0xd8) [0x80b15e8] ./bus/bus-test(_dbus_loop_iterate+0x4a9) [0x80d1509] ./bus/bus-test(bus_test_run_clients_loop+0x5d) [0x808129d] ./bus/bus-test() [0x806cab0] ./bus/bus-test() [0x806e0ca] ./bus/bus-test() [0x806da6f] ./bus/bus-test(_dbus_test_oom_handling+0x18c) [0x80b5c8c] ./bus/bus-test() [0x806f723] ./bus/bus-test(bus_dispatch_test+0x3c) [0x8071aac] ./bus/bus-test(main+0x1b7) [0x805acc7] /lib/libc.so.6(__libc_start_main+0xf3) [0x45f919b3] ./bus/bus-test() [0x805ae39]

It always happens on my machine, If can not reproduce it, I think we can modify the code to trigger this issue, let send_negotiate_unix_fd to return FALSE directly to simulator _dbus_string_append failure

diff --git a/dbus/dbus-auth.c b/dbus/dbus-auth.c index 37b45c6..968f544 100644 --- a/dbus/dbus-auth.c +++ b/dbus/dbus-auth.c @@ -1642,6 +1642,7 @@ process_data (DBusAuth *auth, static dbus_bool_t send_negotiate_unix_fd (DBusAuth *auth) {

return FALSE; if (!_dbus_string_append (&auth->outgoing, "NEGOTIATE_UNIX_FD\r\n")) return FALSE;

}

a patch is submitted to

http://lists.freedesktop.org/archives/dbus/2014-February/016122.html

Version: 1.5