- May 11, 2022
-
-
Dylan Baker authored
-
Dylan Baker authored
-
We need to be able to track the descriptor sets explicity to unref the descriptor sets, otherwise these descriptor sets will not unref the descriptor set layout it holds. Closes: mesa/mesa#6222 Fixes: 66f7289d ("radv: add reference counting for descriptor set layouts") Tested-by: Jakob Bornecrantz <jakob@collabora.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!15741> (cherry picked from commit 96a240e1)
-
If the secondary command buffer executed used push constants on a different set of stages than the primary is using, we may end up not reallocating them for the primary, getting misrender artifacts at best, or a nice GPU hang at worst. Fixes the tests from a CTS from the future: dEQP-VK.dynamic_rendering.random.* Cc: mesa-stable Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!16439> (cherry picked from commit 2e46f389)
-
this wasn't taking into account the format swizzle, returning broken alpha values in most cases Fixes: 0b6554ba ("gallivm,llvmpipe: handle TXF (texelFetch) instruction, including offsets") Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!16137> (cherry picked from commit f5caaf2d)
-
skipping these would lead to reading the previously-set data if a null buffer was set after a valid buffer cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!16137> (cherry picked from commit 6a219f31)
-
the first case in gallivm did no checking, so this was always going to be broken, so instead just copy the now-correct ssbo logic cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!16137> (cherry picked from commit f1d1371e)
-
these shaders all do float-based reads, so using vec4 for robustness checks breaks gallivm cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!16137> (cherry picked from commit a51e83b7)
-
this is a cmdbuf function, which means it gets enqueued, which means the template can't be destroyed until the cmdbuf has finished using it cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!16137> (cherry picked from commit 49df9eeb)
-
this was checking (offset < size) when really it needs to be (offset < size && extent < size && offset >= 0) Fixes: 591899ee ("gallivm/nir: Add a short circuit uniform-offset mode for load_ssbo/load_shared.") Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!16137> (cherry picked from commit aa98a902)
-
The comment above is correct, but the code to calculate the mask was broken. No Foz-db changes outside of noise. Fixes: 0e6581b8 ("nir/algebraic: Reassociate shift-by-constant of shift-by-constant") Signed-off-by: Georg Lehmann <dadschoorse@gmail.com> Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!15990> (cherry picked from commit 66e917ff)
-
Sampler views and samplers may not be the same limit; in fact one is 32 while the other is 128. The sampler_buffers field is tracking sampler views (yes, naming is confusing) so we should use the right limit. Fixes: e9c41b32 ("gallium/u_threaded: add buffer lists - tracking of buffers referenced by tc") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Reviewed-by: Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!15988> (cherry picked from commit 620c5e9d)
-
If two instructions in a single bundle both write to a spilt destination, then we need to reuse the fill and spill instructions, otherwise the value will be overwritten. This and the rest of this set of Midgard bug fixes were found from a vertex shader in Firefox WebRender that is used when a video is clipped, for example by setting the border-radius CSS property. CC: mesa-stable Part-of: <mesa/mesa!16382> (cherry picked from commit c65afe54)
-
We can't return a pointer to the bundle itself because it might move about in memory. CC: mesa-stable Part-of: <mesa/mesa!16382> (cherry picked from commit 7b9c976c)
-
Check the bytemask against 0xFFFF rather than 0xF so that the fill is skipped for a .xyzw write rather than a .x write. Set the mask on the store to 0xF when doing a read so that all components are written back. Fixes: 31d26ebf ("pan/mdg: Fill from TLS before spilling non-SSA nodes") Part-of: <mesa/mesa!16382> (cherry picked from commit c750ab8a)
-
If a value is written in a vector CSEL but then written again by other instructions, it still needs full alignment, so set min_alignment using MAX2 to avoid ever reducing it. Fixes: 1798f6bf ("pan/midgard: Fix masks/alignment for 64-bit loads") Part-of: <mesa/mesa!16382> (cherry picked from commit b2818439)
-
Otherwise LCRA will try to divide by zero when calculating m_max. Fixes: 553c2cf1 ("pan/mdg: Set RA bounds for fp16") Part-of: <mesa/mesa!16382> (cherry picked from commit b1ecb909)
-
When moving code into the main block or loop blocks, put the code into its own : if(true) { ... } block so that we avoid break/continue/return issues. v2: Also take care of the main block with return instructions v3: Make deletion more obvious with dummy if blocks (Jason) v4: Fixup assert for loops (Lionel) Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 8dfb240b ("nir: Add raytracing shader call lowering pass.") Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!16036> (cherry picked from commit 35d82ecf)
-
When moving code from below to the insertion cursor point, if the cursor points to a jump instruction, don't bother inserting the code. It would break the break/continue assumptions of NIR and would not be executed anyway. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 8dfb240b ("nir: Add raytracing shader call lowering pass.") Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!16036> (cherry picked from commit 9cf986dc)
-
Stop using nop instructions which are causing issues with break/continue, instead use a nir_cursor (which brings its share of pain). Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 8dfb240b ("nir: Add raytracing shader call lowering pass.") Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!16036> (cherry picked from commit 51dea59e)
-
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!16036> (cherry picked from commit 25661ea0)
-
This will be useful to cut code from one location and paste it at another place and later keep pasting after the previous insertions. v2: update comment (Jason) deal with stiching 2 empty blocks (Jason) Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <mesa/mesa!16036> (cherry picked from commit d65cf403)
-
Clang opaque pointers have been enabled by default but the Clover code currently expects them to be disabled. Signed-off-by: Thomas Debesse <dev@illwieckz.net> Reviewed-by: Francisco Jerez <currojerez@riseup.net> Cc: mesa-stable Closes: mesa/mesa#6342 Part-of: <mesa/mesa!16129> (cherry picked from commit 06e96074)
-
For games that needs >1 at the same time the existing check wasn't enough. Cc: mesa-stable Reviewed-by: Hans-Kristian Arntzen <post@arntzen-software.no> Part-of: <mesa/mesa!15132> (cherry picked from commit a7f44b62)
-
Fixes NIR validation errors for OpenMW on Panfrost. Fixes: 1f97819f ("panfrost: Emulate GL_CLAMP on Bifrost") Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <mesa/mesa!15939> (cherry picked from commit ad864a7c)
-
We use the non-strict algorithm (with parallelograms) prior to Gen10 for wide lines. We can not advertise rectangularLines. Signed-off-by: Chia-I Wu <olvaffe@gmail.com> Fixes: f6e7de41 ("anv: Implement VK_EXT_line_rasterization") Reviewed-by: Ivan Briano <ivan.briano@intel.com> Part-of: <mesa/mesa!15432> (cherry picked from commit b2b810eb)
-
in a sequence where a driver saves 0 sampler/views before calling u_blitter, the previous state of having 0 sampler/views bound would not be restored as expected, resulting in stale sampler/views which could affect behavior before new sampler/views were bound cc: mesa-stable Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!16178> (cherry picked from commit 38ab178c)
-
Dylan Baker authored
-
Dylan Baker authored
-
Dylan Baker authored
-
Dylan Baker authored
-
Dylan Baker authored
-
Dylan Baker authored
-
Dylan Baker authored
-
Dylan Baker authored
-
Mike Blumenkrantz authored
-
Mike Blumenkrantz authored
nvidia can't do this, but also nothing uses it, so I've gone ahead and done the bare minimum here to make cts pass I think the work to do the shader rewrites should be easy, but without a test case, I see no point in spending the time for it Acked-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!16100>
-
Mike Blumenkrantz authored
this is big enough to batch all the cts binds into a single submit Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!16100>
-
Mike Blumenkrantz authored
you stare at the code for so long without truly seeing it cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!16100>
-
Mike Blumenkrantz authored
they're allocated through TexStorage, so they can do everything cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!16100>
-