- Aug 23, 2019
-
-
Juan A. Suárez authored
Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
Juan A. Suárez authored
Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
- Aug 20, 2019
-
-
This only appears to happen on Raven2. Possible way to reproduce: resource_get_handle(WINSYS_HANDLE_TYPE_KMS) --> sets is_shared = true resource_get_handle(WINSYS_HANDLE_TYPE_DMABUF) --> fail Cc: 19.1 19.2 <mesa-stable@lists.freedesktop.org> (cherry picked from commit 8d0d753b)
-
- Aug 10, 2019
-
-
Reviewed-by:
Eric Engestrom <eric.engestrom@intel.com> Fixes: 134e750e ("i965: extract performance query metrics") (cherry picked from commit ac156108)
-
Fixes: 4201cc2d ("anv: Implement VK_KHX_external_semaphore_fd") Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Eric Engestrom <eric.engestrom@intel.com> (cherry picked from commit 2be3f166)
-
There is an object-level preemption workaround which requires this. However, even without object-level preemption, we seem to have issues with geometry flickering when 3D and compute are combined in the same batch and this appears to fix it. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110395 Suggested-by:
Jason Ekstrand <jason@jlekstrand.net> Signed-off-by:
Danylo Piliaiev <danylo.piliaiev@globallogic.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit b8842bc3)
-
CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit 23a9d209) [Juan A. Suarez: resolve trivial conflicts] Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com> Conflicts: src/amd/vulkan/radv_pipeline.c
-
Mirroring radeonsi. CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit 4a3f987a) [Juan A. Suarez: resolve trivial conflicts] Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com> Conflicts: src/amd/vulkan/radv_pipeline.c
-
- Aug 08, 2019
-
-
Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> Fixes: 3f6b3d9d ("gallium: add PIPE_QUERY_OCCLUSION_PREDICATE_CONSERVATIVE") Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit da9e2958)
-
Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> Fixes: a677799e ("gallium: add PIPE_QUERY_SO_OVERFLOW_ANY_PREDICATE and corresponding cap") Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit 70a93922)
-
Fixes: 759b9403 ("util: Get program name based on path when possible") Signed-off-by:
Eric Engestrom <eric.engestrom@intel.com> Reviewed-by:
Tapani Pälli <tapani.palli@intel.com> (cherry picked from commit 5b10ddf3)
-
program_invocation_name and program_invocation_short_name are both GNU extensions. I don't believe one can exist without the other, so only check for program_invocation_name. Reviewed-by:
Eric Engestrom <eric.engestrom@intel.com> (cherry picked from commit c9b86cf5)
-
Cc: 19.1 19.2 <mesa-stable@lists.freedesktop.org> Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> (cherry picked from commit 6b3ee869) [Juan A. Suarez: resolve trivial conflicts] Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com> Conflicts: src/gallium/drivers/radeonsi/cik_sdma.c
-
Fixes: 028ce527 "radv: Add non-uniform indexing lowering." Reviewed-by:
Dave Airlie <airlied@redhat.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit 2af00b1f)
-
Since it can introduce comparisons. Fixes: 028ce527 "radv: Add non-uniform indexing lowering." Reviewed-by:
Dave Airlie <airlied@redhat.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit 2301b2e0)
-
There is an object-level preemption workaround which requires this. However, even without object-level preemption, we seem to have issues with geometry flickering when 3D and compute are combined in the same batch and this appears to fix it. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109630 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111267 Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit bc612536)
-
Juan A. Suárez authored
Fixes: This commit does not apply cleanly on 19.1 branch, as it depends on other commits not present in the branch. Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
- Aug 07, 2019
-
-
Test-case with depth-clear 0.5 and format MESA_FORMAT_Z24_UNORM_X8_UINT fails due inconsistent clear-value of 0.4999997. Maybe its better to improve? CC: Jason Ekstrand <jason.ekstrand@intel.com> Fixes: 0ae9ce0f (i965/clear: Quantize the depth clear value based on the format) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111113 Signed-off-by:
Sergii Romantsov <sergii.romantsov@globallogic.com> Signed-off-by:
Danylo Piliaiev <danylo.piliaiev@globallogic.com> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> (cherry picked from commit a86eccfb)
-
Juan A. Suárez authored
Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
Juan A. Suárez authored
Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
Juan A. Suárez authored
Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
- Aug 06, 2019
-
-
Tapani Pälli authored
This fixes problems spotted within vk-gl-cts. Problem is that the builtin functions refer to types and we should not release types before builtins are released. Fixes: 624789e3 ("compiler/glsl: handle case where we have multiple users for types") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110796 Signed-off-by:
Tapani Pälli <tapani.palli@intel.com> Acked-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com>
-
- Aug 02, 2019
-
-
Specifically the optimization of a conditional BREAK + WHILE sequence into a conditional WHILE seems pretty broken. The list of successors of "earlier_block" (where the conditional BREAK was found) is emptied and then re-created with the same edges for no apparent reason. On top of that the list of predecessors of the block immediately after the WHILE loop is emptied, but only one of the original edges will be added back, which means that potentially several blocks that still have it on their list of successors won't be on its list of predecessors anymore, causing all sorts of hilarity due to the inconsistency in the control flow graph. The solution is to remove the code that's removing valid edges from the CFG. cfg_t::remove_block() will already clean up after itself. The assert in bblock_t::combine_with() also needs to be removed since we will be merging a block with multiple children into the first one of them. Found the issue on a hardware enabling branch originally, but apparently somebody reproduced the same problem independently on master in the meantime. Fixes: d13bcdb3 ("i965/fs: Extend predicated break pass to predicate WHILE.") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111009 Cc: jiradet.jd@gmail.com Cc: Sergii Romantsov <sergii.romantsov@globallogic.com> Cc: Matt Turner <mattst88@gmail.com> Cc: mesa-stable@lists.freedesktop.org Tested-by:
Paul Chelombitko <qamonstergl@gmail.com> Reviewed-by:
Matt Turner <mattst88@gmail.com> (cherry picked from commit 54fbc625)
-
- Aug 01, 2019
-
-
These were left after a rebase and happen to make NIR_INTRINSIC_SWIZZLE_MASK == NIR_INTRINSIC_SRC_ACCESS, which is how it was noticed. Fixes: 6f20643b ("nir: Allow qualifiers on copy_deref and image instructions") Cc: Connor Abbott <cwabbott0@gmail.com> Signed-off-by:
Eric Engestrom <eric.engestrom@intel.com> Reviewed-by:
Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Reviewed-by:
Eric Anholt <eric@anholt.net> (cherry picked from commit 5d7bcac4)
-
Currently, if we error out before gbm_dri is set (say due to a different name of the backing GBM implementation, or otherwise) the tear down will trigger a NULL ptr deref and crash out. Move the gbm_dri initialization as early as possible. v2: Drop check in dri2_teardowm_drm (Eric) Reported-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Cc: Christian Gmeiner <christian.gmeiner@gmail.com> Cc: mesa-stable@lists.freedesktop.org Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Eric Engestrom <eric.engestrom@intel.com> (cherry picked from commit 72b97ad9)
-
- Jul 31, 2019
-
-
This fixes dEQP-VK.subgroups.quad.compute.subgroupquadswaphorizontal_* on all gen7 platforms. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Matt Turner <mattst88@gmail.com> (cherry picked from commit 8fd2f2c2)
-
The issue here was discovered by a set of Vulkan CTS tests: dEQP-VK.glsl.derivate.*.dynamic_* These tests use ballot ops to construct a branch condition that takes the same path for each 2x2 quad but may not be uniform across the whole subgroup. They then tests that derivatives work and give the correct value even when executed inside such a branch. Because the derivative isn't executed in uniform control-flow and the values coming into the derivative aren't smooth (or worse, linear), they nicely catch bugs that aren't uncovered by simpler derivative tests. Unfortunately, these tests require Vulkan and the equivalent GL test would require the GL_ARB_shader_ballot extension which requires int64. Because the requirements for these tests are so high, it's not easy to test on older hardware and the bug is only proven to exist on gen7; gen4-6 are a conjecture. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Matt Turner <mattst88@gmail.com> (cherry picked from commit 499d760c)
-
Originally introduced in c7f36574 ("darwin: Suppress type conversion warnings for GLhandleARB") to fix Bugzilla #66346 [1], this workaround was never ported to Scons or Meson. [1] https://bugs.freedesktop.org/66346 Cc: mesa-stable@lists.freedesktop.org Signed-off-by:
Eric Engestrom <eric.engestrom@intel.com> Reviewed-by:
Jose Fonseca <jfonseca@vmware.com> (cherry picked from commit bf8b5de6)
-
Set all the handles to VK_NULL_HANDLE: "If the creation of any of those descriptor sets fails, then the implementation must destroy all successfully created descriptor set objects from this command, set all entries of the pDescriptorSets array to VK_NULL_HANDLE and return the error." (Vulkan 1.1.117 Spec, section 13.2) CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit 2b53c49d)
-
We can have a access flag already set here so just augment the existing ones. Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 0fb61dfd ("spirv: propagate access qualifiers through ssa & pointer") Reviewed-by:
Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> (cherry picked from commit 7deb5ec0)
-
When vkGetQueryPoolResults() is called with VK_QUERY_RESULT_WAIT_BIT set, the driver is supposed to wait for the query to become available before returning. Currently, radv returns once the query is indeed ready, but it returns VK_NOT_READY. It also fails to populate the results. The problem is a missing volatile in the secondary check for query availability. This patch removes the secondary check altogether since it is redundant with the preceding loop. This bug was found with an unreleased version of SteamVR. Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit 2b71b4e7)
-
- Jul 30, 2019
-
-
Andrii Simiklit authored
This could help somebody to be noticed about meson issue: https://github.com/mesonbuild/meson/pull/3274 as result NDEBUG won't be defined even if b_ndebug is true and buildtype is release. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109791 Cc: mesa-stable@lists.freedesktop.org Acked-by:
Eric Engestrom <eric.engestrom@intel.com> Signed-off-by:
Andrii Simiklit <andrii.simiklit@globallogic.com>
-
There is a single ir3_compiler in the screen, and each context may be compiling ir3 shaders, which call ir3_create. ralloc doesn't do any locking on its own, so eventually you can end up racing to break ralloc's linked lists. We really don't want struct ir3 to live as long as the compiler (maybe struct ir3_shader's lifetime, if anything), so you'd better be freeing it anyway. Fixes: 8fe20762 ("freedreno/ir3: convert over to ralloc") Reviewed-by:
Rob Clark <robdclark@gmail.com> (cherry picked from commit 6e3b220a)
-
Fixes: b5e04e92 "radv: Support allocating variable size descriptor sets." Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111019 Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit aac49290)
-
Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit 99d04a5b)
-
On Haswell, the format works but it doesn't properly do an sRGB decode. It appears to act identically to R8G8B8_UNORM. Only Vulkan uses this format so this only affects Vulkan on HSW. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Eric Engestrom <eric@engestrom.ch> (cherry picked from commit 7c1b39cf)
-
Seems to fix some hair artifacts in Max Payne 3: https://github.com/daniel-schuermann/mesa/issues/76 Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Fixes: f4e499ec ('radv: add initial non-conformant radv vulkan driver') Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit a9f58af4)
-
Not only variables can be flagged as NonUniformEXT but also expressions. We're currently ignoring it in an expression such as : imageLoad(data[nonuniformEXT(rIndex)], 0) The associated SPIRV : OpDecorate %69 NonUniformEXT ... %69 = OpLoad %61 %68 This changes propagates access qualifiers through ssa & pointers so that when it hits a OpLoad/OpStore style instructions, qualifiers are not forgotten. Fixes failure the following tests : dEQP-VK.descriptor_indexing.* Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 8ed583fe ("spirv: Handle the NonUniformEXT decoration") Reviewed-by:
Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> (cherry picked from commit 0fb61dfd)
-
This refactor allows for common code to apply decoration on all ssa/pointer values. In particular this will allow to propagage access qualifiers. Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Suggested-by:
Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Reviewed-by:
Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> (cherry picked from commit 86b53770) [Lionel Landwerlin: patch adapted for 19.1 branch]
-
In the next commit, we'll properly handle access qualifiers on struct members by propagating them to load/store instructions, but these instructions had no way to specify the qualifier. Reviewed-by:
Timothy Arceri <tarceri@itsqueeze.com> (cherry picked from commit 6f20643b)
-