freedreno/a5xx,a6xx: rename MSAA_ENABLE to LINE_MODE in GRAS_SU_CNTL
This bit seems like the control for line mode of rastrization. That can be simply figured out by comparing dEQP-VK.rasterization.primitives.no_stipple.bresenham_lines, dEQP-VK.rasterization.primitives.no_stipple.rectangular_lines and dEQP-VK.rasterization.primitives.no_stipple.lines. For opengl, the value of bresenham lines mode, which is 0, is set by default and the value of rectangular mode, which is 0x1, is set when multi-sampled. For vulkan, the bresenham lines are enabled when lineRasterizationMode is VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT, which sets the bit to 0, while the value is 1 when it's VK_LINE_RASTERIZATION_MODE_RECTANGULAR_EXT, that seems to be default. If both multi-sampled and bresenham-lines are used when primitive type is line, the bit is to be set as 0 and makes msaa disabled. Note that this is only tested on a6xx, but I guess it's likely the same for a5xx. Signed-off-by:Hyunjun Ko <zzoon@igalia.com> Part-of: <!6020>
Showing
- src/freedreno/.gitlab-ci/reference/crash.log 2 additions, 2 deletionssrc/freedreno/.gitlab-ci/reference/crash.log
- src/freedreno/.gitlab-ci/reference/dEQP-VK.draw.indirect_draw.indexed.indirect_draw_count.triangle_list.log 2 additions, 2 deletions...direct_draw.indexed.indirect_draw_count.triangle_list.log
- src/freedreno/.gitlab-ci/reference/fd-clouds.log 4 additions, 4 deletionssrc/freedreno/.gitlab-ci/reference/fd-clouds.log
- src/freedreno/registers/adreno/a5xx.xml 1 addition, 1 deletionsrc/freedreno/registers/adreno/a5xx.xml
- src/freedreno/registers/adreno/a6xx.xml 1 addition, 1 deletionsrc/freedreno/registers/adreno/a6xx.xml
- src/freedreno/registers/adreno/adreno_common.xml 9 additions, 0 deletionssrc/freedreno/registers/adreno/adreno_common.xml
- src/freedreno/vulkan/tu_pipeline.c 1 addition, 1 deletionsrc/freedreno/vulkan/tu_pipeline.c
- src/gallium/drivers/freedreno/a5xx/fd5_draw.c 2 additions, 1 deletionsrc/gallium/drivers/freedreno/a5xx/fd5_draw.c
- src/gallium/drivers/freedreno/a5xx/fd5_emit.c 2 additions, 1 deletionsrc/gallium/drivers/freedreno/a5xx/fd5_emit.c
- src/gallium/drivers/freedreno/a6xx/fd6_rasterizer.c 1 addition, 1 deletionsrc/gallium/drivers/freedreno/a6xx/fd6_rasterizer.c
Loading
Please register or sign in to comment