Skip to content
Snippets Groups Projects
  1. Jun 07, 2014
  2. Jun 02, 2014
    • Carl Worth's avatar
      cherry-ignore: Ignore two commits. · a73894a7
      Carl Worth authored
      The second of these two is simply a "git revert" of the first. So skipping
      both of them gives us the same final result in a simpler way.
      a73894a7
    • Roland Scheidegger's avatar
      llvmpipe: fix crash when not all attachments are populated in a fb · cf08c247
      Roland Scheidegger authored and Carl Worth's avatar Carl Worth committed
      Framebuffers can have NULL attachments since a while. llvmpipe handled
      that properly for lp_rast_shade_quads_mask but it seems the change didn't
      make it to lp_rast_shade_tile.
      This fixes piglit fbo-drawbuffers-none test (though I need to increase
      the FB_SIZE from 32 to 256 so the tris cover some tiles fully).
      https://bugs.freedesktop.org/show_bug.cgi?id=79421
      
      
      
      Cc: "10.1 10.2" <mesa-stable@lists.freedesktop.org>
      Reviewed-by: default avatarJose Fonseca <jfonseca@vmware.com>
      (cherry picked from commit 57686814)
      cf08c247
    • Pavel E Popov's avatar
      i965: Fix Line Stipple enable bit in 3DSTATE_SF for Haswell. · 4d676c5e
      Pavel E Popov authored and Carl Worth's avatar Carl Worth committed
      
      Cc: "10.1 10.2" <mesa-stable@lists.freedesktop.org>
      Reviewed-by: default avatarMatt Turner <mattst88@gmail.com>
      Signed-off-by: default avatarPavel Popov <pavel.e.popov@intel.com>
      (cherry picked from commit d292d402)
      4d676c5e
    • Brian Paul's avatar
      glsl: fix use-after free bug/crash in ast_declarator_list::hir() · 4942eae8
      Brian Paul authored and Carl Worth's avatar Carl Worth committed
      
      The call to get_variable_being_redeclared() may delete 'var' so we
      can't reference var->name afterward.  We fix that by examining the
      var's name before making that call.
      
      Fixes valgrind warnings and possible crash when running the piglit
      tests/spec/glsl-1.30/execution/clipping/vs-clip-distance-in-param.shader_test
      test (and probably others).
      
      Cc: "10.1 10.2" <mesa-stable@lists.freedesktop.org>
      
      Reviewed-by: default avatarIan Romanick <ian.d.romanick@intel.com>
      (cherry picked from commit f9cecca7)
      4942eae8
    • Emil Velikov's avatar
      glx: do not leak dri3Display · 1776a562
      Emil Velikov authored and Carl Worth's avatar Carl Worth committed
      
      v2: Do not wrap the code in ifdef HAVE_DRI3 (suggested by Keith)
      
      Cc: "10.1 10.2" <mesa-stable@lists.freedesktop.org>
      Cc: Keith Packard <keithp@keithp.com>
      Signed-off-by: default avatarEmil Velikov <emil.l.velikov@gmail.com>
      (cherry picked from commit eb2241f8)
      1776a562
    • Pavel E Popov's avatar
      i965: Properly return *RESET* status in glGetGraphicsResetStatusARB · d2f5638a
      Pavel E Popov authored and Carl Worth's avatar Carl Worth committed
      
      The glGetGraphicsResetStatusARB from ARB_robustness extension always
      returns GUILTY_CONTEXT_RESET_ARB and never returns NO_ERROR for guilty
      context with LOSE_CONTEXT_ON_RESET_ARB strategy.  This is because Mesa
      returns GUILTY_CONTEXT_RESET_ARB if batch_active !=0 whereas kernel
      driver never reset batch_active and this variable always > 0 for guilty
      context.  The same behaviour also can be observed for batch_pending and
      INNOCENT_CONTEXT_RESET_ARB.
      
      But ARB_robustness spec says:
      
        If a reset status other than NO_ERROR is returned and subsequent calls
        return NO_ERROR, the context reset was encountered and completed. If a
        reset status is repeatedly returned, the context may be in the process
        of resetting.
      
        8. How should the application react to a reset context event?
        RESOLVED: For this extension, the application is expected to query the
        reset status until NO_ERROR is returned. If a reset is encountered, at
        least one *RESET* status will be returned. Once NO_ERROR is
        encountered, the application can safely destroy the old context and
        create a new one.
      
      The main problem is the context may be in the process of resetting and
      in this case a reset status should be repeatedly returned.  But looks
      like the kernel driver returns nonzero active/pending only if the
      context reset has already been encountered and completed.  For this
      reason the *RESET* status cannot be repeatedly returned and should be
      returned only once.
      
      The reset_count and brw->reset_count variables can be used to control
      that glGetGraphicsResetStatusARB returns *RESET* status only once for
      each context.  Note the i915 triggers reset_count twice which allows to
      return correct reset count immediately after active/pending have been
      incremented.
      
      v2 (idr): Trivial reformatting of comments.
      
      Signed-off-by: default avatarPavel Popov <pavel.e.popov@intel.com>
      Reviewed-by: default avatarIan Romanick <ian.d.romanick@intel.com>
      Cc: "10.1 10.2" <mesa-stable@lists.freedesktop.org>
      (cherry picked from commit 8dc4a98c)
      d2f5638a
    • James Legg's avatar
      mesa: Fix unbinding GL_DEPTH_STENCIL_ATTACHMENT · ee0207a2
      James Legg authored and Carl Worth's avatar Carl Worth committed
      glFramebufferRender(..., GL_DEPTH_STENCIL_ATTACHMENT, ..., 0) only
      detached the depth buffer and not the stencil buffer.
      
      Bugzilla: http://bugs.freedesktop.org/show_bug.cgi?id=79115
      
      
      Reviewed-by: default avatarBrian Paul <brianp@vmware.com>
      Cc: "10.1 10.2" <mesa-stable@lists.freedesktop.org>
      (cherry picked from commit 846c715a)
      ee0207a2
  3. May 22, 2014
    • Ilia Mirkin's avatar
      nv50/ir: fix constant folding for OP_MUL subop HIGH · 36e0e9c5
      Ilia Mirkin authored and Carl Worth's avatar Carl Worth committed
      
      These instructions can come in either through IMUL_HI/UMUL_HI TGSI
      opcodes, or from OP_DIV constant folding.
      
      Also make sure that the constant foldings which delete the original
      instruction still get counted as having done something.
      
      Signed-off-by: default avatarIlia Mirkin <imirkin@alum.mit.edu>
      Cc: "10.1 10.2" <mesa-stable@lists.freedesktop.org>
      Reviewed-by: default avatarBen Skeggs <bskeggs@redhat.com>
      (cherry picked from commit d2a3de19)
      36e0e9c5
    • Ilia Mirkin's avatar
      nv50/ir: fix s32 x s32 -> high s32 multiply logic · 5d8e60dc
      Ilia Mirkin authored and Carl Worth's avatar Carl Worth committed
      
      Retrieving the high 32 bits of a signed multiply is rather annoying. It
      appears that the simplest way to do this is to compute the absolute
      value of the arguments, and perform a u32 x u32 -> u64 operation. If the
      arguments' signs differ, then negate the result. Since there is no u64
      support in the cvt instruction, we have the perform the 2's complement
      negation "by hand".
      
      This logic can come into use by the IMUL_HI instruction (very unlikely
      to be seen), as well as from constant folding of division by a constant.
      Fixes dolphin's divisions by 255.
      
      Signed-off-by: default avatarIlia Mirkin <imirkin@alum.mit.edu>
      Cc: "10.1 10.2" <mesa-stable@lists.freedesktop.org>
      Reviewed-by: default avatarBen Skeggs <bskeggs@redhat.com>
      (cherry picked from commit d3a5cf05)
      5d8e60dc
  4. May 20, 2014
  5. May 19, 2014
  6. May 17, 2014
  7. May 16, 2014
  8. May 14, 2014
  9. May 09, 2014
  10. May 08, 2014
  11. May 07, 2014
  12. May 05, 2014
Loading