- Feb 08, 2023
-
-
Eric Engestrom authored
-
Eric Engestrom authored
-
There was a VUID-VkImageViewCreateInfo-image-04739 in the Vulkan 1.3 spec that said: If image was created with the VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT flag and format is a non-compressed format, viewType must not be VK_IMAGE_VIEW_TYPE_3D That VUID has since been removed, and when a view of a 3D image is created, with put the depth into the array_len, so it won't be always 1. Reviewed-by: Mark Janes <markjanes@swizzler.org> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!20803> (cherry picked from commit 58ababde)
-
Fixes: d8d99c3c ("aco: add GFX11 opcode numbers") Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!21170> (cherry picked from commit c8adf162)
-
* drawid needs to be incremented at end of loop * rescope draw structs to initialize at top of loop fix #8191 Fixes: 6b07893b ("util/vbuf: handle multidraws") Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Tested-by: Mark Janes <markjanes@swizzler.org> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!21139> (cherry picked from commit 8f5a63eb)
-
Fixes: 86367172 ("zink: add a "compact" descriptor mode") Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!21169> (cherry picked from commit faaf6f95)
-
Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!21169> (cherry picked from commit 77d8cd9c)
-
this was including the generated tcs bits, which was likely to be wrong and thus break optimal key hashing, requiring more pipelines it also wasn't setting the optimal key value correctly during precompile, which meant the wrong hash value was used and the precompiled libs were never actually accessible cc: mesa-stable Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!21169> (cherry picked from commit 4cf54e2e)
-
this may otherwise not be set until the cache has been broken Fixes: 56fb2580 ("zink: replace mixed_zs with zs feedback loops") Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!21169> (cherry picked from commit bbae2372)
-
this needs to be set on context create or it may never get set Fixes: 645f2da3 ("zink: always set VK_PIPELINE_CREATE_COLOR_ATTACHMENT_FEEDBACK_LOOP_BIT_EXT sometimes") Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!21169> (cherry picked from commit 0cb326cc)
-
tcs values here are ignored since they only matter for generated tcs Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!21169> (cherry picked from commit 7c021cc5)
-
Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!21169> (cherry-picked from 1f08a6dc)
-
Point sprite coordinates in general need to be inverted, not just the texcoords converted to point sprite. Move point coord y inversion out to its own pass. Fixes GTF-GL46.gtf21.GL2FixedTests.point_sprites.point_sprites with FBO dEQP surface. cc: mesa-stable Part-of: <mesa/mesa!21050> (cherry picked from commit 782f1e9e)
-
A few lines earlier uni_offsets is accessed with ubo scaled by PIPE_MAX_CONSTANT_BUFFERS: if (uni_offsets[ubo * PIPE_MAX_CONSTANT_BUFFERS + i] == offset) Found by inspection. Looking at the before and after NIR code for dEQP-VK.graphicsfuzz.cov-int-initialize-from-multiple-large-arrays, using the correct indexing appears to enable the pass to inline an additional uniform. My guess is that when a uniform is used more than once, the first loop wouldn't find the offset recored in the table because it was recorded at the wrong location. Fixes: d23a9380 ("lavapipe: implement extreme uniform inlining") Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!21144> (cherry picked from commit a7696a4d)
-
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Georg Lehmann <dadschoorse@gmail.com> Closes: mesa/mesa#8224 Cc: mesa-stable Part-of: <mesa/mesa!21138> (cherry picked from commit fad1f716)
-
this is unsupported and undefined by the spec cc: mesa-stable Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!21099> (cherry picked from commit 7d8e2db9)
-
Currently, we postpone binning syncs until we record draw calls and can validate if any of them require accessing protected resources in the binning stage, however, if the draw calls are recorded in a secondary command buffer and the barriers have been recorded in the primary command buffer, we won't apply the binning sync in the secondary when we record the draw calls and so we must apply it when we execute the secondary in the primary. Fixes flakyness in: dEQP-VK.api.command_buffers.record_many_draws_secondary_2 cc: mesa-stable Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Part-of: <mesa/mesa!21162> (cherry picked from commit fec15a22)
-
The CLE parser in the sim will read this many bytes for each instruction in a CL, so we should ensure we have at least that many bytes available in the BO when reading the last instruction, otherwise we can trigger a GMP violation. It is not clear whether this behavior applies to real hardware too. cc: mesa-stable Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Part-of: <mesa/mesa!21162> (cherry picked from commit c2601f06)
-
Fixes: 46b099e3 ("meson: Ignore unused variables in release builds") 46b099e3 has some issues: - it doesn't enable unused variables warning on release builds with assertions enabled; - it doesn't disable unused variables warning on debug builds with assertions disabled; - it doesn't disable unused variables warning when building with MSVC and assertions are disabled regardless of buildtype, see #8147. 3/4 regressions reported there have this limitation alone as root cause. Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <!21154> (cherry picked from commit 43470724)
-
This was inadvertently removed in 98a6cfd3 and causes continuous memory leaks as events are being received after the context has been unbound. Fixes: 3170b633 ("loader: Add infrastructure for tracking active CRTC resources") Closes: mesa/mesa#8238 Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Part-of: <mesa/mesa!21128> (cherry picked from commit 27a89a09)
-
according to spec, the maximum number of acquired images can be calculated with swapchain_size - VkSurfaceCapabilitiesKHR::minImageCount + 1 the previous calculation was both wrong and occurring in the wrong place, so this corrects both issues cc: mesa-stable Part-of: <mesa/mesa!21095> (cherry picked from commit 89cf0a3b)
-
GL Spec says that imageLoad from incomplete images must return 0. This is not really spec compliant as for proper behavior nullDescriptor and robustImageAccess2 is needed. A workaround for lack of either of these requires a shader variant. Clearing the null surface and hoping the app doesn't write to the image is closer to spec, while avoiding a shader recompile. KHR-GL46.shader_image_load_store.incomplete_textures tests this. cc: mesa-stable Part-of: <mesa/mesa!21135> (cherry picked from commit 22e91af1)
-
simple way to reproduce this is to run these 4 together: KHR-GL46.gpu_shader5.images_array_indexing KHR-GL46.shader_image_load_store.advanced-allMips KHR-GL46.shader_image_load_store.advanced-sso-simple KHR-GL46.shader_image_load_store.incomplete_textures cc: mesa-stable Part-of: <mesa/mesa!21134> (cherry picked from commit 104040b5)
-
fixes upload manager constant buffer leak. zink only needs to save the const buffer for stencil fallback blits. cc: mesa-stable Part-of: <mesa/mesa!21134> (cherry picked from commit 4c647c9e)
-
Found by inspection. Something probably hangs because of this, but I don't know what. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Tatsuyuki Ishi <ishitatsuyuki@gmail.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Fixes: c199a516 ("radv: bind the VS input state for prologs created with GPL") Part-of: <mesa/mesa!20913> (cherry picked from commit 10a5035c)
-
Fixes: afd645f0 ("ac/llvm: remove LLVMBuildGEP usages") Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!20521> (cherry picked from commit 10ac51a5)
-
Vulkan spec 18.8. Primitives Generated Queries: When a generated primitive query for a vertex stream is active, the primitives-generated count is incremented every time a primitive emitted to that stream reaches the transform feedback stage, whether or not transform feedback is active. We can see the order of stages in chapter 27 Fixed-Function Vertex Post-Processing, which shows that the transform feedback stage is before rasterization (and therefore culling). Conclusion is that culled primitives should be included in the primitives generated query. This commit makes sure to emit the primitives generated query code before culling and uses the input primitive count passed to the current wave instead of the exec mask after culling. Cc: mesa-stable Signed-off-by: Timur Kristóf <timur.kristof@gmail.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Qiang Yu <yuq825@gmail.com> Part-of: <mesa/mesa!21037> (cherry picked from commit 3a819bd2)
-
arb_sparse_texture2 also enables multisampled sparse textures. bring back the check for msaa support. fixes #8229 Fixes: 4f8ba2b9 ("zink: fix sparse residency query and minLOD feature checks") Part-of: <mesa/mesa!21121> (cherry picked from commit 8f928a95)
-
cc: mesa-stable Part-of: <mesa/mesa!21013> (cherry picked from commit 4f8ba2b9)
-
We first do an incomplete check for whether the linker supports --gc-sections, then potentially add C and C++ arguments assuming that it works, then later do a complete check to see if it actually works and use --gc-sections. This means we can end up putting functions and data in separate sections when we can't gc them. Combine the checks, do less work, and be more accurate. fixes: f51ce21e ("meson: Drop adding -Wl,--gc-sections to project c/cpp arguments.") Reviewed-by: Eric Engestrom <eric@igalia.com> Part-of: <mesa/mesa!21083> (cherry picked from commit fd9b50aa)
-
Fixes: f7545291 ("ac/nir/ngg: support clipdist culling") Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Signed-off-by: Qiang Yu <yuq825@gmail.com> Part-of: <mesa/mesa!20691> (cherry picked from commit d798214c)
-
Even when small primitive culling is disabled, the face culling algorithm in ac_nir_cull can delete tiny triangles when their area is almost zero. Cc: mesa-stable Signed-off-by: Timur Kristóf <timur.kristof@gmail.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!20987> (cherry picked from commit 3508597a)
-
Closes: #8216 Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Part-of: <mesa/mesa!21066> (cherry picked from commit 9b3b7e50)
-
It used an invalid offset, which hung. Fixes: f24f8665 - ac: implement register shadowing for gfx11 Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!21041> (cherry picked from commit 76472c85)
-
This reverts the radv_adjust_tile_swizzle change to unify the code. Fixes: 529eb739 - radeonsi/gfx11: add CB deltas Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!21041> (cherry picked from commit 47f598a1)
-
Fixes: caa09f66 - amd: add chip identification for gfx1100-1103 Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!21041> (cherry picked from commit 84d59cdb)
-
Same as PAL. Fixes: 529eb739 - radeonsi/gfx11: add CB deltas Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!21041> (cherry picked from commit 66d11391)
-
The epsilon for 8bpc is for the linear colorspace. There is no epsilon for sRGB. Fixes: 17021efc - radeonsi: adjust RB+ blend optimization settings Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!21041> (cherry picked from commit 8556b3db)
-
etna_resource_from_handle() is called for each plane of a multiplanar resource, so there is no point in looping over all planes to do the renderonly scanout import. In fact that will cause us to lose track of the scanout imports from later planes when the earlier planes are redoing the import, overwriting the pointer to the allocated renderonly_scanout struct. Drop the loop and just do the import for the current plane. Fixes: 826f9577 ("etnaviv: always try to create KMS side handles for imported resources") Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> Part-of: <mesa/mesa!20993> (cherry picked from commit 175732bb)
-
This reverts commit d6fabe49. It has issues that are not worth fixing in this release branch in my opinion. Part-of: <mesa/mesa!21087>
-