Skip to content
Snippets Groups Projects
Commit 49af89a0 authored by Paulo Zanoni's avatar Paulo Zanoni Committed by Dylan Baker
Browse files

intel/compiler: remove the operand restriction for src1 on GLK


Commit 5847de6e implemented a restriction that applies to ICL, but
wrongly marked it as also applying to GLK. Reviewers or MR !1125
pointed this, and the commit history shows removal of GLK to parts of
the patch, but it turns there was still a left-over GLK check in the
code.

This code was breaking some of the i8vec2 tests on GLK, for example:
  dEQP-VK.subgroups.arithmetic.compute.subgroupadd_i8vec2

Removing the GLK check solves the issue for GLK. I don't see a reason
on why implementing this restriction would actually break GLK, so
there's still more to investigate here since this bug may be affecting
ICL+, but let's apply the real GLK fix while we analyze and discuss
the other possible issues.

Fixes: 5847de6e ("intel/compiler: don't use byte operands for src1
on ICL")
BSpec: 3017
Reviewed-by: default avatarLionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: default avatarMatt Turner <mattst88@gmail.com>
Signed-off-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
(cherry picked from commit b57383a9)
parent dd4b73ad
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment