Skip to content

libcangjie: fix unsignedPositive on patch check

Koala Yeung requested to merge fix/version-check into main

  • LIBCANGJIE_VERSION_PATCH is defined as constant in compile time

  • when LIBCANGJIE_VERSION_PATCH is defined as 0, the cppcheck tells that the patch (unsigned int32) >= LIBCANGJIE_VERSION_PATCH (0) is not necessary. also test to have LIBCANGJIE_VERSION_PATCH - 1 will fail.

  • changing the function parameter types to signed int32 solves the issue with minimal effort.

Edited by Koala Yeung

Merge request reports