Skip to content
Snippets Groups Projects
  1. May 14, 2019
  2. May 13, 2019
  3. May 10, 2019
    • Leo Liu's avatar
      winsys/amdgpu: add VCN JPEG to no user fence group · 349153f0
      Leo Liu authored and Juan A. Suárez's avatar Juan A. Suárez committed
      
      There is no user fence for JPEG, the bug triggering
      kernel WARN_ON(flags & AMDGPU_FENCE_FLAG_64BIT)
      
      Signed-off-by: default avatarLeo Liu <leo.liu@amd.com>
      Acked-by: default avatarChristian König <christian.koenig@amd.com>
      Reviewed-by: default avatarBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
      Cc: mesa-stable@lists.freedesktop.org
      (cherry picked from commit ceba9ff2)
      349153f0
    • Tomeu Vizoso's avatar
      panfrost: Only take the fast paths on buffers aligned to block size · f8ec40e2
      Tomeu Vizoso authored and Juan A. Suárez's avatar Juan A. Suárez committed
      
      As the functions operate on 16-byte blocks.
      
      Fixes this Valgrind error:
      
      Invalid read of size 4
         at 0x5857568: swizzle_bpp1_align16 (pan_swizzle.c:85)
         by 0x585780F: panfrost_texture_swizzle (pan_swizzle.c:171)
         by 0x584F587: panfrost_tile_texture (pan_resource.c:489)
         by 0x584F641: panfrost_transfer_unmap (pan_resource.c:525)
         by 0x587718D: u_transfer_helper_transfer_unmap (u_transfer_helper.c:516)
         by 0x5875D85: pipe_transfer_unmap (u_inlines.h:515)
         by 0x5875F13: u_default_texture_subdata (u_transfer.c:80)
         by 0x53FFDC3: st_TexSubImage (st_cb_texture.c:1480)
         by 0x54005BB: st_TexImage (st_cb_texture.c:1709)
         by 0x5391353: teximage (teximage.c:3105)
         by 0x5391353: teximage_err (teximage.c:3132)
         by 0x5391B9B: _mesa_TexImage2D (teximage.c:3170)
         by 0x5097A77: shared_dispatch_stub_183 (glapi_mapi_tmp.h:18833)
       Address 0x1e94f1e8 is 0 bytes after a block of size 16 alloc'd
         at 0x483F5C8: malloc (vg_replace_malloc.c:299)
         by 0x584F47D: panfrost_transfer_map (pan_resource.c:467)
         by 0x587694D: u_transfer_helper_transfer_map (u_transfer_helper.c:243)
         by 0x5875EA7: u_default_texture_subdata (u_transfer.c:59)
         by 0x53FFDC3: st_TexSubImage (st_cb_texture.c:1480)
         by 0x54005BB: st_TexImage (st_cb_texture.c:1709)
         by 0x5391353: teximage (teximage.c:3105)
         by 0x5391353: teximage_err (teximage.c:3132)
         by 0x5391B9B: _mesa_TexImage2D (teximage.c:3170)
         by 0x5097A77: shared_dispatch_stub_183 (glapi_mapi_tmp.h:18833)
         by 0x4DA8AB: glu::CallLogWrapper::glTexImage2D(unsigned int, int, int, int, int, int, unsigned int, unsigned int, void const*) (in /home/tomeu/deqp-build/modules/gles2/deqp-gles2)
      
      Signed-off-by: default avatarTomeu Vizoso <tomeu.vizoso@collabora.com>
      Reviewed-by: default avatarEmil Velikov <emil.velikov@collabora.com>
      Cc: 19.1 <mesa-stable@lists.freedesktop.org>
      (cherry picked from commit c3538ab5)
      f8ec40e2
    • Tomeu Vizoso's avatar
      panfrost: Fix two uninitialized accesses in compiler · 5e758033
      Tomeu Vizoso authored and Juan A. Suárez's avatar Juan A. Suárez committed
      
      Valgrind was complaining of those.
      
      NIR_PASS only sets progress to TRUE if there was progress.
      
      nir_const_load_to_arr() only sets as many constants as components has
      the instruction.
      
      This was causing some dEQP tests to flip-flop, such as:
      
      dEQP-GLES2.functional.fragment_ops.blend.equation_src_func_dst_func.add_src_color_constant_color
      
      Signed-off-by: default avatarTomeu Vizoso <tomeu.vizoso@collabora.com>
      Reviewed-by: default avatarAlyssa Rosenzweig <alyssa@rosenzweig.io>
      Fixes: 14531d67 ("nir: make nir_const_value scalar")
      (cherry picked from commit 554975ba)
      5e758033
    • Rob Clark's avatar
      freedreno/ir3: fix rasterflat/glxgears · f1ab2220
      Rob Clark authored and Juan A. Suárez's avatar Juan A. Suárez committed
      
      Ofc legacy gl features that are broken don't trigger fails in deqp.  I
      should remember to test glxgears more often.
      
      Fixes: 7ff6705b freedreno/ir3: convert to "new style" frag inputs
      Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
      (cherry picked from commit 9faf218b)
      f1ab2220
    • Lionel Landwerlin's avatar
      anv: Use corresponding type from the vector allocation · e0c082d6
      Lionel Landwerlin authored and Juan A. Suárez's avatar Juan A. Suárez committed
      
      We didn't notice this issue much because the 2 struct share a similar
      layout, expect for the additional fields...
      
      We run into that issue in Anv :
      
      ==15236== Invalid write of size 8
      ==15236==    at 0x8CF3939C: anv_state_table_expand_range (anv_allocator.c:211)
      ==15236==    by 0x8CF394D5: anv_state_table_grow (anv_allocator.c:264)
      ==15236==    by 0x8CF3967E: anv_state_table_add (anv_allocator.c:312)
      ==15236==    by 0x8CF3B13C: anv_state_pool_alloc_no_vg (anv_allocator.c:1167)
      ==15236==    by 0x8CF3B2B0: anv_state_pool_alloc (anv_allocator.c:1190)
      ==15236==    by 0x8CF60871: alloc_surface_state (anv_image.c:1122)
      ==15236==    by 0x8CF61FF9: anv_CreateImageView (anv_image.c:1519)
      ==15236==    by 0x8BCBD2ED: vkCreateImageView (trampoline.c:1358)
      ==15236==  Address 0x8994ef10 is 0 bytes after a block of size 128 alloc'd
      ==15236==    at 0x4C2FB0F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
      ==15236==    by 0x8D2578E6: u_vector_init (u_vector.c:47)
      ==15236==    by 0x8CF3929A: anv_state_table_init (anv_allocator.c:168)
      ==15236==    by 0x8CF3A99A: anv_state_pool_init (anv_allocator.c:921)
      ==15236==    by 0x8CF56517: anv_CreateDevice (anv_device.c:1909)
      ==15236==    by 0x8BCB4FBA: terminator_CreateDevice (loader.c:6073)
      ==15236==    by 0x8DD2CB3D: ??? (in /home/djdeath/.steam/ubuntu12_64/libVkLayer_steam_fossilize.so)
      ==15236==    by 0x8DF4D241: vkCreateDevice (in /home/djdeath/.steam/ubuntu12_64/steamoverlayvulkanlayer.so)
      ==15236==    by 0x8BCB35C6: loader_create_device_chain (loader.c:5449)
      ==15236==    by 0x8BCBC230: vkCreateDevice (trampoline.c:838)
      
      v2: Rename mmap_cleanups to avoid confusion (Caio)
      
      v3: s/fail_mmap_cleanups/fail_cleanups/ (Caio)
      
      Signed-off-by: default avatarLionel Landwerlin <lionel.g.landwerlin@intel.com>
      Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110648
      
      
      Cc: <mesa-stable@lists.freedesktop.org>
      Reviewed-by: default avatarCaio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
      (cherry picked from commit f2f6ac1c)
      e0c082d6
  4. May 09, 2019
  5. May 08, 2019
  6. May 07, 2019
  7. May 06, 2019
  8. May 04, 2019
Loading