Skip to content

Meson/Visual Studio builds: Include toolset version by default (master branch)

Chun-wei Fan requested to merge fanc999/cairomm:meson-msvc-toolset into master

Hi,

From the commit message:

This makes the built DLL and .lib's contain the toolset version if the build is carried out using Visual Studio 2017 or later, unless the msvc14x-parallel-installable option is set to be false during configuration.

The reasoning behind this change is that there may be subtle problems when, for instance, one tries to link to a Visual Studio 2017-built cairomm with Visual Studio 2019. This is unfortunate as Microsoft did try hard to make interoperating between binaries built with Visual Studio 2017 and 2019 as easy as possible in terms of ABI and API, but unfortunately this may hit the corner cases where this compatibility does not work.

As the name suggests, this attempts to make Visual Studio 2017 and 2019 builds share a single set of underlying C DLLs easier, while avoiding possible breakages caused by such subtle differences.

I will open an MR shortly for the cairomm-1-14 branch; I think it is best if I update pangomm in a similar fashion after the MRs here go through.

With blessings, thank you!

Merge request reports