- Jan 19, 2025
-
-
Caio Oliveira authored
Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!33110>
-
OVR_multiview requires 1.30 but makes use of layout qualifier Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Acked-by:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!33074>
-
- Jan 18, 2025
-
-
Make it a member function for convenience -- since another member function uses it. Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!33108>
-
Add brw prefix when necessary. Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!33108>
-
Found on simulation, complaining about SIMD32 shaders enabled when using MSAA 16x. Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Reviewed-by:
Nanley Chery <nanley.g.chery@intel.com> Part-of: <mesa/mesa!30753>
-
Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!33076>
-
Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!33076>
-
Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!33076>
-
Caio Oliveira authored
Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!33100>
-
Reviewed-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <mesa/mesa!32644>
-
Reviewed-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <mesa/mesa!32644>
-
The test runner can automatically update reference shaders when the result changes. Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> Reviewed-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <mesa/mesa!32644>
-
Acked-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <mesa/mesa!32644>
-
This allows unit tests to compare against a reference nir shader instead of implementing checks for interesting instructions/CF nodes. Reviewed-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <mesa/mesa!32644>
-
Sets some fields so they are not printed and allows specifying a stage. This decreases the size of reference shaders. Reviewed-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <mesa/mesa!32644>
-
Reviewed-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <mesa/mesa!32644>
-
These virtual opcodes will write the whole flag set, either directly (via brw_fill_flag()) or indirectly by using LOAD_LIVE_CHANNELS. Issue was found when analysing a hang that would disappear if the lowering of those opcodes was pulled all the way up right before brw_opt_cmod_propagation (which uses the flags_written). Fixes: 019770f0 ("intel/brw: Add SHADER_OPCODE_VOTE_*") Fixes: 2bd7592b ("intel/brw: Add SHADER_OPCODE_BALLOT") Closes: mesa/mesa#12347 Closes: mesa/mesa#12479 Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!33085>
-
- Jan 17, 2025
-
-
Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <!33064>
-
this avoids validation errors from 3d<->2d blits Part-of: <mesa/mesa!33102>
-
Part-of: <mesa/mesa!33098>
-
Part-of: <mesa/mesa!33098>
-
better than silently failing Part-of: <mesa/mesa!33098>
-
Part-of: <mesa/mesa!33098>
-
Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <!33090>
-
This is handled by the back compiler. Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <mesa/mesa!33067>
-
Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <mesa/mesa!33067>
-
Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <mesa/mesa!33067>
-
Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <mesa/mesa!33067>
-
Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <mesa/mesa!33067>
-
flag day change to use the new infra. as-is this is a bit pointless, but it unblocks the new bindgen work. Signed-off-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Reviewed-by:
Jesse Natalie <jenatali@microsoft.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <!33067>
-
no longer used, replaced by the new pass. Signed-off-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Reviewed-by:
Jesse Natalie <jenatali@microsoft.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!33067>
-
this will be needed with vtn_bindgen2 Signed-off-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Reviewed-by:
Jesse Natalie <jenatali@microsoft.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <!33067>
-
this is a helper for lowering the printf buffer intrinsics to constants for backend convenience. Signed-off-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Reviewed-by:
Jesse Natalie <jenatali@microsoft.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!33067>
-
this is required for vtn_bindgen2 where we don't know the buffer size until the driver-specific code paths, but we need to lower printf (to hash format strings) in common code. so defer the buffer size decision to an intrinsic. Signed-off-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Reviewed-by:
Jesse Natalie <jenatali@microsoft.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!33067>
-
Signed-off-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Reviewed-by:
Jesse Natalie <jenatali@microsoft.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!33067>
-
Signed-off-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Reviewed-by:
Jesse Natalie <jenatali@microsoft.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <!33067>
-
Currently, nir_lower_printf depends on a per-nir_shader table, writing out indices into the printf buffer. This works for real OpenCL implementations (rusticl, microsoft) which can associate the printf buffer with a particular kernel, I guess. (Actually it's not clear to me that it works well there either but that's not my problem.) This mechanism is unsuitable for internal driver shaders, where printfs with unique format strings can come from many different nir_shaders. There are two current solutions in tree to this for driver CL: * Honeykrisp: Only use one single nir_shader (libagx). This prevents us from using printf in common CL and requires extra driver tracking. It won't work with my upcoming vtn_bindgen rework, which is why I'm addressing this now. * Anv: Offset format-string indices by a dynamic "base identifier" using relocs or a push constant, then pool format strings into a table from nir_shader's across the device. The problem here is that these indices now depend on the order that nir_shaders are seen (which causes a mess for caching if relocs are used, or requires extra push constants and extra bookkeping if relocs aren't used). And the driver tracking required to do this pooling correctly is even more complicated than what Honeykrisp does. I do not want every driver in-tree needing to go down this path, and it wouldn't work with my upcoming vtn_bindgen. This MR introduces an alternate approach: rather than writing indices into the table, we instead hash the format string itself and write the hash. That doesn't depend on what nir_shader we came from, so we can freely mix & match and get consistent hashes. That greatly alleviates driver tracking burden. To make that possible, we need a global hash table mapping hashed format identifiers to the format strings themselves. That approach still requires a step to "register" format strings into the table. That step would not be required if we wrote the actual strings themselves into the table, but that was ruled out for performance/code size reasons. However, we do not want drivers to need to explicitly register all the strings they use, because once we have OpenCL in common code via vtn_bindgen2, drivers won't know all the strings they use. Fortunately, there's a neat solution for that too. By making this global table a singleton (with internal locking), vtn_bindgen2 can automatically register format strings via a static constructor. In conjunction with the infrastructure added here, that eliminates all driver bookkeeping required for format-strings. The code itself is inspired by the glsl type singleton. Is it pretty? Not really, but it gets the job done well. Signed-off-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Reviewed-by:
Jesse Natalie <jenatali@microsoft.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!33067>
-
for hash-based printf. this just shells out to XXH - convenience wrapper. Signed-off-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Reviewed-by:
Jesse Natalie <jenatali@microsoft.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!33067>
-
there's nothing NIR specific here and these routines will be useful otherwise. Signed-off-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Reviewed-by:
Jesse Natalie <jenatali@microsoft.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!33067>
-
no uses and it doesn't make sense. Signed-off-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Reviewed-by:
Jesse Natalie <jenatali@microsoft.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!33067>
-