It prevent the GError from happening

We attempted to not pass through some packets that looked like
valid STUN but were ot acceptable to us, but that dropped some application
packets.

If the stream was ever gathering and a new relay has been set,
then re-emit the candidate=gathering-done signal

There is no reason to only allow modifying it in the new().

The newer RFC 6298 recommends 1 second instead of 3.

This is how it is specified in RFC 5245 section 16

Also don't try to re-add pairs that already have been added

The rest of the list is sorted, but this was just appended, making it likely
to be dropped if the list grows too long.

priv_limit_conn_check_list_size() would remove elemtns from the conncheck_list
while the calling functions were iterating it. Now instead just mark them as
cancelled. Then later, at the outer function, free all cancelled elements to
prevent the list from growing out of bounds.

Clean up the UPnP mappings of each stream when closing it

This would cause mappings to be dropped on every new gather, which is bad!
Instead, keep the same one with the mappings, and just drop the timer to ignore
new discovered mappings afterwards.

This is to ensure that the result of the new negotiation will always
have priority.

Philip Withnall authored 10 years ago and Olivier Crête committed 10 years ago

To try and avoid NULL NiceCandidates entering our internal state.

Don't change the state if no pair is selected. Otherwise we get
a component that claims to be CONNECTED but has no selected pair.
Also, set the selected pair before announcing the state change.

It doesn't make sense to tell applications to include <agent.h>,
including <nice/agent.h> is much safer. So tell the applications
to use the includedir directly.

GIOStream and nice_agent_remove_stream() interact slightly subtly when
closing down the stream.

See: https://bugzilla.gnome.org/show_bug.cgi?id=735754

This makes helgrind slightly happier.

This could result in leaking the stream’s un-closed state otherwise, in
any case where a NiceAgent is finalised without
nice_agent_remove_stream() being called on all its streams.

To be used with `make check-valgrind`.

The theory being that if we can get check-valgrind to pass, we could
acutally use it to find more memory leaks and other errors in the agent.

This should fix a crash, as detected by Valgrind:
  ==28354== Invalid read of size 2
  ==28354==    at 0x4C2B5B0: memcpy@@GLIBC_2.14 (in
    /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
  ==28354==    by 0x50C17E2: stun_message_id (stunmessage.c:658)
  ==28354==    by 0x509E4E7: candidate_check_pair_fail (conncheck.c:254)
  ==28354==    by 0x50A4EDB: conn_check_prune_socket (conncheck.c:3145)
  ==28354==    by 0x509B6F8: component_io_cb (agent.c:3951)

The GSource holds a reference to the GCancellable, so needs to be
explicitly removed from the GMainContext when it’s finised with.

There is no need for this to be heap-allocated.

Stack variables can be initialised to zero by explicit assignment.

This introduces no functional changes.

This introduces no functional changes.