- Mar 29, 2024
-
-
Boris Brezillon authored
We regressed a pipeline.monolithic test when switching to dynamic rendering and this went unnoticed because dEQP-VK.pipeline.monolithic.* is not run. With this addition, execution time is too long to fit in a single job, so we split VK tests in 3, which I think is acceptable if we keep the tests manual. Signed-off-by:Boris Brezillon <boris.brezillon@collabora.com>
-
Boris Brezillon authored
Make sure we crash when resolveMode != VK_RESOLVE_MODE_NONE in the vkCmdBeginRendering() path instead of silently ignoring resolve arguments. Signed-off-by: -
Boris Brezillon authored
This field should match the one defined in the framebuffer descriptor. Signed-off-by: -
Boris Brezillon authored
Signed-off-by: -
Boris Brezillon authored
The 'Single-sampled lines' field actually defines the line rasterization mode with the following behavior: - perpendicular: line ends are perpendicular to the line themselves and lines are rasterized as a rectangle - (screen) aligned: line ends are aligned on the X or Y axis Before fixing the Vulkan implementation, let's use the canonical name in the xml files to make it less confusing. Signed-off-by: -
Boris Brezillon authored
Vulkan wants an R001 pattern, where the depth/stencil is stored in the red component, but the pan_format/texture logic gives us RRRR. Tweak the swizzle so we get what Vulkan wants. Signed-off-by: -
Boris Brezillon authored
Those are just regular 2D[MS] textures. Signed-off-by: -
Boris Brezillon authored
Lower input attachments to texture operations as it was meant to be according to the set layout accounting, and fix the descriptor set logic to fill texture descriptors instead of image descriptors. Signed-off-by: -
Boris Brezillon authored
When the subpass being associated to a graphics pipeline has no color attachment, pColorBlendState can be NULL. Signed-off-by: -
Boris Brezillon authored
Fragment color outputs can be defined as a vec4 array. As long as the indexing is not dynamic, we can add the constant offset passed to the store_output() intrinsic to the RT index we extracted from the location. Signed-off-by: -
Boris Brezillon authored
colorAttachmentCount should be less that or equal the number of RT slots, not strictly less than. Fixes: 595d362d ("panvk: Implement dynamic rendering entry points") Signed-off-by:
-
Boris Brezillon authored
VkRenderingInfo without any attachment is a perfectly valid use case. Make sure we don't end up asserting on fbinfo width/height being zero in that case. Fixes: 595d362d panvk: Implement dynamic rendering entry points Signed-off-by:
-
- Mar 27, 2024
-
-
Creating mutable or shared references to mutable static variables is discouraged, but still possible by taking a detour to a raw pointer via the addr_of! / addr_of_mut! macros. For details, see: https://github.com/rust-lang/rust/issues/114447 Closes: #10887 Cc: mesa-stable Reviewed-by:
Karol Herbst <kherbst@redhat.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> Part-of: <!28415>
-
zink_program_get_descriptor_usage is not used anywhere. Signed-off-by:
Corentin Noël <corentin.noel@collabora.com> Part-of: <mesa/mesa!28412>
-
Part-of: <mesa/mesa!28420>
-
cat src/etnaviv/ci/etnaviv-gc2000-flakes.txt | sed 's/[ \t]*$//' | sort | uniq -d spec@arb_depth_texture@depth-level-clamp spec@arb_depth_texture@fbo-depth-gl_depth_component24-blit spec@arb_pixel_buffer_object@texsubimage-depth-formats pbo spec@arb_texture_storage@texture-storage spec@arb_texture_storage@texture-storage@2D mipmap rendering spec@ext_packed_depth_stencil@fbo-depth-gl_depth24_stencil8-copypixels spec@nv_copy_image@nv_copy_image-simple --tex-to-tex spec@!opengl 1.1@depthstencil-default_fb-copypixels Signed-off-by:
Christian Gmeiner <cgmeiner@igalia.com> Reviewed-by:
David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!28416>
-
David Heidelberg authoredFixes: 54050d88 ("svga/ci: land vmware mesa-ci lava farm") Signed-off-by:
-
This workaround is termporary and will be dropped once the farm is moved to its permament location. Signed-off-by:
Martin Krastev <martin.krastev@broadcom.com> Reviewed-by:
Guilherme Gallo <guilherme.gallo@collabora.com> Part-of: <!28261>
-
* add vmware farm, jobs and local rules * add qemu lava deploy and boot actions * add vmware-qemu traces job for llvmpipe device, as manual * add vmware-vmx piglit job for svga device, as automatic * add llvmpipe device piglit skip/fail lists * add svga to GALLIUM_DRIVERS in debian-testing job * add svga device fails/skips/flakes lists * switch KERNEL_REPO/FORCE_KERNEL_TAG to own fork Signed-off-by:
-
This commit will also add a helper function to simplify the code Signed-off-by:
Vlad Schiller <vlad-radu.schiller@imgtec.com> Reviewed-by:
Frank Binns <frank.binns@imgtec.com> Part-of: <!28361>
-
Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> Reviewed-by:
Mary Guillemard <mary.guillemard@collabora.com> Reviewed-by:
Rebecca Mckeever <rebecca.mckeever@collabora.com> Part-of: <!28170>
-
Signed-off-by:
-
It's already per-gen, but DestroyPipeline() was defined globally. Let's move this function to panvk_vX_pipeline.c so we can get rid of panvk_pipeline.c. Signed-off-by:
-
Forbid inclusion of panvk_descriptor_set_layout.h from non per-gen compilation units. Signed-off-by:
-
Merge panvk_descriptor_set.c and panvk_vX_descriptor_set.c. Signed-off-by:
-
Move panvk_shader_destroy() to panvk_vX_shader.c so we can get rid of panvk_shader.c. Signed-off-by:
-
The command buffer state is going to be an object containing per-gen descriptors. Instead of pretending we can have gen-agnostic helpers, let's merge everything in panvk_vX_cmd_buffer.c, and make panvk_cmd_buffer.h a per-gen file. We will split this into sub-files (panvk_cmd_draw, panvk_cmd_desc, ...) further down the road, so we can specialize only specific bits (like descriptor tables, the way we issue draw/dispatch jobs, etc). Signed-off-by:
-
Signed-off-by:
-
This way we can use mali_xxx_packed structs for the descriptor templates. Signed-off-by:
-
Use auto-generated mali_xx_packed structs for the descriptors and make sure panvk_buffer_view.h is never included from a non per-gen context. Signed-off-by:
-
Explicitly include the headers we need in the various .{c,h} files and remove panvk_private.h. Signed-off-by: -
Signed-off-by:
-
Signed-off-by:
-
While at it, merge panvk_vX_cmd_buffer.h into panvk_cmd_buffer.h. Signed-off-by:
-
Signed-off-by:
-
While at it, merge panvk_vX_meta.h into panvk_meta.h and stop including panvk_meta_vX.h from panvk_private.h. Signed-off-by:
-
Signed-off-by:
-
Signed-off-by:
-
This way we just have one place where we need to dispatch calls. Signed-off-by:
-
So we can dispatch calls to per-arch functions that return a value. Signed-off-by:
-
