- May 03, 2023
-
-
Eric Engestrom authored
-
With merged shaders we might not have an explicit TES. Fixes: 879ddf97 ("radv: rework binding shaders to cmdbuf by introducing new helpers") Closes: mesa/mesa#8939 Part-of: <mesa/mesa!22784> (cherry picked from commit df08ed7d)
-
Eric Engestrom authored
-
Indeed, these references are not freed. For instance, this issue is triggered on an evergreen card with "piglit/bin/shader_runner tests/spec/arb_shader_atomic_counter_ops/execution/all_touch_test.shader_test -auto -fbo" while setting GALLIUM_REFCNT_LOG=refcnt.log. Fixes: 06993e4e ("r600: add support for hw atomic counters. (v3)") Signed-off-by: Patrick Lerda <patrick9876@free.fr> Reviewed-by: Gert Wollny <gert.wollny@collabora.com> Part-of: <mesa/mesa!22798> (cherry picked from commit 4ca8be82)
-
Otherwise a load of the cache won't load any of the objects in it! Fixes: 591da987 ("vulkan: Add a common VkPipelineCache implementation") Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!22700> (cherry picked from commit c93b179d)
-
On malloc failure, or more likely a passed in pDataSize < pipeline cache data size, we should return incomplete. Otherwise, vk_pipeline_cache_object_serialize will assertion fail about the start not being aligned. Closes: #8868 Fixes: 591da987 ("vulkan: Add a common VkPipelineCache implementation") Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!22700> (cherry picked from commit bc257928)
-
Previously this was only in the graphics path... where it does nothing, since D3D only supports wave size control for compute. Whoops. Fixes: db083070 ("dzn: Implement subgroup size control extension") Part-of: <mesa/mesa!22810> (cherry picked from commit cc8cdbb0)
-
Indeed, the objects are not freed when the function returns NULL. "psurf->texture = tex;" is redundant with "pipe_resource_reference(&psurf->texture, tex);". For instance, this issue is triggered with "piglit/bin/ext_texture_array-compressed teximage pbo -fbo -auto" while setting GALLIUM_REFCNT_LOG=refcnt.log. Fixes: f3630548 ("crocus: initial gallium driver for Intel gfx 4-7") Signed-off-by: Patrick Lerda <patrick9876@free.fr> Part-of: <mesa/mesa!22799> (cherry picked from commit d615dfca)
-
this could otherwise unbind a non-generated tcs if the tes had at some point generated a tcs cc: mesa-stable Part-of: <mesa/mesa!22801> (cherry picked from commit 27d6a986)
-
We track fences in a global list and have a per context "current" fence which we randomly attach things to. If we take such a fence and emit it without also creating a new fence for future tasks we can get out of sync leading to random failures. Some of our queries could trigger such cases and even though this issues appears to be triggered by the MT rework, I'm convinced that this was only made more visible by those fixes and we had this bug lurking for quite a while. Closes: mesa/mesa#7429 Fixes: df0a4d02 ("nvc0: make state handling race free") Signed-off-by: Karol Herbst <git@karolherbst.de> Acked-by: M Henning <drawoc@darkrefraction.com> Part-of: <mesa/mesa!22722> (cherry picked from commit 37c6c5c6)
-
This fixes an alignment mismatch in radv_shader_serialize() Fixes: 577d76f6 ('radv: add radv_shader_serialize() and radv_shader_deserialize() functions') Part-of: <mesa/mesa!22735> (cherry picked from commit 7fc259e4)
-
It might happen that a raw data object (from pipeline cache creation) was never looked up, and thus never deserialized, before it gets inserted again into the cache. In this case, the deserialized object got replaced by the raw data object. Instead, replace the raw data object with the real object in the cache. Fixes: 8b13ee75 ('vulkan: Fall back to raw data objects when deserializing if ops == NULL') Part-of: <mesa/mesa!22735> (cherry picked from commit cbab396f)
-
We need to do full pow if 64-bit, and we can do fpow() otherwise. Not the other way around. Fixes: 9076c4e2 ("nir: update opcode definitions for different bit sizes") Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com> Part-of: <mesa/mesa!22774> (cherry picked from commit 955797d0)
-
The Vulkan spec says: "If the depth clamping state is changed dynamically, and the pipeline was not created with VK_DYNAMIC_STATE_DEPTH_CLIP_ENABLE_EXT enabled, then depth clipping is enabled when depth clamping is disabled and vice versa" Fixes: e48c0fbd ("radv: add support for dynamic depth clamp enable") Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!22777> (cherry picked from commit e25e4c81)
-
The flag was ignored for VK_QUERY_TYPE_TRANSFORM_FEEDBACK_STREAM_EXT and VK_QUERY_TYPE_PRIMITIVES_GENERATED_EXT. Cc: mesa-stable Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!22781> (cherry picked from commit 34cc3791)
-
This fixes a few tests out of the nin-tests test suite. Fixes: 79ca456b ("r600/sfn: rewrite NIR backend") Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Part-of: <mesa/mesa!22778> (cherry picked from commit f092f548)
-
1D texture miplevels are aligned to 64b, but this should include also texture arrays. Fixes `spec@glsl-1.30@execution@texelfetchoffset@vs-texelfetch-usampler1darray` and several other piglit tests. CC: mesa-stable Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com> Part-of: <mesa/mesa!22775> (cherry picked from commit c8151891)
-
Eric Engestrom authored
-
- May 01, 2023
-
-
Cc: mesa-stable Part-of: <mesa/mesa!20152> (cherry picked from commit 17a7c55e)
-
Fixes: 3017d01c ("zink: check for extendedDynamicState3DepthClipNegativeOneToOne for ds3 support") Part-of: <mesa/mesa!22765> (cherry picked from commit 0b64c737)
-
this otherwise causes infinite loops in subgroup tests and kills ci Fixes: 4a056807 ("gallivm: break out native vector width calc for reuse") Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!22767> (cherry picked from commit e9864d7f)
-
reason: corect cropping calculation error. If no cropping from the external, then it will need to calculate cropping size internally, the padding size on left and top should be zero. Cc: mesa-stable Fixes: mesa/mesa#7171 Reviewed-by: Thong Thai <thong.thai@amd.com> Signed-off-by: Ruijing Dong <ruijing.dong@amd.com> Part-of: <mesa/mesa!22758> (cherry picked from commit b07f575a)
-
This broke many tests on GFX6 (Pitcairn). Fixes: c1821544 ("ac/nir: add ac_nir_lower_ps") Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Reviewed-by: Qiang Yu <yuq825@gmail.com> Part-of: <mesa/mesa!22756> (cherry picked from commit faf27fa0)
-
i915 and Xe kmd allows scanout to display of prime buffers placed in smem. Allowing shared and scanout bos to be placed in smem and lmem allows the dma buf to work in some cases that only lmem is not enough. Fixes: c10ff197 ("iris: Place scanout buffers only into lmem for discrete GPUs") Closes: mesa/mesa#8867 Closes: mesa/mesa#8766 Signed-off-by: José Roberto de Souza <jose.souza@intel.com> Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Tested-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <mesa/mesa!22665> (cherry picked from commit ec6d520e)
-
Cc: mesa-stable Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Part-of: <mesa/mesa!22741> (cherry picked from commit a1b46b5e)
-
Cc: mesa-stable Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Part-of: <mesa/mesa!22741> (cherry picked from commit d09a7132)
-
Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Closes: mesa/mesa#7742 Cc: mesa-stable Part-of: <mesa/mesa!22741> (cherry picked from commit f53e5efa)
-
Only apply the clamp in multi patch mode (where the input vertices vary between [1, 32]). The clamp NIR pass operates on lowered intrinsics so we need to call it after the inputs have been lowered. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: e25e17dd ("intel/fs: clamp per vertex input accesses to patchControlPoints") Closes: mesa/mesa#8912 Reviewed-by: Ivan Briano <ivan.briano@intel.com> Part-of: <mesa/mesa!22701> (cherry picked from commit 7ddc31c6)
-
if the size of the constant buffer + stride overflows UINT32_MAX, DIV_ROUND_UP will return 0, which is, in some sense, extremely robust, but for general functionality it's not actually very robust cc: mesa-stable Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com> Part-of: <mesa/mesa!22720> (cherry picked from commit 79b3828e)
-
Commit f9a074dd ("dri2/android: Bypass throttling") dropped unnecessary throtting in the SwapBuffers() path for android. But unfortunately MSAA resolve got tangled up in the throttle reason flag. So add a new flag that indicates "no throttingling, but yes please do MSAA resolve". Fixes: f9a074dd ("dri2/android: Bypass throttling") Signed-off-by: Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!22719> (cherry picked from commit 08ffa8e0)
-
The atof and strtod functions use the locale of the user when determining if a decimal is a comma, ',' or a period, '.'. Thanks to @fzwoch for helping find the cause of a shader-related issue. Cc: mesa-stable Closes: mesa/mesa#5760 Signed-off-by: Thong Thai <thong.thai@amd.com> Acked-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!22699> (cherry picked from commit 9c4e3c90)
-
Cc: mesa-stable Signed-off-by: Thong Thai <thong.thai@amd.com> Acked-by: Marek Olšák <marek.olsak@amd.com> Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!22699> (cherry picked from commit 27eafdcb)
-
Cc: mesa-stable Signed-off-by: Thong Thai <thong.thai@amd.com> Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!22699> (cherry picked from commit 7373f25c)
-
Not sure if this is possible, but we should avoid it anyway. No fossil-db changes. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Cc: mesa-stable Part-of: <mesa/mesa!22714> (cherry picked from commit d0caa50d)
-
Spotted by Nanley Chery. Closes: mesa/mesa#4427 Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Reviewed-by: Charmaine Lee <charmainel@vmware.com> Reviewed-by: Neha Bhende <bhenden@vmware.com> Cc: mesa-stable Part-of: <mesa/mesa!22706> (cherry picked from commit 9105e771)
-
In order to use load_global_const_block_intel we need to ensure the 64bit address in src[0] is uniform. This is not the case in the vkd3d-proton test_bindless_cbv tests for example. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!22624> (cherry picked from commit 9fb9ae5a)
-
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!22624> (cherry picked from commit d6e9479d)
-
If extendedDynamicState3ConservativeRasterizationMode is enabled, VK_EXT_conservative_rasterization is mandatory. Fixes recent updates in dEQP-VK.info.device_mandatory_features. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!22681> (cherry picked from commit 44a2e5ba)
-
util_last_bit already included the +1 Fixes: mesa/mesa!11865 (9205a45d) Closes: mesa/mesa#8894 cc: mesa-stable Signed-off-by: Axel Davy <davyaxel0@gmail.com> Reviewed-by: David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!22645> (cherry picked from commit ad1e6455)
-
attachment bits must always be removed if they are not supported fixes (ANV): KHR-GL46.texture_view.view_classes cc: mesa-stable Part-of: <mesa/mesa!22713> (cherry picked from commit 13eaa7cd)
-