Skip to content
Snippets Groups Projects
  1. Feb 26, 2019
  2. Feb 25, 2019
  3. Feb 20, 2019
  4. Feb 19, 2019
  5. Feb 18, 2019
  6. Feb 15, 2019
  7. Feb 13, 2019
  8. Feb 12, 2019
    • Tim-Philipp Müller's avatar
      buffer: store sequence number for metas · f62ee975
      Tim-Philipp Müller authored
      For metas where order might be significant if multiple metas are
      attached to the same buffer, so store a sequence number with the
      meta when adding it to the buffer. This allows users of the meta
      to make sure metas are processed in the right order.
      
      We need a 64-bit integer for the sequence number here in the API,
      a 32-bit one might overflow too easily with high packet/buffer
      rates. We could do it rtp-seqnum style of course, but that's a
      bit of a pain.
      
      We could also make it so that gst_buffer_add_meta() just keeps metas in
      order or rely on the order we add the metas in, but that seems too
      fragile overall, when buffers (incl. metas) get merged or split.
      
      Also add a compare function for easier sorting.
      
      We store the seqnum in the MetaItem struct here and not in the
      GstMeta struct since there's no padding in the GstMeta struct.
      We could add a private struct to GstMeta before the start of
      GstMeta, but that's what MetaItem effectively is implementation-
      wise. We can still change this later if we want, since it's all
      private.
      
      Fixes #262
      f62ee975
  9. Feb 09, 2019
  10. Feb 08, 2019
  11. Feb 05, 2019
    • Nirbheek Chauhan's avatar
      misc: Fix various compiler warnings on MinGW · febfabb3
      Nirbheek Chauhan authored
      gstharness.c: Use G_GSIZE_FORMAT instead of hard-coding %zu
      error: unknown conversion type character 'z' in format [-Werror=format]
      
      gst-inspect.c: GPid is void* on non-UNIX, and we only use it on UNIX
      error: initialization makes pointer from integer without a cast [-Werror]
      
      gstmeta.c: Use and then discard value
      error: value computed is not used [-Werror=unused-value]
      
      With this, gstreamer builds with -Werror on MinGW
      febfabb3
  12. Jan 29, 2019
  13. Jan 28, 2019
  14. Jan 26, 2019
    • Nicolas Dufresne's avatar
      pad: Remove unneeded 64bit upcast in debug trace · c816ec4f
      Nicolas Dufresne authored and Nicolas Dufresne's avatar Nicolas Dufresne committed
      The hook->hook_id is a gulong for which there are no portability issues
      when tracing in printf format with %lu. So use %lu and remove the upcast
      to 64 bit. This makes the code more consistent with everything else
      tracing that hook_id and other gulong id.
      c816ec4f
  15. Jan 25, 2019
    • Nicolas Dufresne's avatar
      gst-inspect: Re-add DEFAULT_LESS_OPTS with initial value · 35300f82
      Nicolas Dufresne authored
      Commit 56b4fbef refactored the pipe code
      to use GLib utility, but the patch was hading some other changed. LESS
      env was now hardcoded in the middle instead of from a define and was
      changed from FXR to -RX. The "-" is not even valid for LESS env, and
      with the lost of F, we would still use a pager when the content fits the
      terminal.
      35300f82
  16. Jan 24, 2019
  17. Jan 23, 2019
  18. Jan 22, 2019
  19. Jan 17, 2019
  20. Jan 16, 2019
  21. Jan 15, 2019
  22. Jan 14, 2019
    • Daniel Drake's avatar
      deviceprovider: fix counting number of times started · e0c9b045
      Daniel Drake authored
      GstDeviceProvider has a started_count private variable counter,
      and the gst_device_provider_start() documentation emphasizes the
      importance of balancing the start and stop calls.
      
      However, when starting a provider that is already started, the
      current code will never increment the counter more than once.
      
      So you start it twice, but it will have start_count 1, which is the
      maximum value it will ever see.
      
      Then when you stop it twice, on the 2nd stop, after decrementing the
      counter in gst_device_provider_stop():
      
        else if (provider->priv->started_count < 1) {
          g_critical
              ("Trying to stop a GstDeviceProvider %s which is already stopped",
              GST_OBJECT_NAME (provider));
      
      and the program is killed.
      
      Fix this by incrementing the counter when starting a device provider that
      was already started.
      e0c9b045
  23. Jan 11, 2019
  24. Jan 10, 2019
  25. Jan 09, 2019
Loading