- Apr 24, 2017
-
-
Emil Velikov authored
Signed-off-by:
Emil Velikov <emil.velikov@collabora.com>
-
Emil Velikov authored
As pointed out by compiler ./llvm/codegen.hpp:52:22: error: ‘<::’ cannot begin a template-argument list [-fpermissive] ./llvm/codegen.hpp:52:22: note: ‘<:’ is an alternate spelling for ‘[’. Insert whitespace between ‘<’ and ‘::’ Cc: Francisco Jerez <currojerez@riseup.net> Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Nicolai Hähnle <nicolai.haehnle@amd.com> Reviewed-by:
Vedran Miletić <vedran@miletic.net> (cherry picked from commit dd6ec78b)
-
Signed-off-by:
Vinson Lee <vlee@freedesktop.org> Reviewed-by:
Alejandro Piñeiro <apinheiro@igalia.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Cc: <mesa-stable@lists.freedesktop.org> (cherry picked from commit b81d85f1)
-
Currently we were only making sure types were the same within a single stage. This looks to have regressed with 953a0af8. Fixes: 953a0af8 ("mesa: validate sampler uniforms during gluniform calls") Reviewed-by:
Nicolai Hähnle <nicolai.haehnle@amd.com> Reviewed-by:
Tapani Pälli <tapani.palli@intel.com> https://bugs.freedesktop.org/show_bug.cgi?id=97524 (cherry picked from commit d682f8aa)
-
Emil Velikov authored
As mentioned in the manual - comparing pthread_t handles via the C comparison operator is incorrect and pthread_equal() should be used instead. Cc: Timothy Arceri <tarceri@itsqueeze.com> Fixes: d8d81fbc ("mesa: Add infrastructure for a worker thread to process GL commands.") Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Plamena Manolova <plamena.manolova@intel.com> Reviewed-by:
Brian Paul <brianp@vmware.com> Reviewed-by:
Eric Anholt <eric@anholt.net> (cherry picked from commit 52df318d)
-
Emil Velikov authored
If VDPAU is installed in the non-default location, we'll fail to find the headers and error at build time. ../../src/gallium/include/state_tracker/vdpau_dmabuf.h:37:25: fatal error: vdpau/vdpau.h: No such file or directory #include <vdpau/vdpau.h> ^ Fixes: faba96bc ("st/vdpau: add new interop interface") Cc: Christian König <christian.koenig@amd.com> Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Nicolai Hähnle <nicolai.haehnle@amd.com> (cherry picked from commit 51c0c213)
-
Emil Velikov authored
Fixes: 1ac40173 ("configure.ac: simplify EGL requirements for drivers dependent on EGL") Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Nicolai Hähnle <nicolai.haehnle@amd.com> (cherry picked from commit 4516bfbd)
-
Emil Velikov authored
The macro is introduced with pkgconfig v0.28 which isn't universally available. Thus it will error at configure stage. Reported-by:
Brian Paul <brianp@vmware.com> Tested-by:
Brian Paul <brianp@vmware.com> Fixes: ce562f9e ("EGL: Implement the libglvnd interface for EGL (v3)") Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> (cherry picked from commit 179e21a7)
-
So atexit() is horrible and 4aea8fe7 is probably not a good idea. But add an extra layer of duct-tape to the problem. Otherwise we hit a situation where app using an atexit() handler that runs later than ours doesn't hang when trying to tear down a context. (gdb) bt #0 util_queue_killall_and_wait (queue=queue@entry=0x52bc80) at ../../../src/util/u_queue.c:264 #1 0x0000007fb6c380c0 in atexit_handler () at ../../../src/util/u_queue.c:51 #2 0x0000007fb7730e2c in __run_exit_handlers () from /lib64/libc.so.6 #3 0x0000007fb7730e5c in exit () from /lib64/libc.so.6 #4 0x0000007fb7ce17dc in piglit_report_result (result=PIGLIT_PASS) at /home/robclark/src/piglit/tests/util/piglit-util.c:267 #5 0x0000007fb7ef99f8 in process_next_event (x11_fw=0x432c20) at /home/robclark/src/piglit/tests/util/piglit-framework-gl/piglit_x11_framework.c:139 #6 0x0000007fb7ef9a90 in enter_event_loop (winsys_fw=0x432c20) at /home/robclark/src/piglit/tests/util/piglit-framework-gl/piglit_x11_framework.c:153 #7 0x0000007fb7ef8e50 in run_test (gl_fw=0x432c20, argc=1, argv=0x7ffffff588) at /home/robclark/src/piglit/tests/util/piglit-framework-gl/piglit_winsys_framework.c:88 #8 0x0000007fb7edb890 in piglit_gl_test_run (argc=1, argv=0x7ffffff588, config=0x7ffffff400) at /home/robclark/src/piglit/tests/util/piglit-framework-gl.c:203 #9 0x0000000000401224 in main (argc=1, argv=0x7ffffff588) at /home/robclark/src/piglit/tests/bugs/drawbuffer-modes.c:46 (gdb) c Continuing. [Thread 0x7fb67580c0 (LWP 3471) exited] ^C Thread 1 "drawbuffer-mode" received signal SIGINT, Interrupt. 0x0000007fb72dda34 in pthread_cond_wait@@GLIBC_2.17 () from /lib64/libpthread.so.0 (gdb) bt #0 0x0000007fb72dda34 in pthread_cond_wait@@GLIBC_2.17 () from /lib64/libpthread.so.0 #1 0x0000007fb6c38304 in cnd_wait (mtx=0x5bdc90, cond=0x5bdcc0) at ../../../include/c11/threads_posix.h:159 #2 util_queue_fence_wait (fence=0x5bdc90) at ../../../src/util/u_queue.c:106 #3 0x0000007fb6daac70 in fd_batch_sync (batch=0x5bdc70) at ../../../../../src/gallium/drivers/freedreno/freedreno_batch.c:233 #4 batch_reset (batch=batch@entry=0x5bdc70) at ../../../../../src/gallium/drivers/freedreno/freedreno_batch.c:183 #5 0x0000007fb6daa5e0 in batch_flush (batch=0x5bdc70) at ../../../../../src/gallium/drivers/freedreno/freedreno_batch.c:290 #6 fd_batch_flush (batch=0x5bdc70, sync=<optimized out>) at ../../../../../src/gallium/drivers/freedreno/freedreno_batch.c:308 #7 0x0000007fb6daba2c in fd_bc_flush (cache=0x461220, ctx=0x52b920) at ../../../../../src/gallium/drivers/freedreno/freedreno_batch_cache.c:141 #8 0x0000007fb6dac954 in fd_context_flush (pctx=0x52b920, fence=0x0, flags=<optimized out>) at ../../../../../src/gallium/drivers/freedreno/freedreno_context.c:54 #9 0x0000007fb6b43294 in st_glFlush (ctx=<optimized out>) at ../../../src/mesa/state_tracker/st_cb_flush.c:121 #10 0x0000007fb69a84e8 in _mesa_make_current (newCtx=newCtx@entry=0x0, drawBuffer=drawBuffer@entry=0x0, readBuffer=readBuffer@entry=0x0) at ../../../src/mesa/main/context.c:1654 #11 0x0000007fb6b7ca58 in st_api_make_current (stapi=<optimized out>, stctxi=0x0, stdrawi=0x0, streadi=0x0) at ../../../src/mesa/state_tracker/st_manager.c:827 #12 0x0000007fb6cc87e8 in dri_unbind_context (cPriv=<optimized out>) at ../../../../../src/gallium/state_trackers/dri/dri_context.c:217 #13 0x0000007fb6cc80b0 in driUnbindContext (pcp=0x5271e0) at ../../../../../../src/mesa/drivers/dri/common/dri_util.c:591 #14 0x0000007fb7d1da08 in MakeContextCurrent (dpy=0x433380, draw=0, read=0, gc_user=0x0) at ../../../src/glx/glxcurrent.c:214 #15 0x0000007fb7a8d5e0 in glx_platform_make_current () from /lib64/libwaffle-1.so.0 #16 0x0000007fb7a894e4 in waffle_make_current () from /lib64/libwaffle-1.so.0 #17 0x0000007fb7ef8c60 in piglit_wfl_framework_teardown (wfl_fw=0x432c20) at /home/robclark/src/piglit/tests/util/piglit-framework-gl/piglit_wfl_framework.c:628 #18 0x0000007fb7ef939c in piglit_winsys_framework_teardown (winsys_fw=0x432c20) at /home/robclark/src/piglit/tests/util/piglit-framework-gl/piglit_winsys_framework.c:238 #19 0x0000007fb7ef9c30 in destroy (gl_fw=0x432c20) at /home/robclark/src/piglit/tests/util/piglit-framework-gl/piglit_x11_framework.c:212 #20 0x0000007fb7edb7c4 in destroy () at /home/robclark/src/piglit/tests/util/piglit-framework-gl.c:184 #21 0x0000007fb7730e2c in __run_exit_handlers () from /lib64/libc.so.6 #22 0x0000007fb7730e5c in exit () from /lib64/libc.so.6 #23 0x0000007fb7ce17dc in piglit_report_result (result=PIGLIT_PASS) at /home/robclark/src/piglit/tests/util/piglit-util.c:267 #24 0x0000007fb7ef99f8 in process_next_event (x11_fw=0x432c20) at /home/robclark/src/piglit/tests/util/piglit-framework-gl/piglit_x11_framework.c:139 #25 0x0000007fb7ef9a90 in enter_event_loop (winsys_fw=0x432c20) at /home/robclark/src/piglit/tests/util/piglit-framework-gl/piglit_x11_framework.c:153 #26 0x0000007fb7ef8e50 in run_test (gl_fw=0x432c20, argc=1, argv=0x7ffffff588) at /home/robclark/src/piglit/tests/util/piglit-framework-gl/piglit_winsys_framework.c:88 #27 0x0000007fb7edb890 in piglit_gl_test_run (argc=1, argv=0x7ffffff588, config=0x7ffffff400) at /home/robclark/src/piglit/tests/util/piglit-framework-gl.c:203 #28 0x0000000000401224 in main (argc=1, argv=0x7ffffff588) at /home/robclark/src/piglit/tests/bugs/drawbuffer-modes.c:46 (gdb) r Fixes: 4aea8fe7 ("gallium/u_queue: fix random crashes when the app calls exit()") Signed-off-by:
Rob Clark <robdclark@gmail.com> Reviewed-by:
Nicolai Hähnle <nicolai.haehnle@amd.com> (cherry picked from commit 6fb7935d)
-
Emil Velikov authored
The warning should be printed only when one explicitly uses the deprecated configure toggle. Fixes: 7748c3f5 ("configure.ac: deprecate --with-egl-platforms over --with-platforms") Signed-off-by:
Emil Velikov <emil.l.velikov@gmail.com> (cherry picked from commit 9915753e)
-
Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Ilia Mirkin <imirkin@alum.mit.edu> Reviewed-by:
Brian Paul <brianp@vmware.com> (cherry picked from commit 7cd6e2df)
-
Emil Velikov authored
Resolves build issues like the following: src/gallium/winsys/sw/dri/dri_sw_winsys.c:203:31: error: pointer of type ‘void *’ used in arithmetic [-Werror=pointer-arith] data = dri_sw_dt->data + (dri_sw_dt->stride * box->y) + box->x * blsize; ^ src/gallium/winsys/sw/dri/dri_sw_winsys.c:203:62: error: pointer of type ‘void *’ used in arithmetic [-Werror=pointer-arith] data = dri_sw_dt->data + (dri_sw_dt->stride * box->y) + box->x * blsize; ^ Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Nicolai Hähnle <nicolai.haehnle@amd.com> (cherry picked from commit 309f4067)
-
Fixes a bug in KHR-GL45.shader_draw_parameters_tests.ShaderMultiDrawArraysParameters. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit 51deba0e)
-
When any count[i] is negative, we must skip all draws. Moving to vbo makes the subsequent change easier. v2: - provide the function in all contexts, including GLES - adjust validation accordingly to include the xfb check v3: - fix mix-up of pre- and post-xfb prim count (Nils Wallménius) Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Timothy Arceri <tarceri@itsqueeze.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit 42d5465b)
-
The same logic needs to be applied to glMultiDrawArrays. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Timothy Arceri <tarceri@itsqueeze.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit 756e9ebb)
-
Found by inspection. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Timothy Arceri <tarceri@itsqueeze.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit ea9a8940)
-
The description under RENDER_SURFACE_STATE::RedClearColor says, For Sampling Engine Multisampled Surfaces and Render Targets: Specifies the clear value for the red channel. For Other Surfaces: This field is ignored. This means that the sampler on BDW doesn't support CCS. Cc: Samuel Iglesias Gonsálvez <siglesias@igalia.com> Cc: Jordan Justen <jordan.l.justen@intel.com> Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Signed-off-by:
Nanley Chery <nanley.g.chery@intel.com> (cherry picked from commit d9d79369)
-
Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Cc: "13.0 17.0" <mesa-stable@lists.freedesktop.org> (cherry picked from commit d71efbe5)
-
In this case, ctx->flush_queue would not have been initialized. Fixes: 0b613c20 ("freedreno: enable draw/batch reordering by default") Cc: "17.1" <mesa-stable@lists.freedesktop.org> Signed-off-by:
Rob Clark <robdclark@gmail.com> (cherry picked from commit d4601b0e)
-
- Apr 17, 2017
-
-
Emil Velikov authored
Signed-off-by:
Emil Velikov <emil.velikov@collabora.com>
-
Emil Velikov authored
This reverts commit 47dd2544. Should have landed in the master branch
-
Emil Velikov authored
Signed-off-by:
Emil Velikov <emil.velikov@collabora.com>
-
Emil Velikov authored
Currently the former controls more than just EGL. With follow-up commits we'll unwind and fix things so that one can build the different drivers with said platform support. Signed-off-by:
Emil Velikov <emil.velikov@collabora.com>
-
Emil Velikov authored
The configure option is used by more than just EGL and with next commit we'll rename it accordingly. Thus having the check will (and is atm) incorrect. Signed-off-by:
Emil Velikov <emil.velikov@collabora.com>
-
Emil Velikov authored
Signed-off-by:
Emil Velikov <emil.lvelikov@collabora.com> Reviewed-by:
Eric Anholt <eric@anholt.net>
-
Emil Velikov authored
We are not using either of these. The respecive xcb packages are used instead. v2: Rebase, reword commit message. Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Eric Anholt <eric@anholt.net>
-
The new interface mostly just sits on top of the existing library. The only change to the existing EGL code is to split the client extension string into platform extensions and everything else. On non-glvnd builds, eglQueryString will just concatenate the two strings. The EGL dispatch stubs are all generated. The script is based on the one used to generate entrypoints in libglvnd itself. v2: [Kyle] - Rebased against master. - Reworked the EGL makefile to use separate libraries - Made the EGL code generation scripts work with Python 2 and 3. - Change gen_egl_dispatch.py to use argparse for the command line arguments. - Assorted formatting and style cleanup in the Python scripts. v3: [Emil Velikov] - Rebase - Remove separate glvnd glx/egl configure toggles Signed-off-by:
Emil Velikov <emil.velikov@collabora.com>
-
Fixes: efd63e23 ("mesa: Connect the generated GL command marshalling code to the build.") Signed-off-by:
Tapani Pälli <tapani.palli@intel.com> Reviewed-by:
Plamena Manolova <plamena.manolova@intel.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com>
-
Emil Velikov authored
We should check the presence in order to determine if we should [implicitly] set the CFLAGS/LIBS v2: Drop spurious OMX hunk (Eric) Cc: Eric Anholt <eric@anholt.net> Reported-by:
Eric Anholt <eric@anholt.net> Signed-off-by:
Emil Velikov <emil.velikov@collabora.com>
-
Emil Velikov authored
Earlier commit bumped the requirement for the SWR driver. v2: Fold the note with the LLVM 3.9 one (Tim) Fixes: 3c52a731 ("swr: [configure.ac/scons] require c++14") Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Tim Rowley <timothy.o.rowley@intel.com>
-
Samuel Pitoiset authored
Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com>
-
Samuel Pitoiset authored
Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com>
-
Kenneth Graunke authored
I accidentally moved the bo->bufmgr dereference above the NULL check when cleaning up this code. While passing NULL to free() is a common pattern...passing NULL to unmap seems pretty bad. You really ought to know whether you have a buffer or not. We don't want to paper over bugs like that. So, just drop the NULL check altogether. CID: 1405006 Reviewed-by:
Chris Wilson <chris@chris-wilson.co.uk>
-
Kenneth Graunke authored
Starting positions >= 32 are not part of the header, rather than >. Caught by Coverity, which found that "bits <<= field->start" may shift by 32, which has undefined behavior. CID: 1404968 Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com>
-
Kenneth Graunke authored
If ret is 0, we return. If ret is not 0, we return. This is dead. CID: 1405013 (Structurally dead code (UNREACHABLE)) Reviewed-by:
Topi Pohjolainen <topi.pohjolainen@intel.com>
-
Fixes the following build error: external/mesa/src/amd/addrlib/gfx9/gfx9addrlib.cpp:36:10: fatal error: 'gfx9_gb_reg.h' file not found ^ 1 error generated. Fixes: 7f160efc "amd/addrlib: import gfx9 support" Reviewed-by:
Nicolai Hähnle <nicolai.haehnle@amd.com> Reviewed-by:
Edward O'Callaghan <funfunctor@folklore1984.net>
-
Faith Ekstrand authored
Reviewed-by:
Alejandro Piñeiro <apinheiro@igalia.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com>
-
- Apr 16, 2017
-
-
Marek Olšák authored
This hides the overhead of everything in the driver after the CS flush and before returning from pipe_context::flush. Only microbenchmarks will benefit. +2% FPS for glxgears. Reviewed-by:
Nicolai Hähnle <nicolai.haehnle@amd.com>
-
Marek Olšák authored
Reviewed-by:
Nicolai Hähnle <nicolai.haehnle@amd.com>
-
Marek Olšák authored
cleanup Reviewed-by:
Nicolai Hähnle <nicolai.haehnle@amd.com>
-