- Aug 01, 2019
-
-
Lina Versace authored
-
Lina Versace authored
VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT
-
Lina Versace authored
-
Lina Versace authored
FINISHME: anv: Fix VkPhysicalDeviceExternalImageFormatInfo for VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT
-
Lina Versace authored
-
Lina Versace authored
-
Lina Versace authored
A step toward support VK_EXT_image_drm_format_modifier.
-
Lina Versace authored
A step toward supporting VK_EXT_image_drm_format_modifier.
-
Lina Versace authored
Rename it to 'base_info', to distinguish it from 'drm_info' introduced in upcoming commit.
-
Lina Versace authored
A step toward supporting VK_EXT_image_drm_format_modifier.
-
Lina Versace authored
Refactor only. No intended behavioral change. Much of the existing code assumes, with good justification, that tiling is either VK_IMAGE_TILING_LINEAR or VK_IMAGE_TILING_OPTIMAL. But VK_EXT_image_drm_format_modifier will void that assumption. Some examples where currently valid assumptions become invalid: - Code written as if (tiling != VK_IMAGE_TILING_OPTIMAL) but whose true intent is if (tiling == VK_IMAGE_TILING_LINEAR) will break when tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT. - Some code written as if (tilng == VK_IMAGE_TILING_LINEAR) will need updating to if (tiling == VK_IMAGE_TILING_LINEAR || (tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT && drm_format_mod == DRM_FORMAT_MOD_LINEAR)) - Many query functions with a VkImageTiling parameter will require an additional parameter for the DRM format modifier. The invalidity of many of the above cases become clearer if we generally abandon using VkImageTiling to indicate tiling, and instead use a new type that includes an optional DRM format modifier: struct anv_tiling { VkImageTiling vk; uint64_t drm_format_mod; }; This patch does not attempt to fix code with soon-to-be invalid assumptions. Instead, it restricts itself to the following changes: - Replace type of: - anv_get_format_features()::tiling - anv_get_format_plane()::tiling - anv_get_isl_format()::tiling - anv_image::tiling - Fold anv_image::drm_format_mod into anv_image::tiling. - Replace variables 'vk_tiling' with 'tiling.vk'.
-
Lina Versace authored
anv_get_image_format_features() already reports that we do not support linear images with depth/stencil formats. For consistency, teach anv_get_format_plane() to do the same.
-
Lina Versace authored
The field 'isl_tiling_flags' offered more flexibility than needed. The driver set at most one flag, and when set the driver translated the sole flag into a DRM format modifier. This patch enforces that convention by replacing field 'isl_tiling_flags' with 'drm_format_mod'. Now anv_image_create_info's behavior when overriding tiling is aligned with VK_EXT_image_drm_format_modifier; that is, anv_image_create_info::drm_format_mod is analagous to VkImageDrmFormatModifierExplicitCreateInfoEXT::drmFormatModifier.
-
Lina Versace authored
To allow use of DRM_FORMAT_MOD_INVALID in future inline functions for struct anv_tiling.
-
Emil Velikov authored
Currently we use the python package to manage repositories. At the same time we also do that by hand - since it's a trivial echo to a file. Stay consistent, remove the package and manage things manually. Acked-by: Eric Engestrom <eric@engestrom.ch> Reviewed-by: Michel Dänzer <michel.daenzer@amd.com> Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
-
Brian Paul authored
Trivial.
-
Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Reviewed-by: Marek Olšák <marek.olsak@amd.com>
-
Use value "2" to signal that lowering is needed and supported and enable it accordingly. v2: - Note in CAP description that this lowering currently requires TGSI - use "true" instead of GL_TRUE (both Erik) Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Reviewed-by: Marek Olšák <marek.olsak@amd.com>
-
v1 implemented by Erik Faye-Lund <erik.faye-lund@collabora.com> v2: - Add GS and TES - fix constants state update flags (Erik) v3: don't update rasterizer when depth_clamp is lowered (Erik) v4: Correct NewDepthClamp and also set flags for NewClipControl (Erik) v5: Also set shader_has_one_variant property acording to possible depth_clamp lowering (Marek) Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Reviewed-by: Marek Olšák <marek.olsak@amd.com>
-
implemented by Erik Faye-Lund <erik.faye-lund@collabora.com> v2: Use current depth range values for clamping (Erik) v3: fix scons-win64 build Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Reviewed-by: Marek Olšák <marek.olsak@amd.com>
-
v2: Use file scope defined depth_range_state in common v3: - don't use the one_shader_variant property, as this is not correct (Marek) - also use tests on available shader stages to enable depth_clamp lowering v4: Don't use key.st, use st directly (Marek) Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Reviewed-by: Marek Olšák <marek.olsak@amd.com>
-
v1 implemented by Erik Faye-Lund <erik.faye-lund@collabora.com> v2: Use different call for FS v3: Use file scope defined depth_range_state Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Reviewed-by: Marek Olšák <marek.olsak@amd.com>
-
v1: implemented by Erik Faye-Lund <erik.faye-lund@collabora.com> v2: Add handling of the ARB_clip_control depth mode v3: Move depth_range_state to file scope and remove training zeros (Erik) v4: - don't use the one_shader_variant property, as this is not correct (Marek) - also use tests on available shader stages to enable depth_clamp lowering V5: Don't use key.st, use st directly (Marek) Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Reviewed-by: Marek Olšák <marek.olsak@amd.com>
-
This is a TGSI pass that lowers depth-clamping into shader-operations, by replacing the depth-value with 0 (a z-coordinate of zero will always pass the OpenGL depth test conditions), and using a dedicated varying to interpolate the real depth-value instead. Finally we replace the depth-output in the fragment shader. v1 implemented by Erik Faye-Lund <erik.faye-lund@collabora.com> v2: Add support for handling depth clip mode, and refactor code v3: - Rename *_vs functions to *_last_vertex_stage (Erik) - Use 0.0 depth to avoid clipping (Erik) v4: Fix inversion of bool value for clip control property Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Reviewed-by: Marek Olšák <marek.olsak@amd.com>
-
Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Reviewed-by: Marek Olšák <marek.olsak@amd.com>
-
This was too aggressive and breaks TF (Ilia) This reverts commit 4ee638cd. Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Roland Scheidegger <sroland@vmware.com>
-
- Jul 31, 2019
-
-
Eric Engestrom authored
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com> Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
-
Eric Engestrom authored
Those are already their default values on MacOS. Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
-
Faith Ekstrand authored
Reviewed-by: Matt Turner <mattst88@gmail.com>
-
Faith Ekstrand authored
Reviewed-by: Matt Turner <mattst88@gmail.com>
-
Faith Ekstrand authored
Reviewed-by: Matt Turner <mattst88@gmail.com>
-
Faith Ekstrand authored
Reviewed-by: Matt Turner <mattst88@gmail.com>
-
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by: Eric Engestrom <eric.engestrom@intel.com>
-
Dave Airlie authored
This doesn't seem to need it's own copy here. Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
-
Eric Engestrom authored
These were left after a rebase and happen to make NIR_INTRINSIC_SWIZZLE_MASK == NIR_INTRINSIC_SRC_ACCESS, which is how it was noticed. Fixes: 6f20643b ("nir: Allow qualifiers on copy_deref and image instructions") Cc: Connor Abbott <cwabbott0@gmail.com> Signed-off-by: Eric Engestrom <eric.engestrom@intel.com> Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Reviewed-by: Eric Anholt <eric@anholt.net>
-
Memory leaks were observed on iris with GL_KHR_debug. Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com>
-
Kenneth Graunke authored
We were emitting 3DSTATE_INDEX_BUFFER on every indexed draw, even if back-to-back draws referred to the same index buffer. This improves drawoverhead scores in the DrawElements cases by about 10%, by giving us even more minimal batches.
-
this makes dri2_get_mapping_by_fourcc accessible from dri_helpers.h and does a direct lookup on the fourcc id to match the pipe format v2 (Ken): Allow map to be NULL, use img->texture->format. Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Reviewed-by: Eric Anholt <eric@anholt.net>
-
Erico Nunes authored
The mali pp doesn't support integers and some nir_algebraic optimizations may result in ops that are not easily lowerable to floats, so disable optimizations resulting in bitops. Signed-off-by: Erico Nunes <nunes.erico@gmail.com> Reviewed-by: Jonathan Marek <jonathan@marek.ca>
-
Erico Nunes authored
Optimizations that insert bitshift or bitwise operations should not be applied on GPUs that don't support integer operations. The .lower_bitshift could be used to control the bitshift related ones, but there was also one bitwise optimization uncovered. Since only lima and freedreno use this option and the use case is that no bit operations are wanted, let's rename it to .lower_bitops and use it to control all bitops related optimizations. Signed-off-by: Erico Nunes <nunes.erico@gmail.com> Reviewed-by: Jonathan Marek <jonathan@marek.ca>
-