Skip to content
Snippets Groups Projects
Commit cc7b7d50 authored by François Laignel's avatar François Laignel Committed by GStreamer Marge Bot
Browse files

rtp: gccbwe: don't break downstream assumptions pushing buffer lists

Some elements in the RTP stack assume all buffers in a `gst::BufferList`
correspond to the same timestamp. See in [`rtpsession`] for instance.
This also had the effect that `rtpsession` did not create correct RTCP as it
only saw some of the SSRCs in the stream.

`rtpgccbwe` formed a packet group by gathering buffers in a `gst::BufferList`,
regardless of whether they corresponded to the same timestamp, which broke
synchronization under certain circonstances.

This commit makes `rtpgccbwe` push the buffers as they were received: one by one.

[`rtpsession`]: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/bc858976db163bd72e19cac7b1c339faf58e053d/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpsession.c#L2462

Part-of: <gstreamer/gst-plugins-rs!1502>
parent 2b9272c7
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment