- Nov 16, 2020
-
-
Dave Airlie authored
-
Dave Airlie authored
-
Dave Airlie authored
Unless the non uniform work group extension is supported, this just aliases workgroupsize, so just do that for now. Fixes: CL CTS basic enqueued_local_size Reviewed-by:
Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!7642>
-
Dave Airlie authored
fixes CTS 3.0 test_computeinfo Reviewed-by:
Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!7642>
-
Dave Airlie authored
Reviewed-by:
Karol Herbst <kherbst@redhat.com> Part-of: <!7642>
-
Dave Airlie authored
the real IL code will rewrite this Reviewed-by:
Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!7642>
-
Dave Airlie authored
This just adds all the dummy 2.x/3.0 device and platform info queries that return fixed not supported values. As these are supported they will have to be migrated into the core. Reviewed-by:
Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!7642>
-
Dave Airlie authored
Reviewed-by:
Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!7642>
-
Dave Airlie authored
These CL 2.x APIs are all part of CL3.0 but have to return specific values to show they aren't supported. Reviewed-by:
Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!7642>
-
Dave Airlie authored
Fixes api queue_properties_queries Reviewed-by:
Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!7642>
-
Dave Airlie authored
This adds proper support for the buffer/image property APIs. Fixes: CL CTS api buffer_properties_queries v1.1: use a helper for properties parsing. Reviewed-by:
Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!7642>
-
Christian Gmeiner authored
It makes no sense to print the shader in the middle of some NIR passes. Instead someone could use NIR_PRINT=1 and call it a day. Also there is a nir_print_shader(..) before calling emit_shader(..). Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Lucas Stach <l.stach@pengutronix.de> Part-of: <mesa/mesa!7625>
-
Lucas Stach authored
Missing a copy of the pipe_sampler_state into the etna_sampler_state object lead to the texture_use_int_filter() to always see a max_anisotropy of 0, so the INT filter wasn't disabled when necessary. Also state emission should never change the state objects, as this might also lead to stale information being kept around the in the state object. Fixes: 89a41dae (etnaviv: do not use int filter when anisotropic filtering is used) Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by:
Lucas Stach <l.stach@pengutronix.de> Reviewed-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Part-of: <mesa/mesa!7638>
-
Erik Faye-Lund authored
Now that the d3d12 driver has landed, we should document it's features, like we do with other drivers. Reviewed-by:
Adam Jackson <ajax@redhat.com> Part-of: <!7583>
-
Rhys Perry authored
fossil-db (Navi): Totals from 70 (0.05% of 138791) affected shaders: SGPRs: 2324 -> 2097 (-9.77%) VGPRs: 1344 -> 1480 (+10.12%) CodeSize: 157872 -> 154836 (-1.92%); split: -1.93%, +0.01% MaxWaves: 1288 -> 1260 (-2.17%) Instrs: 29730 -> 29108 (-2.09%); split: -2.13%, +0.04% Cycles: 394944 -> 391280 (-0.93%); split: -0.94%, +0.01% VMEM: 5288 -> 5695 (+7.70%); split: +11.97%, -4.27% SMEM: 2680 -> 2444 (-8.81%); split: +1.34%, -10.15% VClause: 291 -> 502 (+72.51%) SClause: 1176 -> 918 (-21.94%) Copies: 3549 -> 3517 (-0.90%); split: -1.80%, +0.90% Branches: 1230 -> 1228 (-0.16%) PreSGPRs: 1675 -> 1491 (-10.99%) PreVGPRs: 1101 -> 1223 (+11.08%) Totals from 70 (0.05% of 139517) affected shaders (RAVEN): SGPRs: 2368 -> 2121 (-10.43%) VGPRs: 1344 -> 1480 (+10.12%) CodeSize: 156664 -> 153252 (-2.18%) MaxWaves: 636 -> 622 (-2.20%) Instrs: 29968 -> 29226 (-2.48%) Cycles: 398284 -> 393492 (-1.20%) VMEM: 5544 -> 5930 (+6.96%); split: +11.72%, -4.76% SMEM: 2752 -> 2502 (-9.08%); split: +1.20%, -10.28% VClause: 292 -> 504 (+72.60%) SClause: 1236 -> 940 (-23.95%) Copies: 3907 -> 3852 (-1.41%); split: -2.20%, +0.79% Branches: 1230 -> 1228 (-0.16%) PreSGPRs: 1671 -> 1487 (-11.01%) PreVGPRs: 1102 -> 1225 (+11.16%) Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> Part-of: <mesa/mesa!6143>
-
Erik Faye-Lund authored
This header uses uint32_t without including stdint.h. This worked fine by accident until a new c-source started including it. Fixes: 1bf539b3 ("mesa: Clamp some depth values in glClearBufferfv") Reviewed-by:
Tapani Pälli <tapani.palli@intel.com> Part-of: <mesa/mesa!7637>
-
Rhys Perry authored
Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!7605>
-
Rhys Perry authored
We were testing for -0.5 instead. Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Fixes: 1210e0bd ("aco: create 16-bit input and output modifiers") Part-of: <!7605>
-
Rhys Perry authored
The RDNA ISA doc says that omod doesn't preserve -0.0 in 6.2.2. LLVM appears to always disable omod in this situation, but clamp is unaffected. Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Fixes: df645fa3 ("aco: implement VK_KHR_shader_float_controls") Part-of: <mesa/mesa!7605>
-
Tomeu Vizoso authored
Lab is back online now. This reverts commit 902ac3d7. Signed-off-by:
Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <mesa/mesa!7630>
-
Lionel Landwerlin authored
Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!6172>
-
Erik Faye-Lund authored
MSVC has no idea about these pragmas, and spews warnings about them, making it hard to spot real problems. So let's only use these macros on GCC. Fixes: 2ec290cd ("util: Fix/silence variable shadowing warnings") Reviewed-by:
Tony Wasserka <tony.wasserka@gmx.de> Part-of: <mesa/mesa!7633>
-
Samuel Pitoiset authored
These opcodes are never used and they always write the carry-out according to the GCN3 ISA documentation. Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!7569>
-
Jesse Natalie authored
Fixes: b9c61379 ("microsoft/compiler: translate nir to dxil") Reviewed-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!7609>
-
Tony Wasserka authored
Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!7552>
-
Tony Wasserka authored
Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!7552>
-
Tomeu Vizoso authored
There's a maintenance window of 4 hours to improve the lab infrastructure. Signed-off-by:
Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <mesa/mesa!7629>
-
Tapani Pälli authored
Screen is shared among contexts, other context might be already using vtbl while another initializes it again. ==45872== Possible data race during write of size 8 at 0x5DDAE78 by thread #549 ==45872== Locks held: 1, at address 0x5D1B6F8 ==45872== at 0x6D66D91: gen9_init_state (iris_state.c:7816) ==45872== by 0x6BA0A31: iris_create_context (iris_context.c:342) ==45872== by 0x621F390: st_api_create_context (st_manager.c:917) ==45872== by 0x620E6F9: dri_create_context (dri_context.c:163) ==45872== by 0x6A40DB1: driCreateContextAttribs (dri_util.c:480) ==45872== by 0x540B963: dri2_create_context (egl_dri2.c:1583) ==45872== by 0x53FB84E: eglCreateContext (eglapi.c:821) ==45872== ==45872== This conflicts with a previous read of size 8 by thread #544 ==45872== Locks held: 1, at address 0x5F6E0E0 ==45872== at 0x6CB779E: blorp_alloc_binding_table (iris_blorp.c:167) ==45872== by 0x6CAEF70: blorp_emit_surface_states (blorp_genX_exec.h:1540) ==45872== by 0x6CB67F9: blorp_exec (blorp_genX_exec.h:2016) ==45872== by 0x6CB7AFE: iris_blorp_exec (iris_blorp.c:307) ==45872== by 0x70F5916: try_blorp_blit (blorp_blit.c:2145) ==45872== by 0x70F5FCA: do_blorp_blit (blorp_blit.c:2273) ==45872== by 0x70F778F: blorp_copy (blorp_blit.c:2803) ==45872== by 0x6BB9EB6: iris_copy_region (iris_blit.c:725) v2: move as genX(init_screen_state) (Lionel) Signed-off-by:
Tapani Pälli <tapani.palli@intel.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Part-of: <mesa/mesa!7544>
-
Tapani Pälli authored
All other functions calling _eglLookupImage hold the display lock. ==16659== Possible data race during write of size 8 at 0x5D1BCF0 by thread #2668 ==16659== Locks held: 1, at address 0x5D1B6F8 ==16659== at 0x5405DDF: _eglLinkResource (egldisplay.c:454) ==16659== by 0x53F9189: _eglLinkImage (eglimage.h:138) ==16659== by 0x53FE2CA: _eglCreateImageCommon (eglapi.c:1740) ==16659== by 0x53FE39A: eglCreateImageKHR (eglapi.c:1751) ==16659== ==16659== This conflicts with a previous read of size 8 by thread #2664 ==16659== Locks held: 1, at address 0x5308D00 ==16659== at 0x5405C06: _eglCheckResource (egldisplay.c:387) ==16659== by 0x5408C92: _eglLookupImage (eglimage.h:162) ==16659== by 0x5409E96: dri2_lookup_egl_image (egl_dri2.c:688) ==16659== by 0x6210AAF: dri2_lookup_egl_image (dri_helpers.c:250) ==16659== by 0x6212843: dri_get_egl_image (dri_screen.c:470) ==16659== by 0x625F7CC: st_get_egl_image (st_cb_eglimage.c:152) ==16659== by 0x625FE7D: st_egl_image_target_texture_2d (st_cb_eglimage.c:354) ==16659== by 0x6501C05: egl_image_target_texture (teximage.c:3446) Signed-off-by:
Tapani Pälli <tapani.palli@intel.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Part-of: <mesa/mesa!7544>
-
- Nov 15, 2020
-
-
Erico Nunes authored
In applications using clip planes, set_clip_state is expected to be implemented in the backend. If it is not defined, it may cause the application to segfault. glClipPlane it is not part of GLES 2, so it is not trivial to reverse engineer if something needs to be done in lima. Other drivers just define a placeholder implementation for set_clip_state, so for now let's just define one for lima too. Signed-off-by:
Erico Nunes <nunes.erico@gmail.com> Reviewed-by:
Qiang Yu <yuq825@gmail.com> Part-of: <mesa/mesa!7088>
-
Dave Airlie authored
for atomic exchange floats are valid. Fixes CL CTS test_atomic fails Reviewed-by:
Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!7595>
-
Dave Airlie authored
This lowers the any/all stuff. Fixes unknown opcode in ./relationals/test_relationals Reviewed-by:
Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!7595>
-
Dave Airlie authored
The nir lowering should suffice Reviewed-by:
Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!7595>
-
Dave Airlie authored
This is needed for lowered dot products, this opcode just sums all the vector elements. Reviewed-by:
Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!7595>
-
Dave Airlie authored
Reviewed-by:
Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!7595>
-
Dave Airlie authored
The number of invocations wasn't getting incremented correctly. Fixes: 202bc38c ("draw: collect tessellation invocations statistics") Reviewed-by:
Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!7597>
-
Samuel Pitoiset authored
Against vulkan-cts-1.2.4.1. Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Acked-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!7626>
-
Samuel Pitoiset authored
The list of default skipped tests should also be included. Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Acked-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!7626>
-
Bas Nieuwenhuizen authored
Fixes: 0833dd7d "amd/common: Add support for modifiers." Closes: mesa/mesa#3794 ̀Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!7619>
-
Christian Gmeiner authored
Running the optimizations after bool to float/int lowering is not going to work. Large portions of NIR are likely to blow up if they see floats/ints in weird places. Most of the bool->float/int conversions are direct instruction substitutions and it's not going to leave a lot of garbage around to optimize. Fixes nir.h:261: nir_const_value_as_bool: Assertion `i == 0 || i == -1' failed dEQP-GLES2.functional.shaders.loops.while_constant_iterations.no_iterations_vertex Here are shader-db results for GC2000: instructions HURT: shaders/tesseract/488.shader_test FRAG: 516 -> 524 (1.55%) instructions HURT: shaders/tesseract/491.shader_test FRAG: 248 -> 260 (4.84%) instructions HURT: shaders/tesseract/494.shader_test FRAG: 244 -> 256 (4.92%) instructions HURT: shaders/tesseract/238.shader_test FRAG: 232 -> 244 (5.17%) instructions HURT: shaders/tesseract/241.shader_test FRAG: 232 -> 244 (5.17%) instructions HURT: shaders/tesseract/127.shader_test FRAG: 76 -> 80 (5.26%) instructions HURT: shaders/tesseract/130.shader_test FRAG: 148 -> 156 (5.41%) instructions HURT: shaders/tesseract/226.shader_test FRAG: 192 -> 204 (6.25%) instructions HURT: shaders/tesseract/229.shader_test FRAG: 192 -> 204 (6.25%) instructions HURT: shaders/tesseract/217.shader_test FRAG: 152 -> 164 (7.89%) instructions HURT: shaders/tesseract/214.shader_test FRAG: 152 -> 164 (7.89%) instructions HURT: shaders/tesseract/205.shader_test FRAG: 112 -> 124 (10.71%) instructions HURT: shaders/tesseract/202.shader_test FRAG: 112 -> 124 (10.71%) instructions HURT: shaders/tesseract/169.shader_test FRAG: 32 -> 36 (12.50%) instructions HURT: shaders/tesseract/166.shader_test FRAG: 32 -> 36 (12.50%) instructions HURT: shaders/deqp_gles3/61312.shader_test FRAG: 448 -> 508 (13.39%) instructions HURT: shaders/deqp_gles3/61309.shader_test FRAG: 448 -> 508 (13.39%) instructions HURT: shaders/deqp_gles3/61324.shader_test FRAG: 448 -> 508 (13.39%) instructions HURT: shaders/tesseract/118.shader_test FRAG: 28 -> 32 (14.29%) instructions HURT: shaders/tesseract/181.shader_test FRAG: 52 -> 60 (15.38%) instructions HURT: shaders/tesseract/178.shader_test FRAG: 52 -> 60 (15.38%) instructions HURT: shaders/tesseract/121.shader_test FRAG: 52 -> 60 (15.38%) instructions HURT: shaders/tesseract/193.shader_test FRAG: 72 -> 84 (16.67%) instructions HURT: shaders/tesseract/190.shader_test FRAG: 72 -> 84 (16.67%) total instructions in shared programs: 64220 -> 64572 (0.55%) instructions in affected programs: 4924 -> 5276 (7.15%) helped: 5 HURT: 24 helped stats (abs) min: 4 max: 8 x̄: 5.60 x̃: 4 helped stats (rel) min: 4.35% max: 5.41% x̄: 4.72% x̃: 4.35% HURT stats (abs) min: 4 max: 60 x̄: 15.83 x̃: 12 HURT stats (rel) min: 1.55% max: 16.67% x̄: 10.04% x̃: 10.71% 95% mean confidence interval for instructions value: 5.39 18.89 95% mean confidence interval for instructions %-change: 4.81% 10.18% Instructions are HURT. total temps in shared programs: 2514 -> 2512 (-0.08%) temps in affected programs: 9 -> 7 (-22.22%) helped: 2 HURT: 0 Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Lucas Stach <l.stach@pengutronix.de> Part-of: <mesa/mesa!7624>
-