-
- Downloads
HID: intel-thc: fix CONFIG_HID dependency
In drivers/hid/, most drivers depend on CONFIG_HID, while a couple of the drivers in subdirectories instead depend on CONFIG_HID_SUPPORT and use 'select HID'. With the newly added INTEL_THC_HID, this causes a build warning for a circular dependency: WARNING: unmet direct dependencies detected for HID Depends on [m]: HID_SUPPORT [=y] && INPUT [=m] Selected by [y]: - INTEL_THC_HID [=y] && HID_SUPPORT [=y] && X86_64 [=y] && PCI [=y] && ACPI [=y] WARNING: unmet direct dependencies detected for INPUT_FF_MEMLESS Depends on [m]: INPUT [=m] Selected by [y]: - HID_MICROSOFT [=y] && HID_SUPPORT [=y] && HID [=y] - GREENASIA_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_GREENASIA [=y] - HID_WIIMOTE [=y] && HID_SUPPORT [=y] && HID [=y] && LEDS_CLASS [=y] - ZEROPLUS_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_ZEROPLUS [=y] Selected by [m]: - HID_ACRUX_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_ACRUX [=m] - HID_EMS_FF [=m] && HID_SUPPORT [=y] && HID [=y] - HID_GOOGLE_STADIA_FF [=m] && HID_SUPPORT [=y] && HID [=y] - PANTHERLORD_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_PANTHERLORD [=m] It's better to be consistent and always use 'depends on HID' for HID drivers. The notable exception here is USB_KBD/USB_MOUSE, which are alternative implementations that do not depend on the HID subsystem. Do this by extending the "if HID" section below, which means that a few of the duplicate "depends on HID" and "depends on INPUT" statements can be removed in the process. Fixes: 1b2d0538 ("HID: intel-thc-hid: Add basic THC driver skeleton") Signed-off-by:Arnd Bergmann <arnd@arndb.de> Reviewed-by:
Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Reviewed-by:
Maximilian Luz <luzmaximilian@gmail.com> Reviewed-by:
Even Xu <even.xu@intel.com> Signed-off-by:
Jiri Kosina <jkosina@suse.com>
Showing
- drivers/hid/Kconfig 6 additions, 4 deletionsdrivers/hid/Kconfig
- drivers/hid/amd-sfh-hid/Kconfig 0 additions, 1 deletiondrivers/hid/amd-sfh-hid/Kconfig
- drivers/hid/i2c-hid/Kconfig 1 addition, 1 deletiondrivers/hid/i2c-hid/Kconfig
- drivers/hid/intel-ish-hid/Kconfig 0 additions, 1 deletiondrivers/hid/intel-ish-hid/Kconfig
- drivers/hid/intel-thc-hid/Kconfig 0 additions, 1 deletiondrivers/hid/intel-thc-hid/Kconfig
- drivers/hid/surface-hid/Kconfig 0 additions, 2 deletionsdrivers/hid/surface-hid/Kconfig
- drivers/hid/usbhid/Kconfig 1 addition, 2 deletionsdrivers/hid/usbhid/Kconfig
- net/bluetooth/hidp/Kconfig 1 addition, 2 deletionsnet/bluetooth/hidp/Kconfig
Loading
Please register or sign in to comment