Skip to content
Snippets Groups Projects
Commit a16f8896 authored by Meir Elisha's avatar Meir Elisha Committed by Keith Busch
Browse files

nvmet-tcp: Fix a possible sporadic response drops in weakly ordered arch


The order in which queue->cmd and rcv_state are updated is crucial.
If these assignments are reordered by the compiler, the worker might not
get queued in nvmet_tcp_queue_response(), hanging the IO. to enforce the
the correct reordering, set rcv_state using smp_store_release().

Fixes: bdaf1327 ("nvmet-tcp: fix a segmentation fault during io parsing error")

Signed-off-by: default avatarMeir Elisha <meir.elisha@volumez.com>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent ad95bab0
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment