-
Jens Axboe authored
io_eventfd_do_signal() is invoked from an RCU callback, but when dropping the reference to the io_ev_fd, it calls io_eventfd_free() directly if the refcount drops to zero. This isn't correct, as any potential freeing of the io_ev_fd should be deferred another RCU grace period. Just call io_eventfd_put() rather than open-code the dec-and-test and free, which will correctly defer it another RCU grace period. Fixes: 21a091b9 ("io_uring: signal registered eventfd to process deferred task work") Reported-by:
Jann Horn <jannh@google.com> Cc: stable@vger.kernel.org Tested-by:
Li Zetao <lizetao1@huawei.com> Reviewed-by:
Li <Zetao<lizetao1@huawei.com> Reviewed-by:
Prasanna Kumar T S M <ptsm@linux.microsoft.com> Signed-off-by:
Jens Axboe <axboe@kernel.dk>
Jens Axboe authoredio_eventfd_do_signal() is invoked from an RCU callback, but when dropping the reference to the io_ev_fd, it calls io_eventfd_free() directly if the refcount drops to zero. This isn't correct, as any potential freeing of the io_ev_fd should be deferred another RCU grace period. Just call io_eventfd_put() rather than open-code the dec-and-test and free, which will correctly defer it another RCU grace period. Fixes: 21a091b9 ("io_uring: signal registered eventfd to process deferred task work") Reported-by:
