- Aug 28, 2020
-
-
Dylan Baker authored
-
- Aug 21, 2020
-
-
We were using the wrong conversion opcode. The high bits are also not zero'd on GFX10, which can cause v_cvt_pk_u16_u32 to clamp. Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> Fixes: df645fa3 ('aco: implement VK_KHR_shader_float_controls') Part-of: <mesa/mesa!6346> (cherry picked from commit 9c1e0d86)
-
Section 5.11 (Out-of-Bounds Accesses) of the GLSL 4.60 spec says: "In the subsections described above for array, vector, matrix and structure accesses, any out-of-bounds access produced undefined behavior.... Out-of-bounds writes may be discarded or overwrite other variables of the active program." Fixes crashes when dereferencing gl_ClipDistance and gl_TessLevel*, e.g: int index = -1; gl_ClipDistance[index] = -1; When LowerCombinedClipCullDistance is true. CC: <mesa-stable@lists.freedesktop.org> Signed-off-by:
Danylo Piliaiev <danylo.piliaiev@globallogic.com> Reviewed-by:
Eric Anholt <eric@anholt.net> Reviewed-by:
Marcin Ślusarz <marcin.slusarz@intel.com> Part-of: <!6363> (cherry picked from commit e802bff6)
-
Fixes: 21473865 ("clover/spirv: Add functions for parsing arguments, linking programs, etc.") Signed-off-by:
Pierre Moreau <dev@pmoreau.org> Reviewed-by:
Serge Martin <edb@sigluy.net> Reviewed-by:
Karol Herbst <kherbst@redhat.com> Reviewed-by:
Francisco Jerez <currojerez@riseup.net> Part-of: <!5038> (cherry picked from commit a9ca7373)
-
On glmark2-es2 -bterrain: 594.05KB leaked over 9282 calls from: panfrost_batch_update_bo_access at ../src/gallium/drivers/panfrost/pan_job.c:462 in /home/alyssa/rockchip_dri.so panfrost_batch_add_bo at ../src/gallium/drivers/panfrost/pan_job.c:560 panfrost_batch_add_bo at ../src/gallium/drivers/panfrost/pan_job.c:519 in /home/alyssa/rockchip_dri.so panfrost_batch_add_resource_bos at ../src/gallium/drivers/panfrost/pan_job.c:569 panfrost_batch_add_fbo_bos at ../src/gallium/drivers/panfrost/pan_job.c:588 in /home/alyssa/rockchip_dri.so panfrost_create_batch at ../src/gallium/drivers/panfrost/pan_job.c:126 Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Cc: mesa-stable Reviewed-by:
Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <mesa/mesa!6373> (cherry picked from commit 1cb47f8e)
-
8.74KB leaked over 52 calls from: 0xffffbb5b9fc3 in ?? _mesa_hash_table_init at ../src/util/hash_table.c:163 in /home/alyssa/rockchip_dri.so _mesa_hash_table_create at ../src/util/hash_table.c:186 _mesa_hash_table_u64_create at ../src/util/hash_table.c:701 in /home/alyssa/rockchip_dri.so panfrost_nir_assign_sysvals at ../src/panfrost/util/pan_sysval.c:130 in /home/alyssa/rockchip_dri.so midgard_compile_shader_nir at ../src/panfrost/midgard/midgard_compile.c:2905 in /home/alyssa/rockchip_dri.so Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Cc: mesa-stable Reviewed-by:
Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <mesa/mesa!6373> (cherry picked from commit 680fb05f)
-
Before we drop the reference. 160 calls with 0B peak consumption from: 0xffffbd9d2fc3 in ?? pan_compute_liveness at ../src/panfrost/util/pan_liveness.c:127 in /home/alyssa/rockchip_dri.so mir_compute_liveness at ../src/panfrost/midgard/midgard_liveness.c:55 in /home/alyssa/rockchip_dri.so midgard_opt_dead_code_eliminate at ../src/panfrost/midgard/midgard_opt_dce.c:118 in /home/alyssa/rockchip_dri.so Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Cc: mesa-stable Reviewed-by:
Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <!6373> (cherry picked from commit 8dd38e5a)
-
No need to put it on the context, we can keep it local in mir_squeeze and drop when we're done. 15.77KB leaked over 85 calls from: 0xffffaed3bfc3 in ?? _mesa_hash_table_rehash at ../src/util/hash_table.c:368 in /home/alyssa/rockchip_dri.so hash_table_insert at ../src/util/hash_table.c:403 in /home/alyssa/rockchip_dri.so find_or_allocate_temp at ../src/panfrost/midgard/mir_squeeze.c:48 in /home/alyssa/rockchip_dri.so find_or_allocate_temp at ../src/panfrost/midgard/mir_squeeze.c:35 in /home/alyssa/rockchip_dri.so mir_squeeze_index at ../src/panfrost/midgard/mir_squeeze.c:76 Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Cc: mesa-stable Reviewed-by:
Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <mesa/mesa!6373> (cherry picked from commit 62637a91)
-
After we compile from NIR to a native binary, we can throw away the NIR. 17.47KB leaked over 104 calls from: 0xffff87dcafc3 in ?? _mesa_hash_table_init at ../src/util/hash_table.c:163 in /home/alyssa/rockchip_dri.so _mesa_hash_table_create at ../src/util/hash_table.c:186 nir_lower_vars_to_ssa_impl at ../src/compiler/nir/nir_lower_vars_to_ssa.c:717 in /home/alyssa/rockchip_dri.so nir_lower_vars_to_ssa at ../src/compiler/nir/nir_lower_vars_to_ssa.c:817 optimise_nir at ../src/panfrost/midgard/midgard_compile.c:504 in /home/alyssa/rockchip_dri.so midgard_compile_shader_nir at ../src/panfrost/midgard/midgard_compile.c:2895 in /home/alyssa/rockchip_dri.so panfrost_build_blit_shader at ../src/panfrost/lib/pan_blit.c:103 in /home/alyssa/rockchip_dri.so Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Cc: mesa-stable Reviewed-by:
Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <!6373> (cherry picked from commit da6d0e3f)
-
Fixes heaptrack leak: 19.37KB leaked over 63 calls from: 0xffff92bbefc3 in ?? nir_alu_instr_create at ../src/compiler/nir/nir.c:442 in /home/alyssa/rockchip_dri.so clone_alu at ../src/compiler/nir/nir_clone.c:277 in /home/alyssa/rockchip_dri.so clone_instr at ../src/compiler/nir/nir_clone.c:495 in /home/alyssa/rockchip_dri.so clone_block at ../src/compiler/nir/nir_clone.c:544 clone_cf_list at ../src/compiler/nir/nir_clone.c:594 clone_function_impl at ../src/compiler/nir/nir_clone.c:672 in /home/alyssa/rockchip_dri.so nir_shader_clone at ../src/compiler/nir/nir_clone.c:744 in /home/alyssa/rockchip_dri.so panfrost_shader_compile at ../src/gallium/drivers/panfrost/pan_assemble.c:154 in /home/alyssa/rockchip_dri.so Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Cc: mesa-stable Reviewed-by:
Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <mesa/mesa!6373> (cherry picked from commit 9146f596)
-
Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Fixes: 375d4c2c ("panfrost: Extend blending to MRT") Reviewed-by:
Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <mesa/mesa!6373> (cherry picked from commit ba4fc678)
-
v2: move assignment under existing check (Nanley) Fixes: b9a05447 ("anv: dynamic vertex input binding stride and size support") Signed-off-by:
Tapani Pälli <tapani.palli@intel.com> Reviewed-by:
Nanley Chery <nanley.g.chery@intel.com> Part-of: <mesa/mesa!6369> (cherry picked from commit 709dffa8)
-
Fixes: 20d0ae46 ("nv50/ir: implement global atomics and handle it for nir") Signed-off-by:
Karol Herbst <kherbst@redhat.com> Reviewed-by:
Pierre Moreau <dev@pmoreau.org> Part-of: <mesa/mesa!6367> (cherry picked from commit b283fb33)
-
The *2 here would bump into the *2 in regset, causing assertion failures dumping CS programs. Just set the mergedregs flag on a6xx, and don't duplicate the mergedregs logic. If you're dealing with new HW where we don't know if mergedregs is set, you may need to tweak the flag during disasm setup for the stats to make sense. Fixes: f7bd3456 ("freedreno: deduplicate a3xx+ disasm") Part-of: <!6323> (cherry picked from commit a27823ef)
-
We need to emit epilogue after each tile, not just after the last tile. Fixes: 13fc03f4 ("freedreno/a6xx: Avoid stalling for occlusion queries") Signed-off-by:
Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!6376> (cherry picked from commit 7e3a788b)
-
Cc: 20.2 <mesa-stable> Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Acked-by:
Michel Dänzer <mdaenzer@redhat.com> Part-of: <!6132> (cherry picked from commit eae181e3)
-
Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by:
Tomeu Vizoso <tomeu.vizoso@collabora.com> Fixes: 92c808cd ("pan/mdg: eliminate references to ins->texture.op") Part-of: <mesa/mesa!6321> (cherry picked from commit 06c31031)
-
Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by:
Tomeu Vizoso <tomeu.vizoso@collabora.com> Fixes: dce7722e ("panfrost: Handle writes_memory correctly") Part-of: <mesa/mesa!6321> (cherry picked from commit 39bf1fb3)
-
During build on Android 10, build error occurred: ''' [ 26% 456/1718] Gen Header: libfreedreno_registers_32 <= a3xx.xml.h FAILED: out/target/product/pinephone/gen/STATIC_LIBRARIES/libfreedreno_registers_intermediates/registers/adreno/a3xx.xml.h /bin/bash -c "PATH=/usr/bin:\$PATH python3 external/mesa3d/src/freedreno/registers/gen_header.py external/mesa3d/src/freedreno/registers/adreno/a3xx.xml > out/target/product/pinephone/gen/STATIC_LIBRARIES/libfreedreno_registers_intermediates/registers/adreno/a3xx.xml.h" Traceback (most recent call last): File "external/mesa3d/src/freedreno/registers/gen_header.py", line 470, in <module> main() File "external/mesa3d/src/freedreno/registers/gen_header.py", line 446, in main xml_file = sys.argv[2] IndexError: list index out of range ''' Align build rules with meson fixes it. Fixes: 62ebd342 ("freedreno/registers: split header build into subdirs") Signed-off-by:
Roman Stratiienko <r.stratiienko@gmail.com> Acked-by:
Rob Clark <robdclark@gmail.com> Acked-by:
Tapani Pälli <tapani.palli@intel.com> Part-of: <!6170> (cherry picked from commit 8626d4cb)
-
This was updating the wrong counters. Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Fixes: a6f6ca37 ("llvmpipe: add initial shader create/bind/destroy variants framework.") Part-of: <mesa/mesa!6339> (cherry picked from commit e137bbb8)
-
Anything that fails the is_external_block check is getting the vtn_local_load/store path which does read-modify-write which isn't correct if the variable mode can be written cross-workgroup. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Jesse Natalie <jenatali@microsoft.com> Part-of: <!6372> (cherry picked from commit b479de85)
-
We really need to update the enum for consistency, but that involves a bunch of GL & bitfield work which is error-prone, so since this is a fix for stable lets do the simple things. Confirmed that nothing in radv/aco/nir/spirv uses MAX_VERT_ATTRIB except the one thing I bumped. CC: mesa-stable Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!6120> (cherry picked from commit f038b3a1)
-
Game does the equivalent of a ALIGN(..., minUniformBufferOffsetAlignment >> 4) which breaks when said alignment is <16 with a SIGFPE. CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <!6120> (cherry picked from commit 0067f899)
-
This adds applicationName + version through like engineName. Rationale: A game (World War Z) includes the store name in the executable name, so has multiple executable names. CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <!6120> (cherry picked from commit a1d4721e)
-
This passes conformance on both the master and 4.6.0 (with patches) branches. I'll be submitting results shortly from the 20.2.x branch this lands in. Cc: "20.2" <mesa-stable@lists.freedesktop.org> Reviewed-by:
Roland Scheidegger <sroland@vmware.com> Part-of: <!6044> (cherry picked from commit f9e773b9)
-
Dylan Baker authored
-
- Aug 18, 2020
-
-
OpCopyMemory doesn't care about mismatched decorations, only about matching types. Closes: mesa/mesa#3418 Fixes: bf1a1eed Signed-off-by:
Danylo Piliaiev <danylo.piliaiev@globallogic.com> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!6344> (cherry picked from commit b6ebf6eb)
-
The round-to-nearest-even implementation found in lower_2f() is incorrect for any value having a significand that is not directly representable and whose non-representable part lies between 1 and half the minimum representable value. In this case, the significand is rounded up instead of being rounded down. Fixes: 936c58c8 ("nir: Extend nir_lower_int64() to support i2f/f2i lowering") Signed-off-by:
Boris Brezillon <boris.brezillon@collabora.com> Tested-by:
Jesse Natalie <jenatali@microsoft.com> Acked-by:
Matt Turner <mattst88@gmail.com> Part-of: <mesa/mesa!6290> (cherry picked from commit 199bea0f)
-
Don't have the shader do a 32-bit unorn to float conversion, the values don't remain accurate then. Fixes: GTF-GL45.gtf30.GL3Tests.framebuffer_blit.framebuffer_blit_functionality_multisampled_to_singlesampled_blit for 32-bit unorm depth buffers. Cc: "20.2" <mesa-stable@lists.freedesktop.org> Reviewed-by:
Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!6044> (cherry picked from commit 2e40b2c1)
-
It isn't clear to me why, but this breaks in some cases (such as some dEQP cases where the blob does a translate too). This reverts commit 9f2997da. Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Cc: mesa-stable Reviewed-by:
Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <!6326> (cherry picked from commit e03622e5)
-
Having a single init function works as expected for shared llvm, but when using a static llvm only one llvm will get initialized. This commit introduces 2 separate init function: - shared llvm = single public init function - static llvm = one init function for each module using llvm Fixes: 50d20dc0 ("ac/llvm: export ac_init_llvm_once in targets") Closes: #3376 Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <!6253> (cherry picked from commit b7c04b17)
-
Oops ... Fixes: 64768111 "radv: Handle slightly different image dimensions." Closes: mesa/mesa#3417 Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!6337> (cherry picked from commit 50b03959)
-
KHR-GL45.robust_buffer_access_behavior.vertex_buffer_objects on the CTS 4.6.0 branch and this fixes it. Roland identified that if the vertex format doesn't contain channels then we shouldn't be overriding them to 0, so RGB fetch out of bounds should return 0 for RGB, but the A channel should still be getting back 1. Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!6287> (cherry picked from commit 430e3310)
-
This is a left over from the earlier version of VK_KHR_performance_query where we used kernel relocs to implement multi passe queries. We're using self modifying batches now so we shouldn't need any relocation. Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 2001a80d ("anv: Implement VK_KHR_performance_query") Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!6291> (cherry picked from commit 031f9e17)
-
When importing a DMA-BUF, the image layout created in vkImageCreate may not match the imported BO's. To make this work we redo the layout based on the metadata of the imported image. The original patch did a delayed allocation just as for AHB, but that does not work for images that are not imported (but e.g. exported only). Original patch by Simon Ser <contact@emersion.fr> Closes: mesa/mesa#2801 CC: mesa-stable Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!6274> (cherry picked from commit d19bc94e)
-
Fixes: d0d14f3f ("util: Add unit test for stack backtrace caputure") Reviewed-by:
Kristian H. Kristensen <hoegsberg@google.com> Part-of: <mesa/mesa!6303> (cherry picked from commit 58af3118)
-
Calling SET_TILING on a DMA buffer with the gen12 CCS modifier can fail unnecessarily. The main surface in the BO is Y-tiled, but the CCS portion is linear and can have a stride that's not a multiple of 128B. Because SET_TILING is called on the CCS plane with I915_TILING_Y, the ioctl will sometimes reject the stride. SET_TILING was originally used in b6d45e7f to fix an assertion failure in iris_resource_from_handle. Assigning the BO's tiling_mode field is sufficient to avoid the failure. Fixes: c19492bc ("iris: Handle importing aux-enabled surfaces on TGL") Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!6296> (cherry picked from commit c111e909)
-
This change fixes off-by-one results in corner cases such as 0xffffffff / 0x11111111. For details refer to LLVM bug 46212. Fixes: 8b98d095 ('nir/lower_idiv: add new llvm-based path') Reviewed-by:
Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!6281> (cherry picked from commit 8277334f)
-
Fixes: a23802bc - ac,radeonsi: start adding support for gfx10.3 Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!6282> (cherry picked from commit 2b78cb2e)
-
Dylan Baker authored
-