Skip to content
Snippets Groups Projects
Commit 1592f535 authored by Sebastian Dröge's avatar Sebastian Dröge :tea:
Browse files

typefind: Only push a CAPS event downstream if the sinkpad is not in PULL mode

The other signal handlers of the type-found signal might have reactivated
typefind in PULL mode already, pushing a CAPS event at that point would cause
deadlocks and is in general unexpected by elements that are in PULL mode.

https://bugzilla.gnome.org/show_bug.cgi?id=765906
parent 7eb49425
No related branches found
No related tags found
No related merge requests found
......@@ -179,6 +179,10 @@ gst_type_find_element_have_type (GstTypeFindElement * typefind,
GST_INFO_OBJECT (typefind, "found caps %" GST_PTR_FORMAT ", probability=%u",
caps, probability);
/* Do nothing if downstream is pulling from us */
if (GST_PAD_MODE (typefind->src) == GST_PAD_MODE_PULL)
return;
GST_OBJECT_LOCK (typefind);
/* Now actually send the CAPS event downstream.
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment