Since VkRunner commit 6b1d2f51efad6, there are now alternative names
for the commands for setting push constants and UBO data. These names
are a bit less confusing so this patch converts all of the VkRunner
test scripts to use them.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>

Jan Vesely authored 5 years ago and Jan Vesely committed 5 years ago

Signed-off-by: Jan Vesely <jano.vesely@gmail.com>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>

Adds Test class destructor, that releases memory allocated for test
pattern and manifest program.
Also frees memory allocated for test object itself.

Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>

Signed-off-by: Marek Olšák <marek.olsak@amd.com>

These tests preinit the ssbo contents but expect the driver to be doing
std430 packing by default, just specify std430 packing.

Edits done by:

grep -lr ' buffer ' tests/spec/intel_shader_atomic_float_minmax/execution |\
    while read f; do
        sed --in-place -e 's/layout(binding = 0) buffer/layout(binding = 0, std430) buffer/' $f
    done

Reviewed-by: Dave Airlie <airlied@redhat.com>

These tests preinit the ssbo contents but expect the driver to
be doing std430 packing by default, just specify std430 packing.

Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>

Jan Vesely authored 5 years ago and Jan Vesely committed 5 years ago

Signed-off-by: Jan Vesely <jano.vesely@gmail.com>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>

Reviewed-by: Dylan Baker <dylan@pnwbakers.com>

This was the smallest test case that I could make that would reproduce
the bug, generate actual instructions (instead of constant folding to
nothing), and be small enough to run on any GPU supported by Mesa that
has GLES 2.0 (i.e., i915).

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110953


Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>

The "variant 1" subtest uses glBlendFunc(GL_DST_ALPHA, ...) so we must initialize
the dst texture or we might get inconsistent results.

This fixes random failures on radeonsi hardware.

Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>

Free memory allocated for random image.

Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>

PIGLIT_SPIRV_VALIDATE enables the feature, PIGLIT_SPIRV_VAL_BINARY let
the user specify which "spirv-val" to use.  For now, validate against
opengl4.5 target environment.

Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>

In the future we should consider decide this based on the shader_test
requirements.  For now allow us to generate SPIR-V binary in the
expected version -- useful for adding validation later.

Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>

Memory, allocated in glXGetFBConfigs, has to be freed manually.

Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>

Sergii Romantsov authored 5 years ago and Lionel Landwerlin committed 5 years ago

Test uses asprintf which allocates memory, but not freed it

Fixes: f62e74f6(ARB_texture_gather: add initial execution test)

Signed-off-by: Sergii Romantsov <sergii.romantsov@globallogic.com>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>

Free memory, allocated by asprintf.

Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>

test_copy checks if the outcome of glMapBuffer is the same that some
expected data. But we found that for drivers failing on returnign the
proper data, it is possible/likely that glMapBuffer would just return
NULL. So it would be better to check for NULL to avoid a crash, as
technically the driver is not crashing, but the test (even if the
reason glMapBuffer still needs to be investigated).

Reviewed-by: Tapani Pälli <tapani.palli@intel.com>

Yevhenii Kolesnikov authored 5 years ago and Tapani Pälli committed 5 years ago

Memory has been  allocated but never freed, which  causes memory leaks
in a number of tests:

arb_point_sprite-mipmap
glsl-fs-bug25902
glsl-fs-sampler-numbering
tex-border-1
gl-2.0-link-empty-prog
arb_point_sprite-checkerboard

Fixes: 3def81d0 (Unify piglit_checkerboard_texture between GL and GLES)
Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>

Memory isn't properly freed, which causes significant memory leaks.

Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>

Free memory, allocated for fs_src and img_data.
Fixes memory leaks in arb_copy_image-formats and
arb_copy_image-targets tests.

Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>

The ranges-2 test was failing due to glTexBufferRange returning GL_INVALID_VALUE
when the offset parameter wasn't GL_TEXTURE_BUFFER_OFFSET_ALIGNMENT byte aligned.

From the OpenGL 4.6 Core spec:

An INVALID_VALUE error is generated if offset is not an integer multiple of the
value of TEXTURE_BUFFER_OFFSET_ALIGNMENT.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>

Memory is being allocated by asprintf, but never freed.

Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>

draw-prim-rate.c:415:3: error: initializer element is not a compile-time constant
                ceil(sqrt(0.5 * 1000)),
                ^~~~~~~~~~~~~~~~~~~~~~

Fixes: 6e1bb1e7 ("Add a test that measures primitive rate")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>

The output looks like this (from the initial version, the current version is slightly different):
  Measuring GPrims/second,             , Number of primitives
  Draw Call     ,  Cull Method         ,    2K,    4K,    8K,   16K,   32K,   64K,  256K
  --------------,----------------------,------,------,------,------,------,------,------
  glDrawElements, none                 ,  2.80,  2.69,  2.91,  2.89,  2.91,  2.92,  2.42
  glDrawElements, rasterizer discard   ,  4.80,  4.77,  4.95,  4.84,  4.91,  4.85,  4.93
  glDrawElements, 100% back faces      ,  3.27,  3.19,  3.29,  3.21,  3.26,  3.32,  3.33
  glDrawElements,  75% back faces      ,  3.27,  3.47,  3.29,  3.54,  3.53,  3.60,  3.49
  glDrawElements,  50% back faces      ,  3.92,  3.83,  3.34,  3.58,  3.68,  3.63,  2.76
  glDrawElements,  25% back faces      ,  3.66,  3.52,  3.12,  3.18,  3.00,  2.78,  3.45
  glDrawElements, 100% culled by view  ,  4.85,  4.75,  4.94,  4.68,  4.91,  4.80,  4.94
  glDrawElements,  75% culled by view  ,  4.82,  4.68,  4.77,  4.76,  4.80,  4.65,  3.20
  glDrawElements,  50% culled by view  ,  4.73,  4.65,  4.46,  3.40,  4.86,  4.04,  2.99
  glDrawElements,  25% culled by view  ,  3.67,  3.48,  3.26,  2.70,  2.76,  2.60,  2.46
  glDrawElements, 100% degenerate prims,  1.67,  1.66,  1.68,  1.66,  1.68,  1.68,  1.68
  glDrawElements,  75% degenerate prims,  1.65,  1.90,  1.67,  1.96,  1.86,  2.01,  1.83
  glDrawElements,  50% degenerate prims,  2.43,  2.37,  1.66,  2.44,  1.90,  2.24,  1.98
  glDrawElements,  25% degenerate prims,  2.49,  2.94,  1.67,  2.03,  2.76,  2.79,  2.15
  glDrawElements, 98 small prims/pixel ,  4.82,  4.65,  4.85,  4.80,  4.90,  4.77,  4.30
  glDrawElements, 32 small prims/pixel ,  4.86,  4.71,  4.80,  4.69,  4.81,  4.16,  4.95
  glDrawElements,  8 small prims/pixel ,  4.73,  4.67,  4.92,  4.85,  4.91,  4.86,  3.20
  glDrawArrays  , none                 ,  1.67,  1.66,  1.65,  1.47,  1.52,  1.24,  1.60
etc.

trivial

For some reason, the last element is uninitialized if I don't clear
the structure like this.

Usage test 'depthstencil-render-miplevels 200 s=z24_s8' causes
memory leaks.
Fixed: memory allocation/deallocation is controlled more carefully.

CC: Eric Anholt <eric@anholt.net>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108819
Issue: mesa/piglit#9


Fixes: 7a0e61d7 (depthstencil-render-miplevels: Present the results in non-auto mode.)
Signed-off-by: Sergii Romantsov <sergii.romantsov@globallogic.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>

Usage test 'depthstencil-render-miplevels 200 s=z24_s8' causes
core dump on exit.
Fixed: array of pointers is allocated to size max_miplevel, but
used as max_miplevel + 1.

CC: Eric Anholt <eric@anholt.net>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108819
Issue: mesa/piglit#9


Fixes: 7a0e61d7 (depthstencil-render-miplevels: Present the results in non-auto mode.)
Signed-off-by: Sergii Romantsov <sergii.romantsov@globallogic.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>

Piglit tests based on dma-buf may not finish properly
due to wrongly selected rendernode.
Patch adds possibility to override device by variable
WAFFLE_GBM_DEVICE (in format /dev/dri/renderD128).

-v2: added WAFFLE_GBM_DEVICE (Marek Olšák)

CC: Chad Versace <chad.versace@intel.com>
Fixes: 8147ec81 (util/dma_buf: Use rendernode if available)
Fixes: mesa/piglit#15


Signed-off-by: Sergii Romantsov <sergii.romantsov@globallogic.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>

Memory is being allocated by asprintf, but it is never freed.

Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>

Big chunk of memory is allocated, but not freed.

Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>

The i965 driver's surface layout component (ISL) can calculate the
location of miplevels incorrectly when the surface is compressed. Set
the width to 257px to demonstrate this issue.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>

- We have to use the linear layout, otherwise the offsets can't be modified.
- The GBM image has only 1 plane, so the gbm functions can't be used
  for other planes.
- Don't manipulate with the stride. It has to be the same.

This reverts commit c878a27d.

pushed by accident

Reviewed-by: Dave Airlie <airlied@redhat.com>