- Jul 19, 2013
-
-
Aleksander Morgado authored
-
Aleksander Morgado authored
-
Aleksander Morgado authored
-
Aleksander Morgado authored
-
- Jul 18, 2013
-
-
Aleksander Morgado authored
-
Aleksander Morgado authored
-
- Jul 17, 2013
-
-
Aleksander Morgado authored
When we're exposing not-yet-completed multipart messages, we need to provide a correct value for the validity property, or gdbus may crash, see e.g.: https://bugzilla.gnome.org/show_bug.cgi?id=704319
-
- Jul 15, 2013
-
-
Aleksander Morgado authored
-
With a non-zero send delay, the communication over the ttyACM port of the modem is not very stable when USB auto-suspend is enabled for the modem. The send delay is not necessary and thus removed by this patch. Ori Inbar <ori.inbar@altair-semi.com> reported the issue and suggested this fix.
-
- Jul 14, 2013
-
-
Aleksander Morgado authored
-
Aleksander Morgado authored
-
- Jul 12, 2013
-
-
Aleksander Morgado authored
-
- Jul 11, 2013
-
-
Dan Williams authored
plugins/Makefile.am:375: warning: EXTRA_DIST multiply defined in condition TRUE ... gtester.make:6: ... 'EXTRA_DIST' previously defined here plugins/Makefile.am:1: 'gtester.make' included from here
-
Aleksander Morgado authored
Patch based on changes from Franko Fang <fangxiaozhi@huawei.com>.
-
Aleksander Morgado authored
-
Ben Chan authored
This patch fixes the following incorrect conversions from double to gint32: mm-broadband-modem-qmi.c:4785:27: error: implicit conversion from 'double' to 'gint32' (aka 'int') changes value from 2.225073858507201E-308 to 0 [-Werror,-Wliteral-conversion] gint32 bs_longitude = MM_LOCATION_LONGITUDE_UNKNOWN; ~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ mm-broadband-modem-qmi.c:4786:26: error: implicit conversion from 'double' to 'gint32' (aka 'int') changes value from 2.225073858507201E-308 to 0 [-Werror,-Wliteral-conversion] gint32 bs_latitude = MM_LOCATION_LATITUDE_UNKNOWN; ~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
-
Ben Chan authored
This patch fixes the following enumeration type mismatches: mm-modem-helpers-qmi.c:980:12: error: implicit conversion from enumeration type 'QmiNasRatModePreference' to different enumeration type 'QmiNasRadioTechnologyPreference' [-Werror,-Wenum-conversion] return qmi; ~~~~~~ ^~~ mm-modem-helpers-qmi.c:1082:12: error: implicit conversion from enumeration type 'MMModemMode' to different enumeration type 'QmiNasGsmWcdmaAcquisitionOrderPreference' [-Werror,-Wenum-conversion] return MM_MODEM_MODE_NONE; ~~~~~~ ^~~~~~~~~~~~~~~~~~ mm-modem-helpers-qmi.c:1096:16: error: implicit conversion from enumeration type 'QmiNasRegistrationState' to different enumeration type 'MMModem3gppRegistrationState' [-Werror,-Wenum-conversion] return QMI_NAS_REGISTRATION_STATE_NOT_REGISTERED; ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-
- Jul 10, 2013
-
-
Dan Williams authored
-
- Jul 08, 2013
-
-
Aleksander Morgado authored
-
Ben Chan authored
Prints out a warning if ioctl(TIOCSSERIAL) fails to set closing_wait to none. This helps debug issues when a serial driver does not support or properly handle closing_wait, which may cause closing of the serial port to block.
-
- Jul 04, 2013
-
-
Ben Chan authored
Being able to determine the current power state of the modem is necessary to ensure reliable modem operations.
-
- Jun 28, 2013
-
-
Ben Chan authored
This patch fixes a potential crash when MMIfaceModem::load_current_bands_ready() dereferences a NULL GError pointer, which happens when the altair-lte plugin fails to load the current bands but does not propagate the error. It also fixes a similar issue with the plugin fails to load the supported bands, even though MMIfaceModem::load_supported_bands_ready() checks for a NULL GError pointer.
-
Ben Chan authored
This patch fixes the following crash when MMIfaceModem::load_current_bands_ready() dereferences a NULL GError pointer, which happens when the novatel-lte plugin fails to load the current bands but does not propagate the error. Thread 0 *CRASHED* ( SIGSEGV @ 0x00000000 ) 0x7f04d6c89c36 [ModemManager] - mm-iface-modem.c:3886 load_current_bands_ready 0x7f04d6942236 [libgio-2.0.so.0.3200.4] - gsimpleasyncresult.c:767 g_simple_async_result_complete 0x7f04d6942338 [libgio-2.0.so.0.3200.4] - gsimpleasyncresult.c:779 complete_in_idle_cb 0x7f04d67fad74 [libglib-2.0.so.0.3200.4] - gmain.c:2539 g_main_context_dispatch 0x7f04d67fb0f7 [libglib-2.0.so.0.3200.4] - gmain.c:3146 g_main_context_iterate 0x7f04d67fb551 [libglib-2.0.so.0.3200.4] - gmain.c:3340 g_main_loop_run 0x7f04d6c68795 [ModemManager] - main.c:142] main 0x7f04d6213464 [libc-2.15.so] - libc-start.c:234] __libc_start_main 0x7f04d6c68318 [ModemManager] + 0x0001d318]
-
- Jun 27, 2013
-
-
Aleksander Morgado authored
-
Ben Chan authored
This patch prevents an ATZ command, which causes the modem to reboot, from being sent to the modem when the modem is being enabled.
-
- Jun 26, 2013
-
-
Aleksander Morgado authored
Icera-based Nokia modems may reply correctly to the Icera probing only in some AT ports, not in all. In order to handle this situation we override the final plugin selected to be the Icera-based one if we find that the mismatched plugins have the 'icera-allowed' and 'icera-forbidden' filters. https://bugzilla.gnome.org/show_bug.cgi?id=703022
-
-
- Jun 25, 2013
-
-
-
Aleksander Morgado authored
-
Aleksander Morgado authored
-
Dan Williams authored
The modem doesn't give us a prefix in the OWANDATA response, but it's always /32. This didn't get set previously because NetworkManager always just used /32 for the 'static' configuration, but NM isn't the only user of MM, and only MM knows for sure that the prefix should be /32.
-
- Jun 24, 2013
-
-
Aleksander Morgado authored
We will expose a new 'Ports' property listing all ports currently known by a given modem. Ports which are not used but are detected as being part of the modem will be listed with an 'unknown' port type. This change uses the new 'MMModemPortType' enum and the new 'MMModemPortInfo' helper struct to handle these values in libmm-glib. The already available 'MMPortType' enum hasn't been re-used for the interface because it contains values that we don't need (e.g. IGNORED). The port list is now also included in the modem information command of mmcli: $ sudo mmcli -m 0 /org/freedesktop/ModemManager1/Modem/0 (device id '97b7b99e3e2bea103880545b619fb05a3cc81b26') ------------------------- System | device: '/sys/devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.4' | drivers: 'qcserial, qmi_wwan' | plugin: 'Gobi' | primary port: 'cdc-wdm0' | ports: 'ttyUSB0 (qcdm), ttyUSB1 (at), cdc-wdm0 (qmi), wwp0s29u1u4 (net)' https://bugzilla.gnome.org/show_bug.cgi?id=702678
-
Aleksander Morgado authored
Option/HSO modems don't seem to support IPv6 when using the net interface. So if IPv6 is requested, create a generic bearer. $ sudo mmcli -m 0 --simple-connect="apn=internet,ip-type=ipv6" successfully connected the modem $ sudo mmcli -b 0 Bearer '/org/freedesktop/ModemManager1/Bearer/0' ------------------------- Status | connected: 'yes' | suspended: 'no' | interface: 'ttyHS3' | IP timeout: '20' ------------------------- Properties | apn: 'internet' | roaming: 'allowed' | IP type: 'ipv6' | user: 'none' | password: 'none' | number: 'none' | Rm protocol: 'unknown' ------------------------- IPv4 configuration | method: 'ppp' ------------------------- IPv6 configuration | method: 'unknown' $ sudo mmcli -m 0 --simple-disconnect successfully disconnected all bearers in the modem https://bugzilla.gnome.org/show_bug.cgi?id=702472
-
Aleksander Morgado authored
The real power state value of the modem may be changed by other means, e.g. rfkill. So when changing power state of the modem in MM, we better recheck which the current power status is. A better full approach would be to follow rfkill changes, but this fix should help until that is done. https://bugzilla.gnome.org/show_bug.cgi?id=702838
-
Aleksander Morgado authored
-
Aleksander Morgado authored
-
Aleksander Morgado authored
-
Aleksander Morgado authored
My Huawei MBIM modem notifies of standard new messages using MBIM_CID_MESSAGE_STORE_STATUS notifications, which is kind of wrong, as they should really be notified using MBIM_SMS_READ notifications; but anyway, try to handle those.
-
Aleksander Morgado authored
-
Aleksander Morgado authored
We'll add 'enable_flags' later on.
-