Skip to content
Snippets Groups Projects
  • Stefan Hajnoczi's avatar
    23c983c8
    block: remove outdated AioContext locking comments · 23c983c8
    Stefan Hajnoczi authored
    
    The AioContext lock no longer exists.
    
    There is one noteworthy change:
    
      - * More specifically, these functions use BDRV_POLL_WHILE(bs), which
      - * requires the caller to be either in the main thread and hold
      - * the BlockdriverState (bs) AioContext lock, or directly in the
      - * home thread that runs the bs AioContext. Calling them from
      - * another thread in another AioContext would cause deadlocks.
      + * More specifically, these functions use BDRV_POLL_WHILE(bs), which requires
      + * the caller to be either in the main thread or directly in the home thread
      + * that runs the bs AioContext. Calling them from another thread in another
      + * AioContext would cause deadlocks.
    
    I am not sure whether deadlocks are still possible. Maybe they have just
    moved to the fine-grained locks that have replaced the AioContext. Since
    I am not sure if the deadlocks are gone, I have kept the substance
    unchanged and just removed mention of the AioContext.
    
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Message-ID: <20231205182011.1976568-15-stefanha@redhat.com>
    Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    23c983c8
    History
    block: remove outdated AioContext locking comments
    Stefan Hajnoczi authored
    
    The AioContext lock no longer exists.
    
    There is one noteworthy change:
    
      - * More specifically, these functions use BDRV_POLL_WHILE(bs), which
      - * requires the caller to be either in the main thread and hold
      - * the BlockdriverState (bs) AioContext lock, or directly in the
      - * home thread that runs the bs AioContext. Calling them from
      - * another thread in another AioContext would cause deadlocks.
      + * More specifically, these functions use BDRV_POLL_WHILE(bs), which requires
      + * the caller to be either in the main thread or directly in the home thread
      + * that runs the bs AioContext. Calling them from another thread in another
      + * AioContext would cause deadlocks.
    
    I am not sure whether deadlocks are still possible. Maybe they have just
    moved to the fine-grained locks that have replaced the AioContext. Since
    I am not sure if the deadlocks are gone, I have kept the substance
    unchanged and just removed mention of the AioContext.
    
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Message-ID: <20231205182011.1976568-15-stefanha@redhat.com>
    Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>