- May 02, 2018
-
-
Zeeshan Ali authored
-
Zeeshan Ali authored
Lines shouldn't exceed 80 chars.
-
Bastien Nocera authored
To avoid applications being denied access to location services when gnome-shell hasn't had a chance to register its agent, either because Geoclue got auto-started by the application, or because the shell hasn't finished starting up, delay the authorization check until either an agent appears, or 5 seconds after the application requested the authorization. https://bugs.freedesktop.org/show_bug.cgi?id=106236
-
Bastien Nocera authored
And refuse to serve applications that have different values for both. This makes it easier to detect applications which would lie about their IDs when run outside Flatpak, as well as making sure that settings are shared for Flatpak'ed and non-Flatpak'ed versions of the application. https://bugs.freedesktop.org/show_bug.cgi?id=97776
-
Bastien Nocera authored
For newer (>= 0.6.10) versions of Flatpak, the way to export the desktop ID has changed from requiring cgroups to not requiring it. See https://github.com/flatpak/flatpak/releases/tag/0.6.10 This changes the private gclue_client_info_get_xdg_id() API to return a NULL xdg_id should the code fail to read the Flatpak ID for a Flatpak'ed application, and consider it to be disqualifying: " Like parse_app_info_from_fileinfo(), returns NULL on failure, "" (an empty string) if not sandboxed, and a desktop ID otherwise " https://bugs.freedesktop.org/show_bug.cgi?id=97776
-
Bastien Nocera authored
Separate the authorization checks that happen after the agent availability is checked, to make it possible to delay that portion. https://bugs.freedesktop.org/show_bug.cgi?id=106236
-
Bastien Nocera authored
geoclue/src/gclue-service-client.c: In function ‘gclue_service_client_handle_start’: geoclue/src/gclue-service-client.c:574:22: warning: assignment to ‘GClueServiceClient *’ {aka ‘struct _GClueServiceClient *’} from incompatible pointer type ‘GClueDBusClient *’ {aka ‘struct _GClueDBusClient *’} [-Wincompatible-pointer-types] data->client = g_object_ref (client); ^ See https://bugzilla.gnome.org/show_bug.cgi?id=790697 for the gobject change that triggers this warning. https://bugs.freedesktop.org/show_bug.cgi?id=106236
-
Bastien Nocera authored
Rather than have the default 5 seconds timeout in 2 separate locations, move the default timeout value to the binary, so as to reduce the difference between the interactive and non-interactive behaviour, and reduce confusion. https://bugs.freedesktop.org/show_bug.cgi?id=106249
-
- Apr 27, 2018
-
-
Mathieu Bridon authored
This is necessary for most desktops to continue working as they were before GeoClue required an agent. However, GNOME already has its own agent, which allows authorizing apps individually, and as such doesn't need the demo agent. https://bugs.freedesktop.org/show_bug.cgi?id=106236
-
Mathieu Bridon authored
Most desktops don't have an agent. As a result, now that GeoClue refuses access without an agent, apps won't be able to obtain the location on those desktops. Installing the demo agent, as long as they start it, keeps things working just the same for those desktops: all accesses will continue being granted. https://bugs.freedesktop.org/show_bug.cgi?id=106236
-
-
- Apr 26, 2018
-
-
Zeeshan Ali authored
To make it clear that accuracy of 0 from agent means geolocation is disabled for the user. https://bugs.freedesktop.org/show_bug.cgi?id=106236
-
Bastien Nocera authored
To avoid races between clients and agents, make sure that an agent is required for each UID that wants its applications to be able to access location services. This will mean that desktop environments (and DIY ones) will need to have an agent running in the background to be able to ask authorisation questions. https://bugs.freedesktop.org/show_bug.cgi?id=106236
-
- Apr 22, 2018
-
-
Zeeshan Ali Khan authored
-
- Apr 18, 2018
-
-
Zeeshan Ali Khan authored
Add an option to set the TimeThreshold. https://bugs.freedesktop.org/show_bug.cgi?id=105993
-
Zeeshan Ali Khan authored
Some sources will be able to make use of this to reduce battery life so we should forward this information to them, via the Locator class. Currently, only ModemManager can do that but that's also where it makes most sense since GPS is the only source that can continuously fetch location updates and hence drain the most power. https://bugs.freedesktop.org/show_bug.cgi?id=105993
-
Zeeshan Ali Khan authored
Unlike other (real) location sources, Locator instances are unique for each client application. Which means we only need just one time-threshold value so we now provide getter and setter for time-threshold as guint, which is what will be set by the clients, instead of the time-threshold property of the parent class LocationSource (they can still do that if they wish though). https://bugs.freedesktop.org/show_bug.cgi?id=105993
-
-
Zeeshan Ali Khan authored
Implement the 'time-threshold' property of Modem interface. This implementation translates this to ModemLocation::gps-refresh-rate property of ModemManager service. https://bugs.freedesktop.org/show_bug.cgi?id=105993
-
Zeeshan Ali Khan authored
Add 'time-threshold' property of type guint, not GClueMinUINT to Modem interface. In a following patch, ModemManager implementation will translate this to ModemLocation::gps-refresh-rate property of ModemManager service. There is no reason to use the more complex GClueMinUINT type here since the Modem implementations are at the last end of the time-threshold users and hence just needs one specific value to be set on them. https://bugs.freedesktop.org/show_bug.cgi?id=105993
-
Zeeshan Ali Khan authored
In the following patches, this property will be used to set the GPS refresh rate on the ModemManager, based on the D-Bus TimeThreshold property. https://bugs.freedesktop.org/show_bug.cgi?id=105993
-
Zeeshan Ali Khan authored
This is a helper class that keeps a list of guint values and the minimum value from this list. In the following patches, it will be used by location sources to use the minimum time-threshold (location update rate) from all the time-thresholds requested by different applications. https://bugs.freedesktop.org/show_bug.cgi?id=105993
-
- Apr 14, 2018
-
-
Zeeshan Ali Khan authored
-
- Apr 11, 2018
-
-
Zeeshan Ali Khan authored
-
Zeeshan Ali Khan authored
In a19221e5 (modem-manager: Instant GPS location update), we started using the API introduced in 1.6.
-
- Sep 04, 2017
-
-
Zeeshan Ali Khan authored
A client process could create and destroy GClueSimple multiple times in its lifetime. Since the service keeps the Client (and it's associated location) object alive until the D-Bus connection from the client process remains alive and gclue_simple_new*() awaits for a location fix on the client it gets from service, subsequent calls to gclue_simple_new*() (after first one) will likely not return anytime soon. With this patch, GClueSimple now checks for any existing location object on the client object and doesn't keep waiting for location update if one is available already.
-
- Aug 11, 2017
-
-
GPS location updates are every 30s by default in ModemManager. This commit sets this rate to 0 (update as soon as the GPS sends a new location) so Geoclue can be used in real-time applications (like routing). https://bugs.freedesktop.org/show_bug.cgi?id=101975
-
- Jul 20, 2017
-
-
Zeeshan Ali Khan authored
Explain further in a comment that the apps white-list is not meant to list all the apps in the world.
-
- Jun 09, 2017
-
-
Commit d3893e6f introduced a constant TIME_DIFF_THRESHOLD with value 60. In the summary of the commit this is said to be 60s, however it is compared to the output of g_date_time_difference, which is in microseconds. Therefore, if we want the threshold to correspond to 1 minute, TIME_DIFF_THRESHOLD should have value 60000000. https://bugs.freedesktop.org/show_bug.cgi?id=101357
-
- May 29, 2017
-
-
Zeeshan Ali Khan authored
-
Zeeshan Ali Khan authored
-
- Apr 26, 2017
-
-
Zeeshan Ali Khan authored
-
Zeeshan Ali Khan authored
We were requiring altitude from NMEA GGA sentences and that later ends up in a crash cause we return a NULL location without setting an error.
-
- Mar 27, 2017
-
-
Zeeshan Ali Khan authored
-
- Mar 18, 2017
-
-
gnome-shell now uses Geoclue to show weather information in the calendar drop-down. While it can easily bypass the authorization dialog (being the agent itself), the location indicator loses its usefulness when permanently visible, so add it to the other system components in the whitelist. https://bugs.freedesktop.org/show_bug.cgi?id=100263
-
- Mar 13, 2017
-
-
This fixes a leak. https://bugs.freedesktop.org/show_bug.cgi?id=100175
-
Correct a copy&paste mistake in a doc comment. https://bugs.freedesktop.org/show_bug.cgi?id=100176
-
- Feb 28, 2017
-
-
Bastien Nocera authored
The gnome-settings-daemon color plugin uses Geoclue to guess the current location and deduce the sunset and sunrise times. Make sure that the functionality does not require a dialogue on startup when enabled. See https://bugzilla.gnome.org/show_bug.cgi?id=779343 https://bugs.freedesktop.org/show_bug.cgi?id=100008
-
- Jan 27, 2017
-
-
Zeeshan Ali Khan authored
-
Zeeshan Ali Khan authored
-