Skip to content
Snippets Groups Projects
  1. Sep 24, 2011
  2. Sep 21, 2011
    • Aaron Plattner's avatar
      fb: Rename wfbTriangles and wfbTrapezoids · 89881051
      Aaron Plattner authored and Jeremy Huddleston Sequoia's avatar Jeremy Huddleston Sequoia committed
      
      These symbols were not renamed when they were added to libfb:
      
       # nm -D libwfb.so | grep ' fb'
       0000000000028d00 T fbTrapezoids
       0000000000028d60 T fbTriangles
      
      This causes corruption and/or crashes on wfb-ful drivers like nvidia:
      
       Program received signal SIGABRT, Aborted.
       0x00007fd67f3a0405 in *__GI_raise (sig=<optimized out>) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
       64      ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
           in ../nptl/sysdeps/unix/sysv/linux/raise.c
       (gdb) bt
       #0  0x00007fd67f3a0405 in *__GI_raise (sig=<optimized out>) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
       #1  0x00007fd67f3a3680 in *__GI_abort () at abort.c:92
       #2  0x00007fd67f3995b1 in *__GI___assert_fail (assertion=0x7fd679ecb804 "key->initialized", file=<optimized out>, line=116, function=0x7fd679ecbbc0 "dixGetPrivateAddr")
           at assert.c:81
       #3  0x00007fd679ec55b6 in ?? () from /usr/lib/xorg/modules/libfb.so
       #4  0x00007fd679eca9ef in ?? () from /usr/lib/xorg/modules/libfb.so
       #5  0x00007fd679ecae20 in fbTriangles () from /usr/lib/xorg/modules/libfb.so
       #6  0x00007fd67a58fc55 in ?? () from /usr/lib/xorg/modules/drivers/nvidia_drv.so
       #7  0x00000000004f38d1 in ?? ()
       #8  0x0000000000437ae9 in ?? ()
       #9  0x0000000000426eaa in ?? ()
       #10 0x00007fd67f38cead in __libc_start_main (main=<optimized out>, argc=<optimized out>, ubp_av=<optimized out>, init=<optimized out>, fini=<optimized out>,
           rtld_fini=<optimized out>, stack_end=0x7fff99860d78) at libc-start.c:228
       #11 0x000000000042719d in _start ()
      
      Signed-off-by: Aaron Plattner's avatarAaron Plattner <aplattner@nvidia.com>
      Reviewed-by: default avatarJeremy Huddleston <jeremyhu@apple.com>
      Signed-off-by: default avatarKeith Packard <keithp@keithp.com>
      (cherry picked from commit 03d03299)
      89881051
    • Aaron Plattner's avatar
      xfree86: Bump extension ABI version to 6.0 · 4ad271d0
      Aaron Plattner authored and Keith Packard's avatar Keith Packard committed
      
      The video driver ABI was bumped to 11.0 in commit
      0de7cec9 because of a change to the
      size of ATOM in commit 51f353d0.  This
      also affects extension modules, so the extension ABI version should
      have been bumped too.
      
      Signed-off-by: Aaron Plattner's avatarAaron Plattner <aplattner@nvidia.com>
      Reviewed-by: default avatarPeter Hutterer <peter.hutterer@who-t.net>
      Signed-off-by: default avatarKeith Packard <keithp@keithp.com>
      4ad271d0
  3. Aug 26, 2011
  4. Aug 15, 2011
    • Adam Jackson's avatar
      fb: Fix memcpy abuse · e32cc0b4
      Adam Jackson authored and Keith Packard's avatar Keith Packard committed
      
      The memcpy fast path implicitly assumes that the copy walks
      left-to-right.  That's not something memcpy guarantees, and newer glibc
      on some processors will indeed break that assumption.  Since we walk a
      line at a time, check the source and destination against the width of
      the blit to determine whether we can be sloppy enough to allow memcpy.
      (Having done this, we can remove the check for !reverse as well.)
      
      On an Intel Core i7-2630QM with an NVIDIA GeForce GTX 460M running in
      NoAccel, the broken code and various fixes for -copywinwin{10,100,500}
      gives (edited to fit in 80 columns):
      
      1: Disable the fastpath entirely
      2: Replace memcpy with memmove
      3: This fix
      4: The code before this fix
      
        1            2                 3                 4           Operation
      ------   ---------------   ---------------   ---------------   ------------
      258000   269000 (  1.04)   544000 (  2.11)   552000 (  2.14)   Copy 10x10
       21300    23000 (  1.08)    43700 (  2.05)    47100 (  2.21)   Copy 100x100
         960      962 (  1.00)     1990 (  2.09)     1990 (  2.07)   Copy 500x500
      
      So it's a modest performance hit, but correctness demands it, and it's
      probably worth keeping the 2x speedup from having the fast path in the
      first place.
      
      Signed-off-by: Adam Jackson's avatarAdam Jackson <ajax@redhat.com>
      Signed-off-by: default avatarKeith Packard <keithp@keithp.com>
      e32cc0b4
    • Pelle Johansson's avatar
      XQuartz: Initialize darwin pointer valuators · ac2c307f
      Pelle Johansson authored and Jeremy Huddleston Sequoia's avatar Jeremy Huddleston Sequoia committed
      This fixes a regression introduced by: 633b81e8
      
      http://xquartz.macosforge.org/trac/ticket/498
      
      
      
      Signed-off-by: default avatarPelle Johansson <pelle@morth.org>
      Reviewed-by: default avatarJeremy Huddleston <jeremyhu@apple.com>
      ac2c307f
  5. Aug 10, 2011
  6. Aug 09, 2011
  7. Aug 04, 2011
  8. Jul 31, 2011
  9. Jul 29, 2011
  10. Jul 26, 2011
  11. Jul 20, 2011
  12. Jul 19, 2011
  13. Jul 15, 2011
  14. Jul 13, 2011
  15. Jul 07, 2011
Loading