• Thomas Haller's avatar
    wifi: don't use :1 bitfield for gboolean type · 610ca870
    Thomas Haller authored
    gboolean is a typedef for "int".
    
    While older compilers might treat such bitfields as unsigned ([1]),
    commonly such a bitfield is signed and can only contain the values 0
    and -1.
    
    We only want to use numeric 1 for TRUE, hence, creating such bitfields
    is wrong, or at least error prone.
    
    In fact, in this case it's a bug, because later we compare
    it with a regular gboolean
    
      if (priv->scanning != new_scanning)
    
    [1] https://lgtm.com/rules/1506024027114/
    
    Fixes: e0f96770
    610ca870
Name
Last commit
Last update
..
tests Loading commit data...
nm-supplicant-config.c Loading commit data...
nm-supplicant-config.h Loading commit data...
nm-supplicant-interface.c Loading commit data...
nm-supplicant-interface.h Loading commit data...
nm-supplicant-manager.c Loading commit data...
nm-supplicant-manager.h Loading commit data...
nm-supplicant-settings-verify.c Loading commit data...
nm-supplicant-settings-verify.h Loading commit data...
nm-supplicant-types.h Loading commit data...