Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • NetworkManager NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 171
    • Issues 171
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 14
    • Merge requests 14
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • NetworkManager
  • NetworkManagerNetworkManager
  • Merge requests
  • !807

Draft: cli: optionally support libedit instead of readline

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Adrian Freihofer requested to merge afreof/NetworkManager:af/libedit into main Apr 05, 2021
  • Overview 8
  • Commits 3
  • Pipelines 3
  • Changes 10

For preconfigured, closed embedded devices, the inclusion of GPLv3 software components is not possible. For NetworkManager this affects libreadline, which is used by nmcli. This change allows compiling with libedit instead of libreadline.

Support for editline seams to be broken. Therefore it gets removed.

  • Test build with autotools (readline / libedit)

  • Test build with meson

  • Test libedit linked nmcli

  • Fix incompatible pointer types

    [490/872] Compiling C object src/nmcli/nmcli.p/agent.c.o
    ../src/nmcli/agent.c: In function ‘get_secrets_from_user’:
    ../src/nmcli/agent.c:92:31: warning: assignment to ‘int (*)(const char *, int)’ from incompatible pointer type ‘int (*)(void)’ [-Wincompatible-pointer-types]
       92 |             rl_startup_hook   = set_deftext;
          |                               ^
    [493/872] Compiling C object src/nmcli/nmcli.p/common.c.o
    ../src/nmcli/common.c: In function ‘get_secrets_from_user’:
    ../src/nmcli/common.c:705:50: warning: assignment to ‘int (*)(const char *, int)’ from incompatible pointer type ‘int (*)(void)’ [-Wincompatible-pointer-types]
      705 |                         rl_startup_hook          = nmc_rl_set_deftext;
          |                                                  ^
    [494/872] Compiling C object src/nmcli/nmcli.p/connections.c.o
    ../src/nmcli/connections.c: In function ‘nmcli_editor_tab_completion’:
    ../src/nmcli/connections.c:6517:64: warning: assignment to ‘void (*)(void)’ from incompatible pointer type ‘void (*)(char **, int,  int)’ [-Wincompatible-pointer-types]
     6517 |                             rl_completion_display_matches_hook = uuid_display_hook;
          |                                                                ^
    ../src/nmcli/connections.c:6564:60: warning: assignment to ‘void (*)(void)’ from incompatible pointer type ‘void (*)(char **, int,  int)’ [-Wincompatible-pointer-types]
     6564 |                         rl_completion_display_matches_hook = uuid_display_hook;
          |                                                            ^
    ../src/nmcli/connections.c: In function ‘property_edit_submenu’:
    ../src/nmcli/connections.c:7358:29: warning: assignment to ‘int (*)(const char *, int)’ from incompatible pointer type ‘int (*)(void)’ [-Wincompatible-pointer-types]
     7358 |             rl_startup_hook = nmc_rl_set_deftext;
          |                             ^
Edited Apr 06, 2021 by Adrian Freihofer
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: af/libedit