Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • NetworkManager NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 194
    • Issues 194
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 23
    • Merge requests 23
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • NetworkManagerNetworkManager
  • NetworkManagerNetworkManager
  • Merge requests
  • !786

iwd: Don't call IWD methods when device unmanaged

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Andrew Zaborowski requested to merge balrog-kun/NetworkManager:iwd-autoconnect-init-fix into master Mar 18, 2021
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

When using IWD-side autoconnect mode (current default), in .deactivate() and .deactivate_async() refrain from commanding IWD to actually disconnect until the device is managed. Likely the device is already disconnected but in any case it's up to IWD to decide in this mode.

Calling IWD device's .Disconnect() D-Bus method has the side effect of disabling autoconnect and doing this while NM is still in platform-init was unexpectedly leaving the device without autoconnect after platform-init was done, according to user reports.

Fixes: dc0e31fb

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: iwd-autoconnect-init-fix