Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • NetworkManager NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 192
    • Issues 192
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • NetworkManagerNetworkManager
  • NetworkManagerNetworkManager
  • Merge requests
  • !776

devices: fail optional-802.1X connections if supplicant disappears

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Beniamino Galvani requested to merge bg/802-1x-supplicant-fix into master Mar 09, 2021
  • Overview 2
  • Commits 1
  • Pipelines 2
  • Changes 1

802-1x.optional=yes means that NM should tolerate a failure or a timeout of the 802.1X authentication and should keep the connection up. Even if the authentication doesn't succeed, NM keeps the supplicant running so that it can continue trying.

If the supplicant disappears because it crashed or was killed externally, NM should fail the connection so that it can be retried.

The current code is wrong also because after releasing the supplicant interface, it calls wired_auth_cond_fail() which tries to connect a signal to priv->supplicant.iface (which is NULL).

https://bugzilla.redhat.com/show_bug.cgi?id=1934291

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bg/802-1x-supplicant-fix