Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • NetworkManager NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 169
    • Issues 169
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • NetworkManagerNetworkManager
  • NetworkManagerNetworkManager
  • Merge requests
  • !732

tools: Find the NetworkManager-all-sym binary location.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed orbea requested to merge orbea/NetworkManager:libtool into master Jan 19, 2021
  • Overview 7
  • Commits 1
  • Pipelines 2
  • Changes 1

When building NetworkManager with slibtool (https://dev.midipix.org/cross/slibtool) it will compile, but then it will fail to correctly work during runtime. For example it does not find my wifi device.

This is because the create-exports-NetworkManager.sh script hardcodes the of the build binary.

https://gitlab.freedesktop.org/orbea/NetworkManager/-/blob/6af73f9d172d6ba11a1b865f9a19881373cf8666/tools/create-exports-NetworkManager.sh#L43

With slibtool this is instead a libtool wrapper script and not the actual binary.

$ find ./src/ -type f -name NetworkManager-all-sym -exec file {} \;
./src/.libs/NetworkManager-all-sym: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 3.2.0, not stripped
./src/NetworkManager-all-sym: POSIX shell script, ASCII text executable

This MR attempts to automatically find the correct NetworkManager-all-sym binary without depending on it being in a specific location which is enough to fix NetworkManager when built with slibtool.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: libtool