Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • NetworkManager NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 163
    • Issues 163
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 17
    • Merge requests 17
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • NetworkManagerNetworkManager
  • NetworkManagerNetworkManager
  • Merge requests
  • !687

[th/dns-resolved-fix-exclusive] dns: fix handling default routing domains with systemd-resolved

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Thomas Haller requested to merge th/dns-resolved-fix-exclusive into master Nov 19, 2020
  • Overview 11
  • Commits 2
  • Pipelines 2
  • Changes 4
    We used to set "~." domains for all devices that should be used for
    resolving unknown domains.
    
    Systemd-resolved also supports setting "SetLinkDefaultRoute()".
    We should only set the wildcard domain if we want that this
    interface is used exclusively. Otherwise, we should only set
    DefaultRoute. See ([1], [2], [3]).
    
    Otherwise the bad effect is if other components (wg-quick) want
    to set exclusive DNS lookups on their link. That is achieved by
    explicitly adding "~." and that is also what resolved's
    `/usr/sbin/resolvconf -x` does. If NetworkManager sets "~." for
    interfaces that are not important and should not be used exclusively,
    then this steals the DNS requests from those external components.
    
    In NetworkManager we know whether a link should get exclusive lookups
    based on the "ipv[46].dns-priority" setting.
    
  • [1] https://www.freedesktop.org/software/systemd/man/org.freedesktop.resolve1.html
  • [2] https://www.freedesktop.org/software/systemd/man/systemd-resolved.service.html
  • [3] https://github.com/systemd/systemd/issues/17529#issuecomment-730522444
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: th/dns-resolved-fix-exclusive