Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • NetworkManager NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 170
    • Issues 170
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 20
    • Merge requests 20
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • NetworkManagerNetworkManager
  • NetworkManagerNetworkManager
  • Merge requests
  • !378

[th/unix-fd-source]

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Thomas Haller requested to merge th/unix-fd-source into master Jan 01, 2020
  • Overview 4
  • Commits 15
  • Pipelines 2
  • Changes 16

We don't need an GIOChannel to watch a file descriptor.

It's well understood what file descriptors are, and that we want to poll/select on them to know when there is something ready. We don't need an GIOChannel for that, just watch the fd directly.

On a minor point, this reduces some overhead of also creating a unnecessary GIOChannel.

The larger point is that watching a file descriptor alone is simple and clear. It's not clear what the GIOChannel does (e.g. it has code for handing text encoding and uses buffers). It just adds a lot of additional code and API that we don't need nor want.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: th/unix-fd-source