Skip to content

libnm: fix bounds check in _get_mac_blacklist_item

Jan Vaclav requested to merge jvaclav/NetworkManager:jv/fix-wireless-bounds-check into main

Summary

This merge request makes it so that the *_get_mac_blacklist_item functions return NULL when idx == len, instead of attempting to read from the array.

Purpose

The original bounds check is incorrect, as we cannot access the array at idx == len.

Checklist

Please read https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/main/CONTRIBUTING.md before opening the merge request. In particular, check that:

  • the subject for all commits is concise and explicative
  • the message for all commits explains the reason for the change
  • the source is properly formatted
  • any relevant documentation is up to date
  • you have added unit tests if applicable
Edited by Jan Vaclav

Merge request reports