Skip to content

device: delete software device when lose carrier and is controller

Fernando Fernández Mancera requested to merge ff/vlan_automatically_revive into main

Summary

    device: delete software device when lose carrier and is controller
    
    Software devices that are controllers like bond/bridge/team when
    configured to not ignore carrier are being deleted when deactivating the
    device. Software devices that are not controllers, shouldn't be deleted.
    
    Otherwise, if a VLAN link is deleted because the ethernet carrier-change
    then NetworkManager won't be able to reactivate the VLAN once the
    ethernet gets carrier because the link is not present.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=2224479
    
    Fixes: efa63aef3aeb ('device: delete software device when software devices lose carrier')

Checklist

Please read https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/main/CONTRIBUTING.md before opening the merge request. In particular, check that:

  • the subject for all commits is concise and explicative
  • the message for all commits explains the reason for the change
  • the source is properly formatted
  • any relevant documentation is up to date
  • you have added unit tests if applicable
Edited by Fernando Fernández Mancera

Merge request reports