Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • NetworkManager NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 170
    • Issues 170
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 18
    • Merge requests 18
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • NetworkManagerNetworkManager
  • NetworkManagerNetworkManager
  • Merge requests
  • !1518

Draft: all: don't add proxy setting during normalization

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Beniamino Galvani requested to merge bg/proxy into main Jan 27, 2023
  • Overview 4
  • Commits 2
  • Pipelines 2
  • Changes 54

It doesn't seem useful to always add the proxy setting to each connection profile that supports IP configuration. This normalization requires additional code and especially, it creates a new empty section in every new keyfile:

 # nmcli connection add type dummy ifname dummy1
 # cat /etc/NetworkManager/system-connections/dummy-dummy1.nmconnection
 [connection]
 id=dummy-dummy1
 uuid=8dd2bb73-b338-428f-ad6d-082c37a58566
 type=dummy
 interface-name=dummy1

 [dummy]

 [ipv4]
 method=disabled

 [ipv6]
 addr-gen-mode=default
 method=disabled

 [proxy]

Since an empty (with method=none) proxy setting is the same as no proxy setting, avoid the normalization.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bg/proxy