Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • NetworkManager NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 161
    • Issues 161
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 18
    • Merge requests 18
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • NetworkManagerNetworkManager
  • NetworkManagerNetworkManager
  • Merge requests
  • !1462

device: restart DHCP when the MAC changes and the client-id is fixed

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Beniamino Galvani requested to merge bg/dhcp-restart-pt2 into main Nov 17, 2022
  • Overview 7
  • Commits 2
  • Pipelines 1
  • Changes 5

If the MAC changes there is the possibility that the DHCP client will not be able to renew the address because it uses the old MAC as CHADDR. Depending on the implementation, the DHCP server might use CHADDR (so, the old address) as the destination MAC for DHCP replies, and those packets will be lost.

To avoid this problem, we need to restart the DHCP client after a MAC change; that has the disadvantage that the server will give out a different address, unless the client is sending a explicit client-id. So, limit the restart to situations where the client-id is explicitly set to a fixed value.

https://bugzilla.redhat.com/show_bug.cgi?id=2110000

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bg/dhcp-restart-pt2