Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • NetworkManager NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 167
    • Issues 167
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

Update #1:

Due to abusive users subverting our CI facilities to mine cryptocurrency, breaking out of the container sandbox in the process, we have been forced to take actions to limit the usage of the public runners to official projects only.

The policy will be enforced on 2023-03-23 (or before if we detect abuses).

Please see this issue for more context and to see if and how you are impacted.

  • NetworkManagerNetworkManager
  • NetworkManagerNetworkManager
  • Merge requests
  • !1437

agent-manager: return all secrets if we don't need to ask agents

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Beniamino Galvani requested to merge bg/agent-secrets into main Oct 24, 2022
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 1

When the connection already has all needed secrets, _con_get_try_complete_early() returns existing_secrets without asking to agents; existing_secrets is initialized with system secrets.

In NMSettingsConnection, get_secrets_done_cb() strips all secrets from the connection and then merges the secrets returned by nm_agent_manager_get_secrets(). Since nm_agent_manager_get_secrets() returns only system secrets, the result is that agent owned secrets are not asked to agents and are removed from the connection.

Fix this by returning all secrets from the agent manager.

https://gitlab.gnome.org/GNOME/network-manager-applet/-/issues/157

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bg/agent-secrets