Skip to content

Revert "libnm: buffer reads in nm_vpn_service_plugin_read_vpn_details()"

BryanJacobs requested to merge BryanJacobs/NetworkManager:main into main

This partially reverts commit 4a9fcb0f, which replaced one-byte reads with buffered ones in the VPN service plugin.

Unfortunately the buffering means that commands coming after the magic "DONE" string were being pulled into the buffer. Secrets agents expect a "QUIT" to come after the "DONE", and since with buffering "QUIT" was in the buffer, this led to a twenty-second delay on every VPN connection using a secrets manager.

Yes, EVERY SINGLE connection. A twenty second delay while the secrets manager timed out.

Performance optimizations are only good where they improve performance; the intent of the previous commit was good but the outcome was not.

Merge request reports

Loading