Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • NetworkManager NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 165
    • Issues 165
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 19
    • Merge requests 19
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • NetworkManagerNetworkManager
  • NetworkManagerNetworkManager
  • Merge requests
  • !1113

[th/shutdown-timeout-increase]: increase NM_SHUTDOWN_TIMEOUT_MAX_MSEC to 5000 and cleanups

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Thomas Haller requested to merge th/shutdown-timeout-increase into main Feb 21, 2022
  • Overview 3
  • Commits 5
  • Pipelines 3
  • Changes 10

Today, when NetworkManager quits after SIGTERM, it synchronously performs some cleanup actions and quits. That has problems, and in the future the shutdown needs to be reworked as described in the TODO file.

While the FIXME(shutdown) work is not yet done, we already have various API and things in place, for those future changes (nm_shutdown_wait_obj_*() and NM_SHUTDOWN_TIMEOUT_*).

This branch cleans up some things related to NM_SHUTDOWN_TIMEOUT* macros. In particular, the shutdown grace period gets incremented to 5 seconds, so it can also cover the time it takes before killing pppd.

There is no actual change in behavior in this branch, instead, it is a preparation for the future work.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: th/shutdown-timeout-increase