Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • NetworkManager NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 169
    • Issues 169
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • NetworkManagerNetworkManager
  • NetworkManagerNetworkManager
  • Merge requests
  • !1080

[th/device-update-metered] device: update metered status when getting DHCP lease

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Thomas Haller requested to merge th/device-update-metered into main Feb 02, 2022
  • Overview 4
  • Commits 1
  • Pipelines 2
  • Changes 1

The metered status can depend on the DHCP lease, as we accept the ANDROID_METERED vendor option. That means, on a DHCP update we need to re-evaluate the metered flag.

This fixes a potential race, where IPv6 might succeed first and activation completes (with GUESS_NO metered flag). A subsequent DHCPv4 update requires to re-evaluate that decision.

Test: @connection_metered_guess_yes


This is supposed to help with test @connection_metered_guess_yes. See for example here.

Note that it doesn't fully fix the current version of connection_metered_guess_yes, because there is still a race that the metered state is not yet update-to-date the moment we are activated. We would either need to disable IPv6 or wait until IPv4 is ready.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: th/device-update-metered