Skip to content

[bond] allow mii monitoring if arp_interval is incompatible

suresh2514 requested to merge suresh2514/NetworkManager:ks into main

arp monitoring is not supported for LACP(802.3AD), TLB and ALB bonding modes. If configured, the bonding module will fail-over to mii monitoring which is the default behavior of bonding module.

But NM checks only NM_BOND_MODE_TLB, NM_BOND_MODE_ALB bonding modes and exit with failure if arp_interval is used whereas for LACP, we find bond up with all slaves and using mii monitoring.

From : drivers/net/bonding/bond_options.c

255     [BOND_OPT_ARP_INTERVAL] = {
256         .id = BOND_OPT_ARP_INTERVAL,
257         .name = "arp_interval",
258         .desc = "arp interval in milliseconds",
259         .unsuppmodes = BIT(BOND_MODE_8023AD) | BIT(BOND_MODE_TLB) |
260                    BIT(BOND_MODE_ALB),
261         .values = bond_intmax_tbl,
262         .set = bond_option_arp_interval_set
263     },

So if un-supported mode is used, give a warning and let bond come up with default mii monitoring

Signed-off-by: suresh kumar suresh2514@gmail.com

Edited by Thomas Haller

Merge request reports