• Thomas Haller's avatar
    nmtst: fix compiler warnings and make initialization of macro variables explict · 54ed36e3
    Thomas Haller authored
    
    
    clang warns about uninitialized variables @__cur_setting_name and
    @__cur_property_name as used inside @__code. Before calling to @__code,
    explicitly initialize the values.
    
        Making all in tests
        make[4]: Entering directory `./NetworkManager/libnm-core/tests'
          CC       test-general.o
        test-general.c:2730:24: error: variable '__cur_property_name' is uninitialized when used here [-Werror,-Wuninitialized]
                                      NMTST_VARIANT_DROP_PROPERTY (NM_SETTING_CONNECTION_SETTING_NAME,
                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        ../../include/nm-test-utils.h:1079:20: note: expanded from macro 'NMTST_VARIANT_DROP_PROPERTY'
                                    && !strcmp (__cur_property_name, __property_name)) \
                                                ^~~~~~~~~~~~~~~~~~~
        ../../include/nm-test-utils.h:1023:3: note: expanded from macro 'NMTST_VARIANT_EDITOR'
                        __code; \
                        ^
        test-general.c:2729:2: note: variable '__cur_property_name' is declared here
                NMTST_VARIANT_EDITOR (connection_dict,
                ^
        ../../include/nm-test-utils.h:1015:3: note: expanded from macro 'NMTST_VARIANT_EDITOR'
                        const char *__cur_setting_name, *__cur_property_name; \
                        ^
        [...]
    Signed-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
    54ed36e3
nm-test-utils.h 31 KB