vc4: Declare the cpu pointers as being modified in NEON asm.
Otherwise, the compiler is free to reuse the register containing the input for another call and assume that the value hasn't been modified. Fixes crashes on texture upload/download with current gcc. We now have to have a temporary for the cpu2 value, since outputs must be lvalues. (commit message by anholt) Fixes: 4d300242 ("vc4: Use NEON to speed up utile loads on Pi2.") (cherry picked from commit 300d3ae8) [Emil: apply the patch to vc4_tiling_lt.c instead of v3d_cpu_tiling.h] Signed-off-by:Emil Velikov <emil.velikov@collabora.com> Conflicts: src/broadcom/common/v3d_cpu_tiling.h Squashed with commit: vc4: Declare the last cpu pointer as being modified in NEON asm. Earlier commit addressed 7 of the 8 instances available. v2: Rebase patch back to master (by anholt) Cc: Carsten Haitzler (Rasterman) <raster@rasterman.com> Cc: Eric Anholt <eric@anholt.net> Fixes: 300d3ae8 ("vc4: Declare the cpu pointers as being modified in NEON asm.") Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> (cherry picked from commit 385843ac) Conflicts: src/broadcom/common/v3d_cpu_tiling.h
Loading
Please register or sign in to comment