Skip to content
Snippets Groups Projects
Commit 55e6454d authored by Ian Romanick's avatar Ian Romanick
Browse files

intel/fs: Fix extract_u8 of an odd byte from a 64-bit integer


In the old code, we would generate the exact same instruction for
extract_u8(some_u64, 0) and extract_u8(some_u64, 1).  The mask-a-word
trick only works for even numbered bytes.

This fixes the (new) piglit test
tests/spec/arb_gpu_shader_int64/execution/fs-ushr-and-mask.shader_test.

v2: Use a SHR instead of an AND.  This saves an instruction compared to
using two moves.  Suggested by Jason.

Fixes: 6ac2d169 ("i965/fs: Fix extract_i8/u8 to a 64-bit destination")
Reviewed-by: default avatarJason Ekstrand <jason@jlekstrand.net>
parent 4aaf139e
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment