Skip to content
Snippets Groups Projects
Commit 1a2b227f authored by Ernestas Kulik's avatar Ernestas Kulik Committed by Emil Velikov
Browse files

vc4: Fix leak in HW queries error path


Reported by Coverity: in the case where there exist hardware and
non-hardware queries, the code does not jump to err_free_query and leaks
the query.

CID: 1430194
Signed-off-by: default avatarErnestas Kulik <ernestas.kulik@gmail.com>
Fixes: 9ea90ffb ("broadcom/vc4: Add support for HW perfmon")
(cherry picked from commit f6e49d5a)
parent 6beaa2d7
No related branches found
No related tags found
No related merge requests found
......@@ -132,7 +132,7 @@ vc4_create_batch_query(struct pipe_context *pctx, unsigned num_queries,
/* We can't mix HW and non-HW queries. */
if (nhwqueries && nhwqueries != num_queries)
return NULL;
goto err_free_query;
if (!nhwqueries)
return (struct pipe_query *)query;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment