- Jun 06, 2021
-
-
Aleksander Morgado authored
-
Aleksander Morgado authored
-
Aleksander Morgado authored
Explicitly ignore the "wwan_dev" device as it is not associated with separate ports (which is what MM needs), but with the whole device instead. See https://lists.freedesktop.org/archives/modemmanager-devel/2021-May/008629.html (cherry picked from commit ac18b5ac)
-
For now WWAN subsystem support has only been validated for PCI/MHI based devices and extra patches for USB based devices (qmi_wwan, cdc-mbim...) may be required, so do not consider WWAN ports being on USB bus. Signed-off-by: Loic Poulain <loic.poulain@linaro.org> (cherry picked from commit c39d1d2f)
-
Aleksander Morgado authored
This message is too specific, and there are a lot of cases where it wouldn't apply. E.g. when a MBIM module is stuck in low power mode due to some other reason (like hardware rfkill), this message would pop up to the users and completely confuse them. (cherry picked from commit 464c0d46)
-
- Jun 04, 2021
-
-
Aleksander Morgado authored
This reverts commit da23f9cd. The stable 1.16 branch does not build-depend on any libmbim git master version, so we should not report the QDU firmware update method as supported in MM at this point. It would not have been a big problem if we did expose the QDU firmware update method, because the logic in fwupd checks the MM and libmbim versions separately, but I think it's better to skip reporting QDU as supported ourselves for consistency with the minimum libmbim version we require.
-
Aleksander Morgado authored
This reverts commit 2cb38c56.
-
- Jun 03, 2021
-
-
Aleksander Morgado authored
Use the new "DMS Foxconn Set FCC authentication" command to request the modem unlock during a power up operation. Fixes mobile-broadband/ModemManager#373 (cherry picked from commit 9fdbbc69)
-
Aleksander Morgado authored
-
Aleksander Morgado authored
Use the new generic FCC unlock step instead of implementing it within the power up setup logic. (cherry picked from commit 76f24256)
-
Aleksander Morgado authored
Use the new generic FCC unlock step instead of implementing it within the operating mode setup logic. The operation is implemented in the MMSharedQmi interface as it will also be used by the MBIM modem object. (cherry picked from commit b9596c81)
-
Aleksander Morgado authored
There are devices that come locked before they can be put online. Until now we had a specific implementation for this in the generic QMI modem, but we should have it in a more generic way for any kind of modem. (cherry picked from commit 6ca75c76)
-
Aleksander Morgado authored
Under certain rare conditions (e.g. race between querying devices of a given subsystem and the kernel tearing those devices down), the subsystem reported for a GUdevDevice seems to be NULL. So, ensure both subsystem and name are set on the GUdevDevice before we process them. The issue has been observed on GUdevDevices listed by g_udev_client_query_by_subsystem(), not on the ones asynchronously reported via uevents, but we add the validity check on both places for consistency. Fixes mobile-broadband/ModemManager#343 (cherry picked from commit 94006341)
-
- Jun 02, 2021
-
-
Aleksander Morgado authored
(cherry picked from commit ec8bf7f0)
-
Aleksander Morgado authored
The logic that creates the device identifier uses some fields that are exposed in DBus (e.g. model, manufacturer...). We should not attempt to load any of that info if the DBus skeleton for the Modem interface is no longer available, as e.g. the device may have gone away already. Fixes mobile-broadband/ModemManager#374 (cherry picked from commit 3da3623e)
-
Aleksander Morgado authored
(cherry picked from commit eefcf920)
-
Reported at https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1371 (cherry picked from commit 0b8607bc)
-
Aleksander Morgado authored
Having a switch() for the MBIM services when processing indications forces us to update it on every new MBIM service added to libmbim, because we build with -Wswitch-enum by default. This warning type is extremely useful, and we should not stop using it, so let's simplify a bit the indication handling code and skip using a switch(). There are right now only 4 different service indications expected, so it shouldn't be a big deal. (cherry picked from commit e25a585c)
-
QLWURCs are not ignored and causes calls to be rejected in some cases (cherry picked from commit c00eff43)
-
- May 21, 2021
-
-
Aleksander Morgado authored
-
Based on the QDU service newly added in libmbim, T99W175 module (vid: 0x105b) supports MBIM QDU based update. (cherry picked from commit 35b1672b)
-
0x0489 is the vendor ID of T77W968, 0x105b is the vendor ID of T99W175. {0x105b, 0xe0b0},{0x105b, 0xe0b1} is T99W175 PCI device, used by Dell. {0x105b, 0xe0ab} is T99W175 PCI device, used by Lenovo. If the modem has an mbim port, create a MbimFoxconn object, regardless of what the product ID is. The firmware version format in the T99W175 was selected to have firmware version + carrier config version + apps version. (cherry picked from commit 47ea5c98)
-
Named the object in a more generic way. (cherry picked from commit c3148860)
-
SDX55 modem can take slighlty more than 25 seconds to start all its services from cold boot/reset (including QMI services), causing QMI port opening timeout error. This patch increases the qmi_device_open timeout from 25 seconds to 45 seconds to prevent such issue. Signed-off-by: Loic Poulain <loic.poulain@linaro.org> (cherry picked from commit e57c59bf)
-
wwan is a new subsystem for WWAN devices, allowing to expose the WWAN device and its ports in a generic way. The sysfs hierarchy for such device is /sys/class/wwanX /sys/class/wwanX/wwanXpYP Where X is the WWAN device index, Y the port index and P the control protocol name (QMI, MBIM...). A control port is also exposed as character device in /dev. Signed-off-by: Loic Poulain <loic.poulain@linaro.org> (cherry picked from commit fefbf4d3)
-
For MHI data port (mhi-net), simply return the primary QMI port. Signed-off-by: Loic Poulain <loic.poulain@linaro.org> (cherry picked from commit 6895ca83)
-
Add support for the Linux wwan subsystem that started to expose control channel as character devices (e.g. /dev/wwan0p1MBIM...). Signed-off-by: Loic Poulain <loic.poulain@linaro.org> (cherry picked from commit 6db2e8f0)
-
Allow WWAN control ports. Signed-off-by: Loic Poulain <loic.poulain@linaro.org> (cherry picked from commit b1db6527)
-
The new Linux WWAN subsystem exposes the various WWAN control ports as character devices. WWAN port device naming follows the following convention: wwanXpYP, where X is the wwan device index, Y the port index and P the port type/protocol. Signed-off-by: Loic Poulain <loic.poulain@linaro.org> (cherry picked from commit aaf8c17e)
-
- May 18, 2021
-
-
Aleksander Morgado authored
mm-common-helpers.c: In function 'mm_get_int_from_str': mm-common-helpers.c:1349:13: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (eol == num) ^~ mm-common-helpers.c: In function 'mm_utils_hexstr2bin': mm-common-helpers.c:1718:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < len; i += 2) { ^ (cherry picked from commit d661d822)
-
Aleksander Morgado authored
The g_dbus_proxy_get_default_timeout() is by default -1 unless explicitly updated, so the check doesn't make any sense really. We didn't see any warning produced because mmcli provides an explicit timeout of 30s, so it was never the default -1. (cherry picked from commit 21ff48ed)
-
Aleksander Morgado authored
mm-bearer-properties.c:725:1: warning: 'cmp_allow_roaming' defined but not used [-Wunused-function] cmp_allow_roaming (gboolean a, ^~~~~~~~~~~~~~~~~ (cherry picked from commit a325acd6)
-
Aleksander Morgado authored
This fixes a few (fatal in gcc 11) warnings. See https://gitlab.gnome.org/GNOME/glib/-/issues/600 (cherry picked from commit 268cab88)
-
- May 14, 2021
-
-
When the message is a transfer-route MT, there is no SMSC address to parse out. This flag allows indicating when the PDU is one such message. (cherry picked from commit 43c39d52)
-
This handles transfer-route MT messages, automatically ACKing any that need to be ACKed. Based on work by Angus Ainslie and Elias Rudberg (cherry picked from commit 205e9edf)
-
Aleksander Morgado authored
We're going to use add support for the transfer-route MT messages in the stable MM 1.16 branch, so we should make sure the related QMI messages have been added to the basic collection, as already done in libqmi 1.28.4.
-
- May 03, 2021
-
-
Aleksander Morgado authored
So make all CI pipelines on the stable branch run with those specific libqmi and libmbim branches.
-
Aleksander Morgado authored
TEST: test-stub... /MM/stub/modem/interface: dbus-daemon[48020]: [session uid=0 pid=48020] Activating service name='org.freedesktop.ModemManager1' requested by ':1.0' (uid=0 pid=48005 comm="/builds/mobile-broadband/ModemManager/tools/tests/") Traceback (most recent call last): File "/builds/mobile-broadband/ModemManager/tools/test-modemmanager-service.py", line 7, in <module> gi.require_version('ModemManager', '1.0') File "/usr/lib/python3/dist-packages/gi/__init__.py", line 129, in require_version raise ValueError('Namespace %s not available' % namespace) ValueError: Namespace ModemManager not available dbus-daemon[48020]: [session uid=0 pid=48020] Activated service 'org.freedesktop.ModemManager1' failed: Process org.freedesktop.ModemManager1 exited with status 1 (cherry picked from commit 7b7bbdd9)
-
Aleksander Morgado authored
The template image we're using already contains all the necessary build deps to enable introspection and gtk-doc, so we need to explicitly disable them where we don't need them, or otherwise they'll be automatically enabled as the deps are found. (cherry picked from commit 4593eec1)
-
Aleksander Morgado authored
(cherry picked from commit d9072562)
-